From: "Theodore Ts'o" <tytso@mit.edu>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, yangerkun@huawei.com
Subject: Re: [PATCH v1 1/2] ext4: find old entry again if failed to rename whiteout
Date: Sat, 20 Mar 2021 23:59:43 -0400 [thread overview]
Message-ID: <YFbErxtWpQJ7eTbQ@mit.edu> (raw)
In-Reply-To: <a81cf4d6-a934-9031-7e9d-f5a91647d210@huawei.com>
On Fri, Mar 12, 2021 at 10:01:50AM +0800, zhangyi (F) wrote:
>
> In this error path of whiteout rename, we want to restore the old inode
> number and old name back to the old entry, it's just a rollback operation.
> The old entry will stay where it was in common cases, but it can be moved
> from the first block to the leaf block during make indexed dir for one
> special case, but it cannot be deleted in theory. So if we cannot find it
> again, there must some bad thing happen and the filesystem may probably
> inconsistency. So I calling ext4_std_error() here，or am I missing something？
After looking at this more closely, I agree, this should be OK. The
directory is going to be locked, so it shouldn't be changing out from
under us.
Thanks, applied.
- Ted
prev parent reply other threads:[~2021-03-21 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:17 [PATCH v1 1/2] ext4: find old entry again if failed to rename whiteout zhangyi (F)
2021-03-03 13:17 ` [PATCH v1 2/2] ext4: Do not iput inode under running transaction in ext4_rename() zhangyi (F)
2021-03-21 4:09 ` Theodore Ts'o
2021-03-11 15:43 ` [PATCH v1 1/2] ext4: find old entry again if failed to rename whiteout Theodore Ts'o
2021-03-12 2:01 ` zhangyi (F)
2021-03-21 3:59 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFbErxtWpQJ7eTbQ@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.