From: "Theodore Ts'o" <tytso@mit.edu>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz, yangerkun@huawei.com
Subject: Re: [PATCH v1 2/2] ext4: Do not iput inode under running transaction in ext4_rename()
Date: Sun, 21 Mar 2021 00:09:51 -0400 [thread overview]
Message-ID: <YFbHD+jwinE0D35w@mit.edu> (raw)
In-Reply-To: <20210303131703.330415-2-yi.zhang@huawei.com>
On Wed, Mar 03, 2021 at 09:17:03PM +0800, zhangyi (F) wrote:
> In ext4_rename(), when RENAME_WHITEOUT failed to add new entry into
> directory, it ends up dropping new created whiteout inode under the
> running transaction. After commit <9b88f9fb0d2> ("ext4: Do not iput inode
> under running transaction"), we follow the assumptions that evict() does
> not get called from a transaction context but in ext4_rename() it breaks
> this suggestion. Although it's not a real problem, better to obey it, so
> this patch add inode to orphan list and stop transaction before final
> iput().
>
> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2021-03-21 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:17 [PATCH v1 1/2] ext4: find old entry again if failed to rename whiteout zhangyi (F)
2021-03-03 13:17 ` [PATCH v1 2/2] ext4: Do not iput inode under running transaction in ext4_rename() zhangyi (F)
2021-03-21 4:09 ` Theodore Ts'o [this message]
2021-03-11 15:43 ` [PATCH v1 1/2] ext4: find old entry again if failed to rename whiteout Theodore Ts'o
2021-03-12 2:01 ` zhangyi (F)
2021-03-21 3:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFbHD+jwinE0D35w@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.