[PATCH] usb: dwc3: core: don't enable wakeup for runtime PM

[PATCH] usb: dwc3: core: don't enable wakeup for runtime PM

[Li Jun]

Don't enable dwc3 core to wakeup system by default if runtime suspended,
this will make the power domain of dwc3 core or its parent device can't be
off while system sleep even system wakeup by usb is not required.

Signed-off-by: Li Jun <jun.li@nxp.com>
---
 drivers/usb/dwc3/core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 6969196..a8466f6 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1788,8 +1788,6 @@ static int dwc3_runtime_suspend(struct device *dev)
 	if (ret)
 		return ret;
 
-	device_init_wakeup(dev, true);
-
 	return 0;
 }
 
@@ -1798,8 +1796,6 @@ static int dwc3_runtime_resume(struct device *dev)
 	struct dwc3     *dwc = dev_get_drvdata(dev);
 	int		ret;
 
-	device_init_wakeup(dev, false);
-
 	ret = dwc3_resume_common(dwc, PMSG_AUTO_RESUME);
 	if (ret)
 		return ret;
-- 
2.7.4

Re: [PATCH] usb: dwc3: core: don't enable wakeup for runtime PM

[Greg KH]

On Wed, Mar 03, 2021 at 06:37:37PM +0800, Li Jun wrote:
> Don't enable dwc3 core to wakeup system by default if runtime suspended,
> this will make the power domain of dwc3 core or its parent device can't be
> off while system sleep even system wakeup by usb is not required.
> 
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---

What commit does this fix?  Does it need to go to stable kernels?  If
so, how far back?

Please add that information to the signed-off-by area when resending.

thanks,

greg k-h

RE: [PATCH] usb: dwc3: core: don't enable wakeup for runtime PM

[Jun Li]

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, March 23, 2021 7:52 PM
> To: Jun Li <jun.li@nxp.com>
> Cc: balbi@kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH] usb: dwc3: core: don't enable wakeup for runtime PM
> 
> On Wed, Mar 03, 2021 at 06:37:37PM +0800, Li Jun wrote:
> > Don't enable dwc3 core to wakeup system by default if runtime
> > suspended, this will make the power domain of dwc3 core or its parent
> > device can't be off while system sleep even system wakeup by usb is not
> required.
> >
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > ---
> 
> What commit does this fix?  Does it need to go to stable kernels?  If so,
> how far back?
> 
> Please add that information to the signed-off-by area when resending.

Just sent out v2 with fix tag and cc to stable kernel.

Thanks
Li Jun
> 
> thanks,
> 
> greg k-h