From: Tony Lindgren <tony@atomide.com>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 2194/6512] arch/arm/mach-omap2/pdata-quirks.c:578:1: warning: no previous prototype for function 'pdata_quirks_init_clocks'
Date: Wed, 24 Mar 2021 12:21:16 +0200 [thread overview]
Message-ID: <YFsSnHVIfuRoAxG0@atomide.com> (raw)
In-Reply-To: <202103240642.vvusWJ8u-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2829 bytes --]
* kernel test robot <lkp@intel.com> [210323 22:10]:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d949689e7383cd5271470f2b99dbe2fd3199bffd
> commit: a15de032a72d511431294331f4bb47245f18b801 [2194/6512] ARM: OMAP2+: Init both prm and prcm nodes early for clocks
> config: arm-randconfig-r035-20210323 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 78a65cd945d006ff02f9d24d9cc20a302ed93b08)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a15de032a72d511431294331f4bb47245f18b801
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout a15de032a72d511431294331f4bb47245f18b801
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> arch/arm/mach-omap2/pdata-quirks.c:578:1: warning: no previous prototype for function 'pdata_quirks_init_clocks' [-Wmissing-prototypes]
> pdata_quirks_init_clocks(const struct of_device_id *omap_dt_match_table)
> ^
> arch/arm/mach-omap2/pdata-quirks.c:577:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> void __init
> ^
> static
> 1 warning generated.
Thanks for the report FYI, I'm applying the following patch to fix this:
https://lore.kernel.org/linux-omap/20210318135649.1286347-1-weiyongjun1(a)huawei.com/T/#u
Regards,
Tony
> vim +/pdata_quirks_init_clocks +578 arch/arm/mach-omap2/pdata-quirks.c
>
> 576
> 577 void __init
> > 578 pdata_quirks_init_clocks(const struct of_device_id *omap_dt_match_table)
> 579 {
> 580 struct device_node *np;
> 581 int i;
> 582
> 583 for (i = 0; i < ARRAY_SIZE(pdata_quirks_init_nodes); i++) {
> 584 np = of_find_node_by_name(NULL, pdata_quirks_init_nodes[i]);
> 585 if (!np)
> 586 continue;
> 587
> 588 of_platform_populate(np, omap_dt_match_table,
> 589 omap_auxdata_lookup, NULL);
> 590 }
> 591 }
> 592
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 2194/6512] arch/arm/mach-omap2/pdata-quirks.c:578:1: warning: no previous prototype for function 'pdata_quirks_init_clocks'
Date: Wed, 24 Mar 2021 12:21:16 +0200 [thread overview]
Message-ID: <YFsSnHVIfuRoAxG0@atomide.com> (raw)
In-Reply-To: <202103240642.vvusWJ8u-lkp@intel.com>
* kernel test robot <lkp@intel.com> [210323 22:10]:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d949689e7383cd5271470f2b99dbe2fd3199bffd
> commit: a15de032a72d511431294331f4bb47245f18b801 [2194/6512] ARM: OMAP2+: Init both prm and prcm nodes early for clocks
> config: arm-randconfig-r035-20210323 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 78a65cd945d006ff02f9d24d9cc20a302ed93b08)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a15de032a72d511431294331f4bb47245f18b801
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout a15de032a72d511431294331f4bb47245f18b801
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> arch/arm/mach-omap2/pdata-quirks.c:578:1: warning: no previous prototype for function 'pdata_quirks_init_clocks' [-Wmissing-prototypes]
> pdata_quirks_init_clocks(const struct of_device_id *omap_dt_match_table)
> ^
> arch/arm/mach-omap2/pdata-quirks.c:577:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> void __init
> ^
> static
> 1 warning generated.
Thanks for the report FYI, I'm applying the following patch to fix this:
https://lore.kernel.org/linux-omap/20210318135649.1286347-1-weiyongjun1@huawei.com/T/#u
Regards,
Tony
> vim +/pdata_quirks_init_clocks +578 arch/arm/mach-omap2/pdata-quirks.c
>
> 576
> 577 void __init
> > 578 pdata_quirks_init_clocks(const struct of_device_id *omap_dt_match_table)
> 579 {
> 580 struct device_node *np;
> 581 int i;
> 582
> 583 for (i = 0; i < ARRAY_SIZE(pdata_quirks_init_nodes); i++) {
> 584 np = of_find_node_by_name(NULL, pdata_quirks_init_nodes[i]);
> 585 if (!np)
> 586 continue;
> 587
> 588 of_platform_populate(np, omap_dt_match_table,
> 589 omap_auxdata_lookup, NULL);
> 590 }
> 591 }
> 592
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-03-24 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 22:08 [linux-next:master 2194/6512] arch/arm/mach-omap2/pdata-quirks.c:578:1: warning: no previous prototype for function 'pdata_quirks_init_clocks' kernel test robot
2021-03-23 22:08 ` kernel test robot
2021-03-24 10:21 ` Tony Lindgren [this message]
2021-03-24 10:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFsSnHVIfuRoAxG0@atomide.com \
--to=tony@atomide.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.