* [PATCH] ARM: OMAP2+: add missing call to of_node_put()
@ 2021-02-25 8:54 ` Yang Li
0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-02-25 8:54 UTC (permalink / raw)
To: bcousson
Cc: paul, tony, linux, linux-omap, linux-arm-kernel, linux-kernel,
Yang Li
In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().
Fix the following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:2132:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2140.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/arm/mach-omap2/omap_hwmod.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 2310cd5..007e91e 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -2137,6 +2137,7 @@ static int of_dev_hwmod_lookup(struct device_node *np,
if (res == 0) {
*found = fc;
*index = i;
+ of_node_put(np0);
return 0;
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP2+: add missing call to of_node_put()
@ 2021-02-25 8:54 ` Yang Li
0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-02-25 8:54 UTC (permalink / raw)
To: bcousson
Cc: paul, tony, linux, linux-kernel, Yang Li, linux-omap,
linux-arm-kernel
In one of the error paths of the for_each_child_of_node() loop,
add missing call to of_node_put().
Fix the following coccicheck warning:
./arch/arm/mach-omap2/omap_hwmod.c:2132:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2140.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
arch/arm/mach-omap2/omap_hwmod.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 2310cd5..007e91e 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -2137,6 +2137,7 @@ static int of_dev_hwmod_lookup(struct device_node *np,
if (res == 0) {
*found = fc;
*index = i;
+ of_node_put(np0);
return 0;
}
}
--
1.8.3.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP2+: add missing call to of_node_put()
2021-02-25 8:54 ` Yang Li
@ 2021-03-24 11:33 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2021-03-24 11:33 UTC (permalink / raw)
To: Yang Li; +Cc: bcousson, paul, linux, linux-omap, linux-arm-kernel, linux-kernel
* Yang Li <yang.lee@linux.alibaba.com> [210225 10:55]:
> In one of the error paths of the for_each_child_of_node() loop,
> add missing call to of_node_put().
Thanks applying into omap-for-v5.13/soc.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-24 11:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-25 8:54 [PATCH] ARM: OMAP2+: add missing call to of_node_put() Yang Li
2021-02-25 8:54 ` Yang Li
2021-03-24 11:33 ` Tony Lindgren
2021-03-24 11:33 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.