From: Eric Biggers <ebiggers@kernel.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, krisman@collabora.com, drosen@google.com,
yuchao0@huawei.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, kernel@collabora.com,
andre.almeida@collabora.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v7 1/4] fs: unicode: Use strscpy() instead of strncpy()
Date: Wed, 7 Apr 2021 17:52:30 -0700 [thread overview]
Message-ID: <YG5TzqDwHXxvlvz1@gmail.com> (raw)
In-Reply-To: <20210407144845.53266-2-shreeya.patel@collabora.com>
On Wed, Apr 07, 2021 at 08:18:42PM +0530, Shreeya Patel wrote:
> The -Wstringop-truncation warning highlights the unintended
> uses of the strncpy function that truncate the terminating NULL
> character from the source string.
> Unlike strncpy(), strscpy() always null-terminates the destination string,
> hence use strscpy() instead of strncpy().
This explanation is a bit misleading. It would be clearer to phrase this in
terms of fixing how overly-long strings are handled: start returning an error
instead of creating a non-null-terminated string.
>
> Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
There should be quotes around the commit title here.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Shreeya Patel <shreeya.patel@collabora.com>
Cc: tytso@mit.edu, kernel test robot <lkp@intel.com>,
drosen@google.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com,
adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, andre.almeida@collabora.com,
linux-ext4@vger.kernel.org, krisman@collabora.com
Subject: Re: [f2fs-dev] [PATCH v7 1/4] fs: unicode: Use strscpy() instead of strncpy()
Date: Wed, 7 Apr 2021 17:52:30 -0700 [thread overview]
Message-ID: <YG5TzqDwHXxvlvz1@gmail.com> (raw)
In-Reply-To: <20210407144845.53266-2-shreeya.patel@collabora.com>
On Wed, Apr 07, 2021 at 08:18:42PM +0530, Shreeya Patel wrote:
> The -Wstringop-truncation warning highlights the unintended
> uses of the strncpy function that truncate the terminating NULL
> character from the source string.
> Unlike strncpy(), strscpy() always null-terminates the destination string,
> hence use strscpy() instead of strncpy().
This explanation is a bit misleading. It would be clearer to phrase this in
terms of fixing how overly-long strings are handled: start returning an error
instead of creating a non-null-terminated string.
>
> Fixes: 9d53690f0d4e5 (unicode: implement higher level API for string handling)
There should be quotes around the commit title here.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-04-08 0:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 14:48 [PATCH v7 0/4] Make UTF-8 encoding loadable Shreeya Patel
2021-04-07 14:48 ` [f2fs-dev] " Shreeya Patel
2021-04-07 14:48 ` [PATCH v7 1/4] fs: unicode: Use strscpy() instead of strncpy() Shreeya Patel
2021-04-07 14:48 ` [f2fs-dev] " Shreeya Patel
2021-04-08 0:52 ` Eric Biggers [this message]
2021-04-08 0:52 ` Eric Biggers
2021-04-07 14:48 ` [PATCH v7 2/4] fs: unicode: Rename function names from utf8 to unicode Shreeya Patel
2021-04-07 14:48 ` [f2fs-dev] " Shreeya Patel
2021-04-07 14:48 ` [PATCH v7 3/4] fs: unicode: Rename utf8-core file to unicode-core Shreeya Patel
2021-04-07 14:48 ` [f2fs-dev] " Shreeya Patel
2021-04-07 14:48 ` [PATCH v7 4/4] fs: unicode: Add utf8 module and a unicode layer Shreeya Patel
2021-04-07 14:48 ` [f2fs-dev] " Shreeya Patel
2021-04-08 1:01 ` Eric Biggers
2021-04-08 1:01 ` [f2fs-dev] " Eric Biggers
2021-04-08 19:10 ` Gabriel Krisman Bertazi
2021-04-08 19:10 ` [f2fs-dev] " Gabriel Krisman Bertazi
2021-04-14 11:56 ` Shreeya Patel
2021-04-14 11:56 ` [f2fs-dev] " Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG5TzqDwHXxvlvz1@gmail.com \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=andre.almeida@collabora.com \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=shreeya.patel@collabora.com \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.