Re: [linux-stable-rc:linux-4.9.y 1825/2149] drivers/spi/spi-s3c24xx-fiq.S:52: Error: bad instruction `subsne pc, lr, #4'

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

[-- Attachment #1: Type: text/plain, Size: 2623 bytes --]

On Sat, Apr 03, 2021 at 04:34:31AM -0700, Nathan Chancellor wrote:
> On Sat, Apr 03, 2021 at 01:00:00PM +0200, Arnd Bergmann wrote:
> > On Fri, Apr 2, 2021 at 5:59 AM kernel test robot <lkp@intel.com> wrote:
> > >
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
> > > head:   1872b07a2ec0357e1349cc0081b182dd0b3e9dd7
> > > commit: bc690c8239c3646434e19792851e825fafdb2782 [1825/2149] ARM: s3c: fix fiq for clang IAS
> > > config: arm-randconfig-r033-20210401 (attached as .config)
> > > compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=bc690c8239c3646434e19792851e825fafdb2782
> > >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > >         git fetch --no-tags linux-stable-rc linux-4.9.y
> > >         git checkout bc690c8239c3646434e19792851e825fafdb2782
> > >         # save the attached .config to linux build tree
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross ARCH=arm
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >    drivers/spi/spi-s3c24xx-fiq.S: Assembler messages:
> > > >> drivers/spi/spi-s3c24xx-fiq.S:52: Error: bad instruction `subsne pc,lr,#4'
> > >    drivers/spi/spi-s3c24xx-fiq.S:78: Error: bad instruction `subsne pc,lr,#4'
> > >    drivers/spi/spi-s3c24xx-fiq.S:102: Error: bad instruction `subsne pc,lr,#4'
> > 
> > Fairly sure this doesn't happen on mainline, something must have changed with
> > the compiler flags after v4.9, not sure what.
> 
> Looks like this is GCC/GNU as complaining, which leads me to believe
> it is a lack of commit 75fea300d73a ("ARM: 8723/2: always assume the
> "unified" syntax for assembly code") in 4.9.
> 
> > It's probably better not to have this one backported then. Nick/Nathan,
> > any idea what the difference might be?
> > 
> >           Arnd
> 
> If that commit cannot be taken to fix it, we should revert this backport
> in 4.9 because there is no reason for it to be there. The integrated
> assembler is only really working well on 5.4+.

I'll be glad to take it if someone backports it so that it applies :)

thanks,

greg k-h