From: Sean Christopherson <seanjc@google.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Nathan Tempelman <natet@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Danmei Wei <danmei.wei@intel.com>,
Farrah Chen <farrah.chen@intel.com>,
Robert Hu <robert.hu@intel.com>,
kvm@vger.kernel.org, kbuild-all@lists.01.org
Subject: Re: [kvm:queue 120/120] arch/x86/kvm/svm/sev.c:1380:2-8: preceding lock on line 1375 (fwd)
Date: Mon, 5 Apr 2021 15:10:36 +0000 [thread overview]
Message-ID: <YGsobMdyqwzi9vr7@google.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104041728020.2958@hadrien>
On Sun, Apr 04, 2021, Julia Lawall wrote:
> Is an unlock needed on line 1380?
Yep, I reported it as well, but only after it was queued. I'm guessing Paolo
will tweak the patch or drop it for now.
Thanks!
> f96be2deac9bca Nathan Tempelman 2021-03-16 1377 /* If this is a mirror_kvm release the enc_context_owner and skip sev cleanup */
> f96be2deac9bca Nathan Tempelman 2021-03-16 1378 if (is_mirroring_enc_context(kvm)) {
> f96be2deac9bca Nathan Tempelman 2021-03-16 1379 kvm_put_kvm(sev->enc_context_owner);
> f96be2deac9bca Nathan Tempelman 2021-03-16 @1380 return;
> f96be2deac9bca Nathan Tempelman 2021-03-16 1381 }
> f96be2deac9bca Nathan Tempelman 2021-03-16 1382
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: kbuild-all@lists.01.org
Subject: Re: [kvm:queue 120/120] arch/x86/kvm/svm/sev.c:1380:2-8: preceding lock on line 1375 (fwd)
Date: Mon, 05 Apr 2021 15:10:36 +0000 [thread overview]
Message-ID: <YGsobMdyqwzi9vr7@google.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104041728020.2958@hadrien>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Sun, Apr 04, 2021, Julia Lawall wrote:
> Is an unlock needed on line 1380?
Yep, I reported it as well, but only after it was queued. I'm guessing Paolo
will tweak the patch or drop it for now.
Thanks!
> f96be2deac9bca Nathan Tempelman 2021-03-16 1377 /* If this is a mirror_kvm release the enc_context_owner and skip sev cleanup */
> f96be2deac9bca Nathan Tempelman 2021-03-16 1378 if (is_mirroring_enc_context(kvm)) {
> f96be2deac9bca Nathan Tempelman 2021-03-16 1379 kvm_put_kvm(sev->enc_context_owner);
> f96be2deac9bca Nathan Tempelman 2021-03-16 @1380 return;
> f96be2deac9bca Nathan Tempelman 2021-03-16 1381 }
> f96be2deac9bca Nathan Tempelman 2021-03-16 1382
next prev parent reply other threads:[~2021-04-05 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-04 15:29 [kvm:queue 120/120] arch/x86/kvm/svm/sev.c:1380:2-8: preceding lock on line 1375 (fwd) Julia Lawall
2021-04-04 15:29 ` Julia Lawall
2021-04-05 15:10 ` Sean Christopherson [this message]
2021-04-05 15:10 ` Sean Christopherson
2021-04-05 15:35 ` Paolo Bonzini
2021-04-05 15:35 ` Paolo Bonzini
2021-04-06 20:24 ` Nathan Tempelman
2021-04-06 20:24 ` Nathan Tempelman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGsobMdyqwzi9vr7@google.com \
--to=seanjc@google.com \
--cc=danmei.wei@intel.com \
--cc=farrah.chen@intel.com \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=natet@google.com \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.