From: Zev Weiss <zev@bewilderbeest.net>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code
Date: Fri, 9 Apr 2021 02:38:38 -0500 [thread overview]
Message-ID: <YHAEfn4li6F8L9JC@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CAHp75Vd6kk0E-kALEGOhsg=YHKhmKLY6cpCTdviOFenO4p1-2A@mail.gmail.com>
On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote:
>On Thursday, April 8, 2021, Zev Weiss <zev@bewilderbeest.net> wrote:
>
>> This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
>> out of the sysfs store functions in preparation for adding DT
>> properties that will be poking the same registers. While we're at it,
>> these functions now provide some basic bounds-checking on their
>> arguments.
>>
>>
>
>Please, use prefix ?serial: 8250_aspeed_vuart:? instead of what you have in
>the subject line. I think I have told this already
>
>
Ah, sorry -- I fixed the cover letter after your first comment (which
had definitely been under-tagged); for the patches themselves I was
following the example of the last patch in that particular area
(8d310c9107a2), though I guess that wasn't the right model to follow.
I'll use the requested format in the future.
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zev@bewilderbeest.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Joel Stanley <joel@jms.id.au>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code
Date: Fri, 9 Apr 2021 02:38:38 -0500 [thread overview]
Message-ID: <YHAEfn4li6F8L9JC@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CAHp75Vd6kk0E-kALEGOhsg=YHKhmKLY6cpCTdviOFenO4p1-2A@mail.gmail.com>
On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote:
>On Thursday, April 8, 2021, Zev Weiss <zev@bewilderbeest.net> wrote:
>
>> This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
>> out of the sysfs store functions in preparation for adding DT
>> properties that will be poking the same registers. While we're at it,
>> these functions now provide some basic bounds-checking on their
>> arguments.
>>
>>
>
>Please, use prefix “serial: 8250_aspeed_vuart:” instead of what you have in
>the subject line. I think I have told this already
>
>
Ah, sorry -- I fixed the cover letter after your first comment (which
had definitely been under-tagged); for the patches themselves I was
following the example of the last patch in that particular area
(8d310c9107a2), though I guess that wasn't the right model to follow.
I'll use the requested format in the future.
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zev@bewilderbeest.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code
Date: Fri, 9 Apr 2021 02:38:38 -0500 [thread overview]
Message-ID: <YHAEfn4li6F8L9JC@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CAHp75Vd6kk0E-kALEGOhsg=YHKhmKLY6cpCTdviOFenO4p1-2A@mail.gmail.com>
On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote:
>On Thursday, April 8, 2021, Zev Weiss <zev@bewilderbeest.net> wrote:
>
>> This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
>> out of the sysfs store functions in preparation for adding DT
>> properties that will be poking the same registers. While we're at it,
>> these functions now provide some basic bounds-checking on their
>> arguments.
>>
>>
>
>Please, use prefix “serial: 8250_aspeed_vuart:” instead of what you have in
>the subject line. I think I have told this already
>
>
Ah, sorry -- I fixed the cover letter after your first comment (which
had definitely been under-tagged); for the patches themselves I was
following the example of the last patch in that particular area
(8d310c9107a2), though I guess that wasn't the right model to follow.
I'll use the requested format in the future.
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zev@bewilderbeest.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Joel Stanley <joel@jms.id.au>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code
Date: Fri, 9 Apr 2021 02:38:38 -0500 [thread overview]
Message-ID: <YHAEfn4li6F8L9JC@hatter.bewilderbeest.net> (raw)
In-Reply-To: <CAHp75Vd6kk0E-kALEGOhsg=YHKhmKLY6cpCTdviOFenO4p1-2A@mail.gmail.com>
On Fri, Apr 09, 2021 at 02:24:08AM CDT, Andy Shevchenko wrote:
>On Thursday, April 8, 2021, Zev Weiss <zev@bewilderbeest.net> wrote:
>
>> This splits dedicated aspeed_vuart_set_{sirq,lpc_address}() functions
>> out of the sysfs store functions in preparation for adding DT
>> properties that will be poking the same registers. While we're at it,
>> these functions now provide some basic bounds-checking on their
>> arguments.
>>
>>
>
>Please, use prefix “serial: 8250_aspeed_vuart:” instead of what you have in
>the subject line. I think I have told this already
>
>
Ah, sorry -- I fixed the cover letter after your first comment (which
had definitely been under-tagged); for the patches themselves I was
following the example of the last patch in that particular area
(8d310c9107a2), though I guess that wasn't the right model to follow.
I'll use the requested format in the future.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-09 7:38 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 1:16 [PATCH v5 0/4] serial: 8250_aspeed_vuart: generalized DT properties Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` [PATCH v5 1/4] dt-bindings: serial: 8250: deprecate aspeed, sirq-polarity-sense Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` [PATCH v5 1/4] dt-bindings: serial: 8250: deprecate aspeed,sirq-polarity-sense Zev Weiss
2021-04-08 15:59 ` [PATCH v5 1/4] dt-bindings: serial: 8250: deprecate aspeed, sirq-polarity-sense Rob Herring
2021-04-08 15:59 ` Rob Herring
2021-04-08 15:59 ` Rob Herring
2021-04-08 15:59 ` Rob Herring
2021-04-08 1:16 ` [PATCH v5 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-09 5:06 ` Andrew Jeffery
2021-04-09 5:06 ` Andrew Jeffery
2021-04-09 5:06 ` Andrew Jeffery
2021-04-09 5:06 ` Andrew Jeffery
2021-04-09 7:01 ` Zev Weiss
2021-04-09 7:01 ` Zev Weiss
2021-04-09 7:01 ` Zev Weiss
2021-04-09 7:01 ` Zev Weiss
2021-04-09 7:11 ` Andrew Jeffery
2021-04-09 7:24 ` Andy Shevchenko
2021-04-09 7:24 ` Andy Shevchenko
2021-04-09 7:38 ` Zev Weiss [this message]
2021-04-09 7:38 ` Zev Weiss
2021-04-09 7:38 ` Zev Weiss
2021-04-09 7:38 ` Zev Weiss
2021-04-09 9:51 ` Andy Shevchenko
2021-04-09 9:51 ` Andy Shevchenko
2021-04-09 9:51 ` Andy Shevchenko
2021-04-09 9:51 ` Andy Shevchenko
2021-04-08 1:16 ` [PATCH v5 3/4] drivers/tty/serial/8250: add aspeed, lpc-io-reg and aspeed, lpc-interrupts DT properties Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` [PATCH v5 3/4] drivers/tty/serial/8250: add aspeed,lpc-io-reg and aspeed,lpc-interrupts " Zev Weiss
2021-04-09 5:14 ` [PATCH v5 3/4] drivers/tty/serial/8250: add aspeed, lpc-io-reg and aspeed, lpc-interrupts " Andrew Jeffery
2021-04-09 5:14 ` Andrew Jeffery
2021-04-09 5:14 ` Andrew Jeffery
2021-04-09 5:14 ` Andrew Jeffery
2021-04-09 6:35 ` Zev Weiss
2021-04-09 6:35 ` Zev Weiss
2021-04-09 6:35 ` Zev Weiss
2021-04-09 6:35 ` Zev Weiss
2021-04-08 1:16 ` [PATCH v5 4/4] dt-bindings: serial: 8250: add aspeed, lpc-io-reg and aspeed, lpc-interrupts Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` Zev Weiss
2021-04-08 1:16 ` [PATCH v5 4/4] dt-bindings: serial: 8250: add aspeed,lpc-io-reg and aspeed,lpc-interrupts Zev Weiss
2021-04-08 16:00 ` [PATCH v5 4/4] dt-bindings: serial: 8250: add aspeed, lpc-io-reg and aspeed, lpc-interrupts Rob Herring
2021-04-08 16:00 ` Rob Herring
2021-04-08 16:00 ` Rob Herring
2021-04-08 16:00 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHAEfn4li6F8L9JC@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.