* [PATCH -next] sched/topology: Make some symbols static
@ 2021-04-08 13:12 Peng Wu
2021-04-13 9:24 ` Quentin Perret
0 siblings, 1 reply; 3+ messages in thread
From: Peng Wu @ 2021-04-08 13:12 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot
Cc: linux-kernel, kernel-janitors, Peng Wu
The sparse tool complains as follows:
kernel/sched/topology.c:211:1: warning:
symbol 'sched_energy_mutex' was not declared. Should it be static?
kernel/sched/topology.c:212:6: warning:
symbol 'sched_energy_update' was not declared. Should it be static?
This symbol is not used outside of topology.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Peng Wu <wupeng58@huawei.com>
---
kernel/sched/topology.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index d1aec244c027..25c3f88d43cd 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
DEFINE_STATIC_KEY_FALSE(sched_energy_present);
unsigned int sysctl_sched_energy_aware = 1;
-DEFINE_MUTEX(sched_energy_mutex);
-bool sched_energy_update;
+static DEFINE_MUTEX(sched_energy_mutex);
+static bool sched_energy_update;
void rebuild_sched_domains_energy(void)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] sched/topology: Make some symbols static
2021-04-08 13:12 [PATCH -next] sched/topology: Make some symbols static Peng Wu
@ 2021-04-13 9:24 ` Quentin Perret
0 siblings, 0 replies; 3+ messages in thread
From: Quentin Perret @ 2021-04-13 9:24 UTC (permalink / raw)
To: Peng Wu
Cc: mingo, peterz, juri.lelli, vincent.guittot, linux-kernel,
kernel-janitors
On Thursday 08 Apr 2021 at 21:12:17 (+0800), Peng Wu wrote:
> The sparse tool complains as follows:
>
> kernel/sched/topology.c:211:1: warning:
> symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning:
> symbol 'sched_energy_update' was not declared. Should it be static?
>
> This symbol is not used outside of topology.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
> ---
> kernel/sched/topology.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index d1aec244c027..25c3f88d43cd 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
> #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
> DEFINE_STATIC_KEY_FALSE(sched_energy_present);
> unsigned int sysctl_sched_energy_aware = 1;
> -DEFINE_MUTEX(sched_energy_mutex);
> -bool sched_energy_update;
> +static DEFINE_MUTEX(sched_energy_mutex);
> +static bool sched_energy_update;
>
> void rebuild_sched_domains_energy(void)
> {
>
FWIW, that has been reported some time ago:
https://lore.kernel.org/lkml/1606218731-3999-1-git-send-email-zou_wei@huawei.com/
https://lore.kernel.org/lkml/1606271447-74720-1-git-send-email-zou_wei@huawei.com/
But otherwise, this looks OK to me.
Thanks,
Quentin
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] sched/topology: Make some symbols static
@ 2021-04-08 9:31 Peng Wu
0 siblings, 0 replies; 3+ messages in thread
From: Peng Wu @ 2021-04-08 9:31 UTC (permalink / raw)
To: wupeng58, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot
Cc: linux-kernel, kernel-janitors
The sparse tool complains as follows:
kernel/sched/topology.c:211:1: warning:
symbol 'sched_energy_mutex' was not declared. Should it be static?
kernel/sched/topology.c:212:6: warning:
symbol 'sched_energy_update' was not declared. Should it be static?
This symbol is not used outside of topology.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Peng Wu <wupeng58@huawei.com>
---
kernel/sched/topology.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index d1aec244c027..25c3f88d43cd 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
DEFINE_STATIC_KEY_FALSE(sched_energy_present);
unsigned int sysctl_sched_energy_aware = 1;
-DEFINE_MUTEX(sched_energy_mutex);
-bool sched_energy_update;
+static DEFINE_MUTEX(sched_energy_mutex);
+static bool sched_energy_update;
void rebuild_sched_domains_energy(void)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-13 9:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-08 13:12 [PATCH -next] sched/topology: Make some symbols static Peng Wu
2021-04-13 9:24 ` Quentin Perret
-- strict thread matches above, loose matches on Subject: below --
2021-04-08 9:31 Peng Wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.