From: Eric Biggers <ebiggers@kernel.org>
To: Nick Terrell <nickrterrell@gmail.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
squashfs-devel@lists.sourceforge.net,
"Johannes Weiner" <jweiner@fb.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Yann Collet" <cyan@fb.com>, "David Sterba" <dsterba@suse.cz>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
"Petr Malat" <oss@malat.biz>, "Chris Mason" <clm@fb.com>,
"Nick Terrell" <terrelln@fb.com>,
linux-crypto@vger.kernel.org,
"Oleksandr Natalenko" <oleksandr@natalenko.name>,
"Kernel Team" <Kernel-team@fb.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Niket Agarwal" <niketa@fb.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10
Date: Wed, 14 Apr 2021 12:04:38 -0700 [thread overview]
Message-ID: <YHc8xtmzKaazC6kP@gmail.com> (raw)
In-Reply-To: <CANr2Dbc+2rS7seuXGtU6Y+x0Qv+hrtwz71r+akKeQUXECZaJZA@mail.gmail.com>
On Wed, Apr 14, 2021 at 11:53:51AM -0700, Nick Terrell wrote:
> On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote:
> > > Hi all,
> > >
> > > I would really like to make some progress on this and get it merged.
> > > This patchset offsers:
> > > * 15-30% better decompression speed
> > > * 3 years of zstd bug fixes and code improvements
> > > * Allows us to import zstd directly from upstream so we don't fall 3
> > > years out of date again
> > >
> > > Thanks,
> > > Nick
> > >
> >
> > I think it would help get it merged if someone actually volunteered to maintain
> > it. As-is there is no entry in MAINTAINERS for this code.
>
> I was discussing with Chris Mason about volunteering to maintain the
> code myself.
> We wanted to wait until this series got merged before going that
> route, because there
> was already a lot of comments about it, and I didn't want to appear to
> be trying to bypass
> any review or criticisms. But, please let me know what you think.
>
I expect that most people would like to see a commitment to maintain this code
before merging. The usual way to do that is to add a MAINTAINERS entry.
Otherwise it is 27000 lines of code dumped on other people to maintain.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Nick Terrell <nickrterrell@gmail.com>
Cc: squashfs-devel@lists.sourceforge.net,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Yann Collet" <cyan@fb.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Petr Malat" <oss@malat.biz>, "David Sterba" <dsterba@suse.cz>,
linux-kernel@vger.kernel.org,
"Christoph Hellwig" <hch@infradead.org>,
"Chris Mason" <clm@fb.com>, "Nick Terrell" <terrelln@fb.com>,
linux-crypto@vger.kernel.org,
"Oleksandr Natalenko" <oleksandr@natalenko.name>,
"Kernel Team" <Kernel-team@fb.com>,
linux-f2fs-devel@lists.sourceforge.net,
"Niket Agarwal" <niketa@fb.com>,
linux-btrfs@vger.kernel.org, "Johannes Weiner" <jweiner@fb.com>
Subject: Re: [f2fs-dev] [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10
Date: Wed, 14 Apr 2021 12:04:38 -0700 [thread overview]
Message-ID: <YHc8xtmzKaazC6kP@gmail.com> (raw)
In-Reply-To: <CANr2Dbc+2rS7seuXGtU6Y+x0Qv+hrtwz71r+akKeQUXECZaJZA@mail.gmail.com>
On Wed, Apr 14, 2021 at 11:53:51AM -0700, Nick Terrell wrote:
> On Wed, Apr 14, 2021 at 11:35 AM Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > On Wed, Apr 14, 2021 at 11:01:29AM -0700, Nick Terrell wrote:
> > > Hi all,
> > >
> > > I would really like to make some progress on this and get it merged.
> > > This patchset offsers:
> > > * 15-30% better decompression speed
> > > * 3 years of zstd bug fixes and code improvements
> > > * Allows us to import zstd directly from upstream so we don't fall 3
> > > years out of date again
> > >
> > > Thanks,
> > > Nick
> > >
> >
> > I think it would help get it merged if someone actually volunteered to maintain
> > it. As-is there is no entry in MAINTAINERS for this code.
>
> I was discussing with Chris Mason about volunteering to maintain the
> code myself.
> We wanted to wait until this series got merged before going that
> route, because there
> was already a lot of comments about it, and I didn't want to appear to
> be trying to bypass
> any review or criticisms. But, please let me know what you think.
>
I expect that most people would like to see a commitment to maintain this code
before merging. The usual way to do that is to add a MAINTAINERS entry.
Otherwise it is 27000 lines of code dumped on other people to maintain.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-04-14 19:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 22:51 [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10 Nick Terrell
2021-03-30 22:51 ` [f2fs-dev] " Nick Terrell
2021-03-30 22:51 ` [PATCH v9 1/3] lib: zstd: Add kernel-specific API Nick Terrell
2021-03-30 22:51 ` [f2fs-dev] " Nick Terrell
2021-03-30 22:51 ` [PATCH v9 2/3] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2021-03-30 22:51 ` [f2fs-dev] " Nick Terrell
2021-03-30 22:51 ` [f2fs-dev] [PATCH v9 3/3] lib: zstd: Upgrade to latest upstream zstd version 1.4.10 Nick Terrell
2021-03-30 22:51 ` Nick Terrell
2021-03-31 13:30 ` [GIT PULL][PATCH v9 0/3] Update to zstd-1.4.10 Oleksandr Natalenko
2021-03-31 13:30 ` [f2fs-dev] " Oleksandr Natalenko via Linux-f2fs-devel
2021-04-09 21:39 ` Nick Terrell
2021-04-09 21:39 ` [f2fs-dev] " Nick Terrell
2021-04-14 18:01 ` Nick Terrell
2021-04-14 18:01 ` [f2fs-dev] " Nick Terrell
2021-04-14 18:35 ` Eric Biggers
2021-04-14 18:35 ` [f2fs-dev] " Eric Biggers
2021-04-14 18:53 ` Nick Terrell
2021-04-14 18:53 ` [f2fs-dev] " Nick Terrell
2021-04-14 19:04 ` Eric Biggers [this message]
2021-04-14 19:04 ` Eric Biggers
2021-04-14 20:18 ` Nick Terrell
2021-04-14 20:18 ` [f2fs-dev] " Nick Terrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHc8xtmzKaazC6kP@gmail.com \
--to=ebiggers@kernel.org \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=cyan@fb.com \
--cc=dsterba@suse.cz \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=jweiner@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nickrterrell@gmail.com \
--cc=niketa@fb.com \
--cc=oleksandr@natalenko.name \
--cc=oss@malat.biz \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.