From: Daniel Vetter <daniel@ffwll.ch>
To: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
melissa.srw@gmail.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 3/3] drm: drm_connector.c: Use tabs for code indents
Date: Thu, 22 Apr 2021 10:47:25 +0200 [thread overview]
Message-ID: <YIE4HTjVGbBPaRQG@phenom.ffwll.local> (raw)
In-Reply-To: <0200474fbdb1149856308bccb8e467415f0b3d99.1618828127.git.martinsdecarvalhobeatriz@gmail.com>
On Wed, Apr 21, 2021 at 08:42:49PM +0100, Beatriz Martins de Carvalho wrote:
> Remove space and use tabs for indent the code to follow the
> Linux kernel coding conventions.
> Problem found by checkpatch
>
> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Both of your patch sets applied to drm-misc-next for 5.14, thanks a lot.
-Daniel
> ---
> drivers/gpu/drm/drm_connector.c | 38 ++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 7631f76e7f34..38600c3a6ab2 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -1958,11 +1958,11 @@ int drm_connector_set_path_property(struct drm_connector *connector,
> int ret;
>
> ret = drm_property_replace_global_blob(dev,
> - &connector->path_blob_ptr,
> - strlen(path) + 1,
> - path,
> - &connector->base,
> - dev->mode_config.path_property);
> + &connector->path_blob_ptr,
> + strlen(path) + 1,
> + path,
> + &connector->base,
> + dev->mode_config.path_property);
> return ret;
> }
> EXPORT_SYMBOL(drm_connector_set_path_property);
> @@ -1988,11 +1988,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector)
>
> if (!connector->has_tile) {
> ret = drm_property_replace_global_blob(dev,
> - &connector->tile_blob_ptr,
> - 0,
> - NULL,
> - &connector->base,
> - dev->mode_config.tile_property);
> + &connector->tile_blob_ptr,
> + 0,
> + NULL,
> + &connector->base,
> + dev->mode_config.tile_property);
> return ret;
> }
>
> @@ -2003,11 +2003,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector)
> connector->tile_h_size, connector->tile_v_size);
>
> ret = drm_property_replace_global_blob(dev,
> - &connector->tile_blob_ptr,
> - strlen(tile) + 1,
> - tile,
> - &connector->base,
> - dev->mode_config.tile_property);
> + &connector->tile_blob_ptr,
> + strlen(tile) + 1,
> + tile,
> + &connector->base,
> + dev->mode_config.tile_property);
> return ret;
> }
> EXPORT_SYMBOL(drm_connector_set_tile_property);
> @@ -2076,10 +2076,10 @@ int drm_connector_update_edid_property(struct drm_connector *connector,
>
> ret = drm_property_replace_global_blob(dev,
> &connector->edid_blob_ptr,
> - size,
> - edid,
> - &connector->base,
> - dev->mode_config.edid_property);
> + size,
> + edid,
> + &connector->base,
> + dev->mode_config.edid_property);
> if (ret)
> return ret;
> return drm_connector_set_tile_property(connector);
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Cc: tzimmermann@suse.de, airlied@linux.ie,
linux-kernel@vger.kernel.org, melissa.srw@gmail.com,
outreachy-kernel@googlegroups.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm: drm_connector.c: Use tabs for code indents
Date: Thu, 22 Apr 2021 10:47:25 +0200 [thread overview]
Message-ID: <YIE4HTjVGbBPaRQG@phenom.ffwll.local> (raw)
In-Reply-To: <0200474fbdb1149856308bccb8e467415f0b3d99.1618828127.git.martinsdecarvalhobeatriz@gmail.com>
On Wed, Apr 21, 2021 at 08:42:49PM +0100, Beatriz Martins de Carvalho wrote:
> Remove space and use tabs for indent the code to follow the
> Linux kernel coding conventions.
> Problem found by checkpatch
>
> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
Both of your patch sets applied to drm-misc-next for 5.14, thanks a lot.
-Daniel
> ---
> drivers/gpu/drm/drm_connector.c | 38 ++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 7631f76e7f34..38600c3a6ab2 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -1958,11 +1958,11 @@ int drm_connector_set_path_property(struct drm_connector *connector,
> int ret;
>
> ret = drm_property_replace_global_blob(dev,
> - &connector->path_blob_ptr,
> - strlen(path) + 1,
> - path,
> - &connector->base,
> - dev->mode_config.path_property);
> + &connector->path_blob_ptr,
> + strlen(path) + 1,
> + path,
> + &connector->base,
> + dev->mode_config.path_property);
> return ret;
> }
> EXPORT_SYMBOL(drm_connector_set_path_property);
> @@ -1988,11 +1988,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector)
>
> if (!connector->has_tile) {
> ret = drm_property_replace_global_blob(dev,
> - &connector->tile_blob_ptr,
> - 0,
> - NULL,
> - &connector->base,
> - dev->mode_config.tile_property);
> + &connector->tile_blob_ptr,
> + 0,
> + NULL,
> + &connector->base,
> + dev->mode_config.tile_property);
> return ret;
> }
>
> @@ -2003,11 +2003,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector)
> connector->tile_h_size, connector->tile_v_size);
>
> ret = drm_property_replace_global_blob(dev,
> - &connector->tile_blob_ptr,
> - strlen(tile) + 1,
> - tile,
> - &connector->base,
> - dev->mode_config.tile_property);
> + &connector->tile_blob_ptr,
> + strlen(tile) + 1,
> + tile,
> + &connector->base,
> + dev->mode_config.tile_property);
> return ret;
> }
> EXPORT_SYMBOL(drm_connector_set_tile_property);
> @@ -2076,10 +2076,10 @@ int drm_connector_update_edid_property(struct drm_connector *connector,
>
> ret = drm_property_replace_global_blob(dev,
> &connector->edid_blob_ptr,
> - size,
> - edid,
> - &connector->base,
> - dev->mode_config.edid_property);
> + size,
> + edid,
> + &connector->base,
> + dev->mode_config.edid_property);
> if (ret)
> return ret;
> return drm_connector_set_tile_property(connector);
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-22 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 10:44 [PATCH 0/3] drm: Use tabs for code indents Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-19 10:44 ` [PATCH 1/3] drm: drm_atomic_uapi.c: " Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-19 10:44 ` [PATCH 2/3] drm: drm_blend.c: " Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-19 10:44 ` [PATCH 3/3] drm: drm_connector.c: " Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-21 19:42 ` Beatriz Martins de Carvalho
2021-04-22 8:47 ` Daniel Vetter [this message]
2021-04-22 8:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIE4HTjVGbBPaRQG@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martinsdecarvalhobeatriz@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.