From: Johan Hovold <johan@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: kernel test robot <lkp@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kbuild-all@lists.01.org,
clang-built-linux <clang-built-linux@googlegroups.com>,
Jiri Slaby <jirislaby@kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: extend compile-test coverage
Date: Thu, 22 Apr 2021 09:37:19 +0200 [thread overview]
Message-ID: <YIEnr9g8AmYFuLPh@hovoldconsulting.com> (raw)
In-Reply-To: <CAMuHMdXKWDB89Hm-LQcpfTq=0yjm_xvQsQiD4QuEtW=yVymuRw@mail.gmail.com>
On Thu, Apr 22, 2021 at 09:11:50AM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 22, 2021 at 3:20 AM kernel test robot <lkp@intel.com> wrote:
> > >> drivers/tty/serial/serial_txx9.c:987:12: warning: no previous prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
> > int __init early_serial_txx9_setup(struct uart_port *port)
> > ^
> > drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > int __init early_serial_txx9_setup(struct uart_port *port)
> > ^
> > static
> > 1 warning generated.
>
> This function is called from arch/mips/txx9/generic/setup.c, and does
> have a forward declaration in arch/mips/include/asm/txx9/generic.h.
> Unfortunately the latter cannot be included from the driver, unless
> the || COMPILE_TEST is dropped again.
Thanks, Geert. I was just about to send a v2 without the txx9 hunk.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] serial: extend compile-test coverage
Date: Thu, 22 Apr 2021 09:37:19 +0200 [thread overview]
Message-ID: <YIEnr9g8AmYFuLPh@hovoldconsulting.com> (raw)
In-Reply-To: <CAMuHMdXKWDB89Hm-LQcpfTq=0yjm_xvQsQiD4QuEtW=yVymuRw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Thu, Apr 22, 2021 at 09:11:50AM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 22, 2021 at 3:20 AM kernel test robot <lkp@intel.com> wrote:
> > >> drivers/tty/serial/serial_txx9.c:987:12: warning: no previous prototype for function 'early_serial_txx9_setup' [-Wmissing-prototypes]
> > int __init early_serial_txx9_setup(struct uart_port *port)
> > ^
> > drivers/tty/serial/serial_txx9.c:987:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > int __init early_serial_txx9_setup(struct uart_port *port)
> > ^
> > static
> > 1 warning generated.
>
> This function is called from arch/mips/txx9/generic/setup.c, and does
> have a forward declaration in arch/mips/include/asm/txx9/generic.h.
> Unfortunately the latter cannot be included from the driver, unless
> the || COMPILE_TEST is dropped again.
Thanks, Geert. I was just about to send a v2 without the txx9 hunk.
Johan
next prev parent reply other threads:[~2021-04-22 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 14:31 [PATCH] serial: extend compile-test coverage Johan Hovold
2021-04-21 19:35 ` kernel test robot
2021-04-21 19:35 ` kernel test robot
2021-04-22 7:11 ` Geert Uytterhoeven
2021-04-22 7:11 ` Geert Uytterhoeven
2021-04-22 7:37 ` Johan Hovold [this message]
2021-04-22 7:37 ` Johan Hovold
2021-04-22 7:40 ` Geert Uytterhoeven
2021-04-22 7:40 ` Geert Uytterhoeven
2021-04-22 7:52 ` Johan Hovold
2021-04-22 7:52 ` Johan Hovold
2021-04-22 7:54 ` Geert Uytterhoeven
2021-04-22 7:54 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIEnr9g8AmYFuLPh@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.