All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, david@redhat.com, akpm@linux-foundation.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes
Date: Thu, 22 Apr 2021 15:19:53 +0300	[thread overview]
Message-ID: <YIFp6W/wgcZSxe1k@kernel.org> (raw)
In-Reply-To: <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com>

On Thu, Apr 22, 2021 at 04:53:36PM +0530, Anshuman Khandual wrote:
> On 4/22/21 1:57 PM, Mike Rapoport wrote:

...

> >> diff --git a/mm/memblock.c b/mm/memblock.c
> >> index 3abf2c3fea7f..93f8a9c8428d 100644
> >> --- a/mm/memblock.c
> >> +++ b/mm/memblock.c
> >> @@ -1740,6 +1740,7 @@ bool __init_memblock memblock_is_memory(phys_addr_t addr)
> >>  {
> >>  	return memblock_search(&memblock.memory, addr) != -1;
> >>  }
> >> +EXPORT_SYMBOL(memblock_is_memory);
> > 
> > Please make it inside #ifdef CONFIG_ARCH_MEMBLOCK
> CONFIG_ARCH_KEEP_MEMBLOCK ?

Yeah, _KEEP went away somehow :)

> Wrap it around the EXPORT_SYMBOL() or the entire function
> memblock_is_memory().

EXPORT_SYMBOL(). Otherwise we'll have exported __init function.
 
-- 
Sincerely yours,
Mike.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, david@redhat.com, akpm@linux-foundation.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes
Date: Thu, 22 Apr 2021 15:19:53 +0300	[thread overview]
Message-ID: <YIFp6W/wgcZSxe1k@kernel.org> (raw)
In-Reply-To: <6096b004-aaeb-d814-87e4-92ec1b180f1d@arm.com>

On Thu, Apr 22, 2021 at 04:53:36PM +0530, Anshuman Khandual wrote:
> On 4/22/21 1:57 PM, Mike Rapoport wrote:

...

> >> diff --git a/mm/memblock.c b/mm/memblock.c
> >> index 3abf2c3fea7f..93f8a9c8428d 100644
> >> --- a/mm/memblock.c
> >> +++ b/mm/memblock.c
> >> @@ -1740,6 +1740,7 @@ bool __init_memblock memblock_is_memory(phys_addr_t addr)
> >>  {
> >>  	return memblock_search(&memblock.memory, addr) != -1;
> >>  }
> >> +EXPORT_SYMBOL(memblock_is_memory);
> > 
> > Please make it inside #ifdef CONFIG_ARCH_MEMBLOCK
> CONFIG_ARCH_KEEP_MEMBLOCK ?

Yeah, _KEEP went away somehow :)

> Wrap it around the EXPORT_SYMBOL() or the entire function
> memblock_is_memory().

EXPORT_SYMBOL(). Otherwise we'll have exported __init function.
 
-- 
Sincerely yours,
Mike.


  reply	other threads:[~2021-04-22 12:22 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  6:18 [PATCH v3 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Mike Rapoport
2021-04-22  6:18 ` Mike Rapoport
2021-04-22  6:18 ` Mike Rapoport
2021-04-22  6:18 ` [PATCH v3 1/4] include/linux/mmzone.h: add documentation for pfn_valid() Mike Rapoport
2021-04-22  6:18   ` Mike Rapoport
2021-04-22  6:18   ` Mike Rapoport
2021-04-22  6:19 ` [PATCH v3 2/4] memblock: update initialization of reserved pages Mike Rapoport
2021-04-22  6:19   ` Mike Rapoport
2021-04-22  6:19   ` Mike Rapoport
2021-04-22  6:19 ` [PATCH v3 3/4] arm64: decouple check whether pfn is in linear map from pfn_valid() Mike Rapoport
2021-04-22  6:19   ` Mike Rapoport
2021-04-22  6:19   ` Mike Rapoport
2021-04-22  8:57   ` David Hildenbrand
2021-04-22  8:57     ` David Hildenbrand
2021-04-22  8:57     ` David Hildenbrand
2021-04-22  6:19 ` [PATCH v3 4/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Mike Rapoport
2021-04-22  6:19   ` Mike Rapoport
2021-04-22  6:19   ` Mike Rapoport
2021-04-22  7:50 ` [RFC V2] mm: Enable generic pfn_valid() to handle early sections with memmap holes Anshuman Khandual
2021-04-22  7:50   ` Anshuman Khandual
2021-04-22  8:27   ` Mike Rapoport
2021-04-22  8:27     ` Mike Rapoport
2021-04-22 11:23     ` Anshuman Khandual
2021-04-22 11:23       ` Anshuman Khandual
2021-04-22 12:19       ` Mike Rapoport [this message]
2021-04-22 12:19         ` Mike Rapoport
2021-04-22  9:03   ` David Hildenbrand
2021-04-22  9:03     ` David Hildenbrand
2021-04-22  9:42     ` Mike Rapoport
2021-04-22  9:42       ` Mike Rapoport
2021-04-22  9:48       ` David Hildenbrand
2021-04-22  9:48         ` David Hildenbrand
2021-04-22 10:03         ` Mike Rapoport
2021-04-22 10:03           ` Mike Rapoport
2021-04-22  9:59       ` Anshuman Khandual
2021-04-22  9:59         ` Anshuman Khandual
2021-05-24  4:58   ` Anshuman Khandual
2021-05-24  4:58     ` Anshuman Khandual
2021-05-24  6:52     ` Mike Rapoport
2021-05-24  6:52       ` Mike Rapoport
2021-05-25  6:00       ` Anshuman Khandual
2021-05-25  6:00         ` Anshuman Khandual
2021-05-25  6:32         ` Mike Rapoport
2021-05-25  6:32           ` Mike Rapoport
2021-05-25  9:52           ` Anshuman Khandual
2021-05-25  9:52             ` Anshuman Khandual
2021-05-25 10:03             ` Mike Rapoport
2021-05-25 10:03               ` Mike Rapoport
2021-05-25 10:04               ` David Hildenbrand
2021-05-25 10:04                 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIFp6W/wgcZSxe1k@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.