From: Andrew Lunn <andrew@lunn.ch>
To: DENG Qingfang <dqfext@gmail.com>
Cc: David Miller <davem@davemloft.net>,
f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org,
Landen.Chao@mediatek.com, matthias.bgg@gmail.com,
linux@armlinux.org.uk, sean.wang@mediatek.com,
vivien.didelot@gmail.com, olteanv@gmail.com, robh+dt@kernel.org,
linus.walleij@linaro.org, gregkh@linuxfoundation.org,
sergio.paracuellos@gmail.com, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-staging@lists.linux.dev, devicetree@vger.kernel.org,
netdev@vger.kernel.org, weijie.gao@mediatek.com,
gch981213@gmail.com, opensource@vdorst.com,
frank-w@public-files.de, tglx@linutronix.de, maz@kernel.org
Subject: Re: [PATCH net-next 0/4] MT7530 interrupt support
Date: Fri, 30 Apr 2021 14:24:16 +0200 [thread overview]
Message-ID: <YIv28APpOP9tnuO+@lunn.ch> (raw)
In-Reply-To: <20210430023839.246447-1-dqfext@gmail.com>
On Fri, Apr 30, 2021 at 10:38:39AM +0800, DENG Qingfang wrote:
> On Thu, Apr 29, 2021 at 05:08:15PM -0700, David Miller wrote:
> >
> > Please fix this:
> >
> > error: the following would cause module name conflict:
> > drivers/net/phy/mediatek.ko
> > drivers/usb/musb/mediatek.ko
>
> So I still have to rename the PHY driver..
> Andrew, what is your suggestion? Is mediatek_phy.c okay?
mediatek_phy.c gets you into trouble with the generic PHY drivers.
Most Ethernet PHY drivers have the model number in the file name. Does
the PHY have its own name/numbering, or is it always considered part
of the switch? If the PHY has an identity of its own, use
that. Otherwise maybe mediatek75xx.c?
Andrew
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: DENG Qingfang <dqfext@gmail.com>
Cc: David Miller <davem@davemloft.net>,
f.fainelli@gmail.com, hkallweit1@gmail.com, kuba@kernel.org,
Landen.Chao@mediatek.com, matthias.bgg@gmail.com,
linux@armlinux.org.uk, sean.wang@mediatek.com,
vivien.didelot@gmail.com, olteanv@gmail.com, robh+dt@kernel.org,
linus.walleij@linaro.org, gregkh@linuxfoundation.org,
sergio.paracuellos@gmail.com, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-staging@lists.linux.dev, devicetree@vger.kernel.org,
netdev@vger.kernel.org, weijie.gao@mediatek.com,
gch981213@gmail.com, opensource@vdorst.com,
frank-w@public-files.de, tglx@linutronix.de, maz@kernel.org
Subject: Re: [PATCH net-next 0/4] MT7530 interrupt support
Date: Fri, 30 Apr 2021 14:24:16 +0200 [thread overview]
Message-ID: <YIv28APpOP9tnuO+@lunn.ch> (raw)
In-Reply-To: <20210430023839.246447-1-dqfext@gmail.com>
On Fri, Apr 30, 2021 at 10:38:39AM +0800, DENG Qingfang wrote:
> On Thu, Apr 29, 2021 at 05:08:15PM -0700, David Miller wrote:
> >
> > Please fix this:
> >
> > error: the following would cause module name conflict:
> > drivers/net/phy/mediatek.ko
> > drivers/usb/musb/mediatek.ko
>
> So I still have to rename the PHY driver..
> Andrew, what is your suggestion? Is mediatek_phy.c okay?
mediatek_phy.c gets you into trouble with the generic PHY drivers.
Most Ethernet PHY drivers have the model number in the file name. Does
the PHY have its own name/numbering, or is it always considered part
of the switch? If the PHY has an identity of its own, use
that. Otherwise maybe mediatek75xx.c?
Andrew
next prev parent reply other threads:[~2021-04-30 12:24 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 6:21 [PATCH net-next 0/4] MT7530 interrupt support DENG Qingfang
2021-04-29 6:21 ` DENG Qingfang
2021-04-29 6:21 ` [PATCH net-next 1/4] net: phy: add MediaTek PHY driver DENG Qingfang
2021-04-29 6:21 ` DENG Qingfang
2021-04-29 21:26 ` Andrew Lunn
2021-04-29 21:26 ` Andrew Lunn
2021-04-29 23:40 ` Florian Fainelli
2021-04-29 23:40 ` Florian Fainelli
2021-05-06 11:33 ` Vladimir Oltean
2021-05-06 11:33 ` Vladimir Oltean
2021-04-29 6:21 ` [PATCH net-next 2/4] net: dsa: mt7530: add interrupt support DENG Qingfang
2021-04-29 6:21 ` DENG Qingfang
2021-04-29 21:29 ` Andrew Lunn
2021-04-29 21:29 ` Andrew Lunn
2021-04-29 23:39 ` Florian Fainelli
2021-04-29 23:39 ` Florian Fainelli
2021-05-06 11:42 ` Vladimir Oltean
2021-05-06 11:42 ` Vladimir Oltean
2021-04-29 6:21 ` [PATCH net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding DENG Qingfang
2021-04-29 6:21 ` DENG Qingfang
2021-04-29 21:30 ` Andrew Lunn
2021-04-29 21:30 ` Andrew Lunn
2021-04-29 23:31 ` Florian Fainelli
2021-04-29 23:31 ` Florian Fainelli
2021-05-03 19:35 ` Rob Herring
2021-05-03 19:35 ` Rob Herring
2021-04-29 6:21 ` [PATCH net-next 4/4] staging: mt7621-dts: enable MT7530 interrupt controller DENG Qingfang
2021-04-29 6:21 ` DENG Qingfang
2021-04-29 21:30 ` Andrew Lunn
2021-04-29 21:30 ` Andrew Lunn
2021-04-29 23:31 ` Florian Fainelli
2021-04-29 23:31 ` Florian Fainelli
2021-05-06 11:48 ` Vladimir Oltean
2021-05-06 11:48 ` Vladimir Oltean
2021-04-30 0:08 ` [PATCH net-next 0/4] MT7530 interrupt support David Miller
2021-04-30 0:08 ` David Miller
2021-04-30 2:38 ` DENG Qingfang
2021-04-30 2:38 ` DENG Qingfang
2021-04-30 12:24 ` Andrew Lunn [this message]
2021-04-30 12:24 ` Andrew Lunn
2021-04-30 12:37 ` Aw: " Frank Wunderlich
2021-04-30 12:37 ` Frank Wunderlich
2021-04-30 12:44 ` Andrew Lunn
2021-04-30 12:44 ` Andrew Lunn
2021-04-30 12:56 ` Aw: " Frank Wunderlich
2021-04-30 12:56 ` Frank Wunderlich
2021-04-30 13:13 ` Andrew Lunn
2021-04-30 13:13 ` Andrew Lunn
2021-04-30 14:59 ` Aw: " Frank Wunderlich
2021-04-30 14:59 ` Frank Wunderlich
2021-04-30 16:34 ` Andrew Lunn
2021-04-30 16:34 ` Andrew Lunn
2021-05-05 9:31 ` Landen Chao
2021-05-05 9:31 ` Landen Chao
2021-05-05 9:43 ` DENG Qingfang
2021-05-05 9:43 ` DENG Qingfang
2021-05-06 12:54 ` Landen Chao
2021-05-06 12:54 ` Landen Chao
2021-05-07 7:55 ` DENG Qingfang
2021-05-07 7:55 ` DENG Qingfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIv28APpOP9tnuO+@lunn.ch \
--to=andrew@lunn.ch \
--cc=Landen.Chao@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=gch981213@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=tglx@linutronix.de \
--cc=vivien.didelot@gmail.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.