All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH 2/4] Add missing check
Date: Tue, 4 May 2021 12:41:48 +0300	[thread overview]
Message-ID: <YJEW3J0+RQPo22AD@intel.com> (raw)
In-Reply-To: <20210503182148.851790-3-wse@tuxedocomputers.com>

On Mon, May 03, 2021 at 08:21:46PM +0200, Werner Sembach wrote:
> Add a missing check that could potentially lead to an unarchivable mode being
> validated.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> 
> >From 54fa706f0a5f260a32af5d18b9622ceebb94c12e Mon Sep 17 00:00:00 2001
> From: Werner Sembach <wse@tuxedocomputers.com>
> Date: Mon, 3 May 2021 14:42:36 +0200
> Subject: [PATCH 2/4] Add missing check

I guess you did something a bit wonky with git format-patch/send-mail?

> 
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 576d3d910d06..ce165ef28e88 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1913,7 +1913,7 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
>  		clock *= 2;
>  	}
>  
> -	if (drm_mode_is_420_only(&connector->display_info, mode))
> +	if (connector->ycbcr_420_allowed && drm_mode_is_420_only(&connector->display_info, mode))

This one shouldn't be necessary. drm_mode_validate_ycbcr420() has
already checked it for us.

>  		clock /= 2;
>  
>  	status = intel_hdmi_mode_clock_valid(hdmi, clock, has_hdmi_sink);
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: airlied@linux.ie, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Add missing check
Date: Tue, 4 May 2021 12:41:48 +0300	[thread overview]
Message-ID: <YJEW3J0+RQPo22AD@intel.com> (raw)
In-Reply-To: <20210503182148.851790-3-wse@tuxedocomputers.com>

On Mon, May 03, 2021 at 08:21:46PM +0200, Werner Sembach wrote:
> Add a missing check that could potentially lead to an unarchivable mode being
> validated.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> 
> >From 54fa706f0a5f260a32af5d18b9622ceebb94c12e Mon Sep 17 00:00:00 2001
> From: Werner Sembach <wse@tuxedocomputers.com>
> Date: Mon, 3 May 2021 14:42:36 +0200
> Subject: [PATCH 2/4] Add missing check

I guess you did something a bit wonky with git format-patch/send-mail?

> 
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 576d3d910d06..ce165ef28e88 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1913,7 +1913,7 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
>  		clock *= 2;
>  	}
>  
> -	if (drm_mode_is_420_only(&connector->display_info, mode))
> +	if (connector->ycbcr_420_allowed && drm_mode_is_420_only(&connector->display_info, mode))

This one shouldn't be necessary. drm_mode_validate_ycbcr420() has
already checked it for us.

>  		clock /= 2;
>  
>  	status = intel_hdmi_mode_clock_valid(hdmi, clock, has_hdmi_sink);
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: airlied@linux.ie, daniel@ffwll.ch,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] Add missing check
Date: Tue, 4 May 2021 12:41:48 +0300	[thread overview]
Message-ID: <YJEW3J0+RQPo22AD@intel.com> (raw)
In-Reply-To: <20210503182148.851790-3-wse@tuxedocomputers.com>

On Mon, May 03, 2021 at 08:21:46PM +0200, Werner Sembach wrote:
> Add a missing check that could potentially lead to an unarchivable mode being
> validated.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> 
> >From 54fa706f0a5f260a32af5d18b9622ceebb94c12e Mon Sep 17 00:00:00 2001
> From: Werner Sembach <wse@tuxedocomputers.com>
> Date: Mon, 3 May 2021 14:42:36 +0200
> Subject: [PATCH 2/4] Add missing check

I guess you did something a bit wonky with git format-patch/send-mail?

> 
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 576d3d910d06..ce165ef28e88 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1913,7 +1913,7 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
>  		clock *= 2;
>  	}
>  
> -	if (drm_mode_is_420_only(&connector->display_info, mode))
> +	if (connector->ycbcr_420_allowed && drm_mode_is_420_only(&connector->display_info, mode))

This one shouldn't be necessary. drm_mode_validate_ycbcr420() has
already checked it for us.

>  		clock /= 2;
>  
>  	status = intel_hdmi_mode_clock_valid(hdmi, clock, has_hdmi_sink);
> -- 
> 2.25.1

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2021-05-04  9:41 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 18:21 [Intel-gfx] [PATCH 0/4] drm/i915/display Try YCbCr420 color when RGB fails Werner Sembach
2021-05-03 18:21 ` Werner Sembach
2021-05-03 18:21 ` Werner Sembach
2021-05-03 18:21 ` [Intel-gfx] [PATCH 1/4] New function to avoid duplicate code in upcomming commits Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-03 18:21 ` [Intel-gfx] [PATCH 2/4] Add missing check Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-04  9:41   ` Ville Syrjälä [this message]
2021-05-04  9:41     ` Ville Syrjälä
2021-05-04  9:41     ` Ville Syrjälä
2021-05-05  9:32     ` [Intel-gfx] " Werner Sembach
2021-05-05  9:32       ` Werner Sembach
2021-05-05  9:32       ` Werner Sembach
2021-05-03 18:21 ` [Intel-gfx] [PATCH 3/4] Restructure output format computation for better expandability Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-03 21:03   ` [Intel-gfx] " kernel test robot
2021-05-03 21:03     ` kernel test robot
2021-05-03 21:03     ` kernel test robot
2021-05-03 21:03     ` kernel test robot
2021-05-03 22:55   ` [Intel-gfx] " kernel test robot
2021-05-03 22:55     ` kernel test robot
2021-05-03 22:55     ` kernel test robot
2021-05-03 22:55     ` kernel test robot
2021-05-04  9:54   ` [Intel-gfx] " Ville Syrjälä
2021-05-04  9:54     ` Ville Syrjälä
2021-05-04  9:54     ` Ville Syrjälä
2021-05-05  9:54     ` [Intel-gfx] " Werner Sembach
2021-05-05  9:54       ` Werner Sembach
2021-05-05  9:54       ` Werner Sembach
2021-05-05 12:15       ` [Intel-gfx] " Ville Syrjälä
2021-05-05 12:15         ` Ville Syrjälä
2021-05-05 12:15         ` Ville Syrjälä
2021-05-05 13:02         ` [Intel-gfx] " Werner Sembach
2021-05-05 13:02           ` Werner Sembach
2021-05-05 13:02           ` Werner Sembach
2021-05-05 13:59           ` [Intel-gfx] " Ville Syrjälä
2021-05-05 13:59             ` Ville Syrjälä
2021-05-05 13:59             ` Ville Syrjälä
2021-05-03 18:21 ` [Intel-gfx] [PATCH 4/4] Use YCbCr420 as fallback when RGB fails Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-03 18:21   ` Werner Sembach
2021-05-04 10:08   ` [Intel-gfx] " Ville Syrjälä
2021-05-04 10:08     ` Ville Syrjälä
2021-05-04 10:08     ` Ville Syrjälä
2021-05-05 13:18     ` [Intel-gfx] " Werner Sembach
2021-05-05 13:18       ` Werner Sembach
2021-05-05 13:18       ` Werner Sembach
2021-05-03 21:54 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display Try YCbCr420 color " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJEW3J0+RQPo22AD@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.