All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Kai Huang <kai.huang@intel.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] KVM: VMX: Fix a typo in comment around handle_vmx_instruction()
Date: Wed, 5 May 2021 14:28:31 -0700	[thread overview]
Message-ID: <YJMN/4LE5u7NNW9e@google.com> (raw)
In-Reply-To: <20210429042237.51280-1-kai.huang@intel.com>

On Thu, Apr 29, 2021, Kai Huang wrote:
> It is nested_vmx_hardware_setup() which overwrites VMX instruction VM
> exits handlers, but not nested_vmx_setup().  Fix the typo in comment.
> 
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> ---
>  arch/x86/kvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 10b610fc7bbc..f8661bc113ed 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -5618,7 +5618,7 @@ static int handle_preemption_timer(struct kvm_vcpu *vcpu)
>  
>  /*
>   * When nested=0, all VMX instruction VM Exits filter here.  The handlers
> - * are overwritten by nested_vmx_setup() when nested=1.
> + * are overwritten by nested_vmx_hardware_setup() when nested=1.

Alternatively, to reduce the odds of the comment becoming stale again:

    are overwritten during hardware setup when nested=1.

>   */
>  static int handle_vmx_instruction(struct kvm_vcpu *vcpu)
>  {
> -- 
> 2.30.2
> 

      reply	other threads:[~2021-05-05 21:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  4:22 [PATCH] KVM: VMX: Fix a typo in comment around handle_vmx_instruction() Kai Huang
2021-05-05 21:28 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJMN/4LE5u7NNW9e@google.com \
    --to=seanjc@google.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.