* [PATCH] KVM: VMX: Fix a typo in comment around handle_vmx_instruction()
@ 2021-04-29 4:22 Kai Huang
2021-05-05 21:28 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Kai Huang @ 2021-04-29 4:22 UTC (permalink / raw)
To: kvm; +Cc: pbonzini, Kai Huang
It is nested_vmx_hardware_setup() which overwrites VMX instruction VM
exits handlers, but not nested_vmx_setup(). Fix the typo in comment.
Signed-off-by: Kai Huang <kai.huang@intel.com>
---
arch/x86/kvm/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 10b610fc7bbc..f8661bc113ed 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -5618,7 +5618,7 @@ static int handle_preemption_timer(struct kvm_vcpu *vcpu)
/*
* When nested=0, all VMX instruction VM Exits filter here. The handlers
- * are overwritten by nested_vmx_setup() when nested=1.
+ * are overwritten by nested_vmx_hardware_setup() when nested=1.
*/
static int handle_vmx_instruction(struct kvm_vcpu *vcpu)
{
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] KVM: VMX: Fix a typo in comment around handle_vmx_instruction()
2021-04-29 4:22 [PATCH] KVM: VMX: Fix a typo in comment around handle_vmx_instruction() Kai Huang
@ 2021-05-05 21:28 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2021-05-05 21:28 UTC (permalink / raw)
To: Kai Huang; +Cc: kvm, pbonzini
On Thu, Apr 29, 2021, Kai Huang wrote:
> It is nested_vmx_hardware_setup() which overwrites VMX instruction VM
> exits handlers, but not nested_vmx_setup(). Fix the typo in comment.
>
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 10b610fc7bbc..f8661bc113ed 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -5618,7 +5618,7 @@ static int handle_preemption_timer(struct kvm_vcpu *vcpu)
>
> /*
> * When nested=0, all VMX instruction VM Exits filter here. The handlers
> - * are overwritten by nested_vmx_setup() when nested=1.
> + * are overwritten by nested_vmx_hardware_setup() when nested=1.
Alternatively, to reduce the odds of the comment becoming stale again:
are overwritten during hardware setup when nested=1.
> */
> static int handle_vmx_instruction(struct kvm_vcpu *vcpu)
> {
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-05 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-29 4:22 [PATCH] KVM: VMX: Fix a typo in comment around handle_vmx_instruction() Kai Huang
2021-05-05 21:28 ` Sean Christopherson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.