All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	KarimAllah Ahmed <karahmed@amazon.de>,
	Android Kernel Team <kernel-team@android.com>,
	Architecture Mailman List <boot-architecture@lists.linaro.org>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region
Date: Mon, 10 May 2021 10:09:13 +0000	[thread overview]
Message-ID: <YJkGSb72aKg6ScGo@google.com> (raw)
In-Reply-To: <ad90b2bb-0fab-9f06-28dd-038e8005490b@foss.st.com>

Hi Alexandre,

On Friday 07 May 2021 at 17:15:20 (+0200), Alexandre TORGUE wrote:
> Did you get time to continue some tests on this issue ?

I did try a few things, but still fail to reproduced :/

> On my side this DT is not working:
> 
> memory@c0000000 {
>         reg = <0xc0000000 0x20000000>;
> };
> 
> reserved-memory {
>         #address-cells = <1>;
>         #size-cells = <1>;
>         ranges;
> 
>         gpu_reserved: gpu@d4000000 {
>                 reg = <0xd4000000 0x4000000>;
>                 no-map;
>         };
> };

So this does change how memory appears in /proc/iomem for me switching
from 5.4.101 to v5.4.102 -- for the former d4000000-d7ffffff doesn't
appear at all, and for the latter it appears as 'reserved'.

But still, it never gets accounted as System RAM for me ...

> Let me know if I can help.

Could you please confirm you get a correct behaviour with 5.10.31 like
Florian? If so, then bisecting to figure out what we're missing in older
LTSes would help, but again it feels like we should just revert -- this
wasn't really a fix in the first place.

Thanks,
Quentin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Quentin Perret <qperret@google.com>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	KarimAllah Ahmed <karahmed@amazon.de>,
	Android Kernel Team <kernel-team@android.com>,
	Architecture Mailman List <boot-architecture@lists.linaro.org>,
	Frank Rowand <frowand.list@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region
Date: Mon, 10 May 2021 10:09:13 +0000	[thread overview]
Message-ID: <YJkGSb72aKg6ScGo@google.com> (raw)
In-Reply-To: <ad90b2bb-0fab-9f06-28dd-038e8005490b@foss.st.com>

Hi Alexandre,

On Friday 07 May 2021 at 17:15:20 (+0200), Alexandre TORGUE wrote:
> Did you get time to continue some tests on this issue ?

I did try a few things, but still fail to reproduced :/

> On my side this DT is not working:
> 
> memory@c0000000 {
>         reg = <0xc0000000 0x20000000>;
> };
> 
> reserved-memory {
>         #address-cells = <1>;
>         #size-cells = <1>;
>         ranges;
> 
>         gpu_reserved: gpu@d4000000 {
>                 reg = <0xd4000000 0x4000000>;
>                 no-map;
>         };
> };

So this does change how memory appears in /proc/iomem for me switching
from 5.4.101 to v5.4.102 -- for the former d4000000-d7ffffff doesn't
appear at all, and for the latter it appears as 'reserved'.

But still, it never gets accounted as System RAM for me ...

> Let me know if I can help.

Could you please confirm you get a correct behaviour with 5.10.31 like
Florian? If so, then bisecting to figure out what we're missing in older
LTSes would help, but again it feels like we should just revert -- this
wasn't really a fix in the first place.

Thanks,
Quentin

  reply	other threads:[~2021-05-10 10:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 14:02 [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region Alexandre TORGUE
2021-04-20 14:45 ` Rob Herring
2021-04-20 15:12   ` Alexandre TORGUE
2021-04-20 15:54     ` Rob Herring
2021-04-20 15:54       ` Rob Herring
2021-04-20 16:10       ` Ard Biesheuvel
2021-04-20 16:10         ` Ard Biesheuvel
2021-04-20 16:33         ` Florian Fainelli
2021-04-20 16:33           ` Florian Fainelli
2021-04-21  8:31           ` Quentin Perret
2021-04-21  8:31             ` Quentin Perret
2021-04-21  8:45             ` Quentin Perret
2021-04-21  8:45               ` Quentin Perret
2021-04-21 14:33             ` Florian Fainelli
2021-04-21 14:33               ` Florian Fainelli
2021-04-21 15:17               ` Florian Fainelli
2021-04-21 15:17                 ` Florian Fainelli
2021-04-22 13:03                 ` Quentin Perret
2021-04-22 13:03                   ` Quentin Perret
2021-04-22 12:59               ` Quentin Perret
2021-04-22 12:59                 ` Quentin Perret
2021-05-07 15:15                 ` Alexandre TORGUE
2021-05-07 15:15                   ` Alexandre TORGUE
2021-05-10 10:09                   ` Quentin Perret [this message]
2021-05-10 10:09                     ` Quentin Perret
2021-05-12 10:55                     ` Alexandre TORGUE
2021-05-12 10:55                       ` Alexandre TORGUE
2021-05-12 12:34                       ` Quentin Perret
2021-05-12 12:34                         ` Quentin Perret
2021-05-12 12:44                         ` Alexandre TORGUE
2021-05-12 12:44                           ` Alexandre TORGUE
2021-04-20 21:05         ` Rob Herring
2021-04-20 21:05           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJkGSb72aKg6ScGo@google.com \
    --to=qperret@google.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=boot-architecture@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=f.fainelli@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=karahmed@amazon.de \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.