From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask
Date: Mon, 10 May 2021 15:28:44 -0700 [thread overview]
Message-ID: <YJmznEhGCZTaER0+@gmail.com> (raw)
In-Reply-To: <YJlGU+STYD5geyIc@google.com>
On Mon, May 10, 2021 at 07:42:27AM -0700, Jaegeuk Kim wrote:
> In f2fs_fileattr_set(),
>
> if (!fa->flags_valid)
> mask &= FS_COMMON_FL;
>
> In this case, we can set supported flags by mask only instead of BUG_ON.
>
> /* Flags shared betwen flags/xflags */
> (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
> FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \
> FS_PROJINHERIT_FL)
>
> Fixes: 4c5b47997521 ("vfs: add fileattr ops")
Shouldn't it be:
Fixes: 9b1bb01c8ae7 ("f2fs: convert to fileattr")
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask
Date: Mon, 10 May 2021 15:28:44 -0700 [thread overview]
Message-ID: <YJmznEhGCZTaER0+@gmail.com> (raw)
In-Reply-To: <YJlGU+STYD5geyIc@google.com>
On Mon, May 10, 2021 at 07:42:27AM -0700, Jaegeuk Kim wrote:
> In f2fs_fileattr_set(),
>
> if (!fa->flags_valid)
> mask &= FS_COMMON_FL;
>
> In this case, we can set supported flags by mask only instead of BUG_ON.
>
> /* Flags shared betwen flags/xflags */
> (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
> FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \
> FS_PROJINHERIT_FL)
>
> Fixes: 4c5b47997521 ("vfs: add fileattr ops")
Shouldn't it be:
Fixes: 9b1bb01c8ae7 ("f2fs: convert to fileattr")
next prev parent reply other threads:[~2021-05-10 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 19:13 [f2fs-dev] [PATCH] f2fs: return -EPERM given generic mask Jaegeuk Kim
2021-05-06 19:13 ` Jaegeuk Kim
2021-05-07 6:26 ` [f2fs-dev] " Eric Biggers
2021-05-07 6:26 ` Eric Biggers
2021-05-10 14:39 ` Jaegeuk Kim
2021-05-10 14:39 ` Jaegeuk Kim
2021-05-10 14:42 ` [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask Jaegeuk Kim
2021-05-10 14:42 ` Jaegeuk Kim
2021-05-10 22:28 ` Eric Biggers [this message]
2021-05-10 22:28 ` [f2fs-dev] " Eric Biggers
2021-05-11 0:21 ` Jaegeuk Kim
2021-05-11 0:21 ` Jaegeuk Kim
2021-05-11 1:43 ` Chao Yu
2021-05-11 1:43 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJmznEhGCZTaER0+@gmail.com \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.