All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12  3:30 ` Zou Wei
  0 siblings, 0 replies; 9+ messages in thread
From: Zou Wei @ 2021-05-12  3:30 UTC (permalink / raw)
  To: linux-aspeed

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/net/mdio/mdio-aspeed.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index cad8205..bb9933f 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -141,6 +141,7 @@ static const struct of_device_id aspeed_mdio_of_match[] = {
 	{ .compatible = "aspeed,ast2600-mdio", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);
 
 static struct platform_driver aspeed_mdio_driver = {
 	.driver = {
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12  3:30 ` Zou Wei
  0 siblings, 0 replies; 9+ messages in thread
From: Zou Wei @ 2021-05-12  3:30 UTC (permalink / raw)
  To: andrew, hkallweit1, linux, davem, kuba, joel, andrew
  Cc: netdev, linux-arm-kernel, linux-aspeed, linux-kernel, Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/net/mdio/mdio-aspeed.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index cad8205..bb9933f 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -141,6 +141,7 @@ static const struct of_device_id aspeed_mdio_of_match[] = {
 	{ .compatible = "aspeed,ast2600-mdio", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);
 
 static struct platform_driver aspeed_mdio_driver = {
 	.driver = {
-- 
2.6.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12  3:30 ` Zou Wei
  0 siblings, 0 replies; 9+ messages in thread
From: Zou Wei @ 2021-05-12  3:30 UTC (permalink / raw)
  To: andrew, hkallweit1, linux, davem, kuba, joel, andrew
  Cc: netdev, linux-arm-kernel, linux-aspeed, linux-kernel, Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/net/mdio/mdio-aspeed.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index cad8205..bb9933f 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -141,6 +141,7 @@ static const struct of_device_id aspeed_mdio_of_match[] = {
 	{ .compatible = "aspeed,ast2600-mdio", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);
 
 static struct platform_driver aspeed_mdio_driver = {
 	.driver = {
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
  2021-05-12  3:30 ` Zou Wei
  (?)
@ 2021-05-12  6:34   ` Joel Stanley
  -1 siblings, 0 replies; 9+ messages in thread
From: Joel Stanley @ 2021-05-12  6:34 UTC (permalink / raw)
  To: linux-aspeed

On Wed, 12 May 2021 at 03:13, Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Acked-by: Joel Stanley <joel@jms.id.au>

Thanks for the patch.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12  6:34   ` Joel Stanley
  0 siblings, 0 replies; 9+ messages in thread
From: Joel Stanley @ 2021-05-12  6:34 UTC (permalink / raw)
  To: Zou Wei
  Cc: Andrew Lunn, hkallweit1, Russell King, David S . Miller,
	Jakub Kicinski, Andrew Jeffery, Networking, Linux ARM,
	linux-aspeed, Linux Kernel Mailing List

On Wed, 12 May 2021 at 03:13, Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Acked-by: Joel Stanley <joel@jms.id.au>

Thanks for the patch.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12  6:34   ` Joel Stanley
  0 siblings, 0 replies; 9+ messages in thread
From: Joel Stanley @ 2021-05-12  6:34 UTC (permalink / raw)
  To: Zou Wei
  Cc: Andrew Lunn, hkallweit1, Russell King, David S . Miller,
	Jakub Kicinski, Andrew Jeffery, Networking, Linux ARM,
	linux-aspeed, Linux Kernel Mailing List

On Wed, 12 May 2021 at 03:13, Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Fixes: f160e99462c6 ("net: phy: Add mdio-aspeed")
Acked-by: Joel Stanley <joel@jms.id.au>

Thanks for the patch.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
  2021-05-12  3:30 ` Zou Wei
  (?)
@ 2021-05-12 12:42   ` Andrew Lunn
  -1 siblings, 0 replies; 9+ messages in thread
From: Andrew Lunn @ 2021-05-12 12:42 UTC (permalink / raw)
  To: linux-aspeed

On Wed, May 12, 2021 at 11:30:04AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Please make the subject line more specific. There are a number of MDIO
bus drivers in the kernel. Adding "aspeed:" would make it clear which
one you are changing.

    Andrew

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12 12:42   ` Andrew Lunn
  0 siblings, 0 replies; 9+ messages in thread
From: Andrew Lunn @ 2021-05-12 12:42 UTC (permalink / raw)
  To: Zou Wei
  Cc: hkallweit1, linux, davem, kuba, joel, andrew, netdev,
	linux-arm-kernel, linux-aspeed, linux-kernel

On Wed, May 12, 2021 at 11:30:04AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Please make the subject line more specific. There are a number of MDIO
bus drivers in the kernel. Adding "aspeed:" would make it clear which
one you are changing.

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE
@ 2021-05-12 12:42   ` Andrew Lunn
  0 siblings, 0 replies; 9+ messages in thread
From: Andrew Lunn @ 2021-05-12 12:42 UTC (permalink / raw)
  To: Zou Wei
  Cc: hkallweit1, linux, davem, kuba, joel, andrew, netdev,
	linux-arm-kernel, linux-aspeed, linux-kernel

On Wed, May 12, 2021 at 11:30:04AM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Please make the subject line more specific. There are a number of MDIO
bus drivers in the kernel. Adding "aspeed:" would make it clear which
one you are changing.

    Andrew

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-05-12 12:44 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-12  3:30 [PATCH net-next] net: mdio: Add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12  3:30 ` Zou Wei
2021-05-12  3:30 ` Zou Wei
2021-05-12  6:34 ` Joel Stanley
2021-05-12  6:34   ` Joel Stanley
2021-05-12  6:34   ` Joel Stanley
2021-05-12 12:42 ` Andrew Lunn
2021-05-12 12:42   ` Andrew Lunn
2021-05-12 12:42   ` Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.