From: Ming Lei <ming.lei@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, linux-block@vger.kernel.org,
Yuanyuan Zhong <yzhong@purestorage.com>,
Casey Chen <cachen@purestorage.com>
Subject: Re: [PATCHv3 2/4] nvme: use blk_execute_rq() for passthrough commands
Date: Wed, 26 May 2021 16:24:58 +0800 [thread overview]
Message-ID: <YK4F2ll2qLWqzlKT@T590> (raw)
In-Reply-To: <20210521202145.3674904-3-kbusch@kernel.org>
On Fri, May 21, 2021 at 01:21:43PM -0700, Keith Busch wrote:
> The generic blk_execute_rq() knows how to handle polled completions. Use
> that instead of implementing an nvme specific handler.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> No changes since v2
Looks fine, one thing need to pay attention is that this nvme polled
request won't be marked as REQ_HIPRI.
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, linux-block@vger.kernel.org,
Yuanyuan Zhong <yzhong@purestorage.com>,
Casey Chen <cachen@purestorage.com>
Subject: Re: [PATCHv3 2/4] nvme: use blk_execute_rq() for passthrough commands
Date: Wed, 26 May 2021 16:24:58 +0800 [thread overview]
Message-ID: <YK4F2ll2qLWqzlKT@T590> (raw)
In-Reply-To: <20210521202145.3674904-3-kbusch@kernel.org>
On Fri, May 21, 2021 at 01:21:43PM -0700, Keith Busch wrote:
> The generic blk_execute_rq() knows how to handle polled completions. Use
> that instead of implementing an nvme specific handler.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> No changes since v2
Looks fine, one thing need to pay attention is that this nvme polled
request won't be marked as REQ_HIPRI.
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-26 8:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 20:21 [PATCHv3 0/4] block and nvme passthrough error handling Keith Busch
2021-05-21 20:21 ` Keith Busch
2021-05-21 20:21 ` [PATCHv3 1/4] block: support polling through blk_execute_rq Keith Busch
2021-05-21 20:21 ` Keith Busch
2021-05-24 7:38 ` Christoph Hellwig
2021-05-24 7:38 ` Christoph Hellwig
2021-05-26 8:16 ` Ming Lei
2021-05-26 8:16 ` Ming Lei
2021-05-21 20:21 ` [PATCHv3 2/4] nvme: use blk_execute_rq() for passthrough commands Keith Busch
2021-05-21 20:21 ` Keith Busch
2021-05-24 7:38 ` Christoph Hellwig
2021-05-24 7:38 ` Christoph Hellwig
2021-05-26 8:24 ` Ming Lei [this message]
2021-05-26 8:24 ` Ming Lei
2021-05-26 8:47 ` Kanchan Joshi
2021-05-26 8:47 ` Kanchan Joshi
2021-06-07 16:15 ` Keith Busch
2021-06-07 16:15 ` Keith Busch
2021-06-08 5:26 ` Christoph Hellwig
2021-06-08 5:26 ` Christoph Hellwig
2021-05-21 20:21 ` [PATCHv3 3/4] block: return errors from blk_execute_rq() Keith Busch
2021-05-21 20:21 ` Keith Busch
2021-05-24 7:39 ` Christoph Hellwig
2021-05-24 7:39 ` Christoph Hellwig
2021-05-26 8:26 ` Ming Lei
2021-05-26 8:26 ` Ming Lei
2021-05-21 20:21 ` [PATCHv3 4/4] nvme: use return value " Keith Busch
2021-05-21 20:21 ` Keith Busch
2021-05-24 8:04 ` Christoph Hellwig
2021-05-24 8:04 ` Christoph Hellwig
2021-06-07 16:58 ` Keith Busch
2021-06-07 16:58 ` Keith Busch
2021-06-08 5:26 ` Christoph Hellwig
2021-06-08 5:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK4F2ll2qLWqzlKT@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=cachen@purestorage.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.