From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Gowtham Tammana <g-tammana@ti.com>, Suman Anna <s-anna@ti.com>,
bcousson@baylibre.com, robh+dt@kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Nisanth Menon <nm@ti.com>
Subject: Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node
Date: Thu, 27 May 2021 12:09:21 +0300 [thread overview]
Message-ID: <YK9hwV8DaC+d4OvV@atomide.com> (raw)
In-Reply-To: <bd903d6a-2894-fc39-e431-5dfed04a3604@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [210527 09:03]:
> On 27/05/2021 08:48, Tony Lindgren wrote:
> > But let's keep the target-module@140000 here as it puts it in the right
> > location rather than directly on the ocp. Let's mark it with
> > status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only
> > available on dra74x. So similar to what you had in your v1 patch, except
> > disabled.
>
> My preference would be not to mix SoC variant specific modules in common module,
> and fix dra74x instead by placing usb4 node in proper place:
>
> &l4_per3 { /* 0x48800000 */
> segment@0 {
> -->
Yeah that's even better, and leaves out status = "disabled".
Sounds good to me.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Nisanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, Gowtham Tammana <g-tammana@ti.com>,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
bcousson@baylibre.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node
Date: Thu, 27 May 2021 12:09:21 +0300 [thread overview]
Message-ID: <YK9hwV8DaC+d4OvV@atomide.com> (raw)
In-Reply-To: <bd903d6a-2894-fc39-e431-5dfed04a3604@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [210527 09:03]:
> On 27/05/2021 08:48, Tony Lindgren wrote:
> > But let's keep the target-module@140000 here as it puts it in the right
> > location rather than directly on the ocp. Let's mark it with
> > status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only
> > available on dra74x. So similar to what you had in your v1 patch, except
> > disabled.
>
> My preference would be not to mix SoC variant specific modules in common module,
> and fix dra74x instead by placing usb4 node in proper place:
>
> &l4_per3 { /* 0x48800000 */
> segment@0 {
> -->
Yeah that's even better, and leaves out status = "disabled".
Sounds good to me.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-27 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 21:30 [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node Gowtham Tammana
2021-05-26 21:30 ` Gowtham Tammana
2021-05-27 5:48 ` Tony Lindgren
2021-05-27 5:48 ` Tony Lindgren
2021-05-27 9:03 ` Grygorii Strashko
2021-05-27 9:03 ` Grygorii Strashko
2021-05-27 9:09 ` Tony Lindgren [this message]
2021-05-27 9:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK9hwV8DaC+d4OvV@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=g-tammana@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.