From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, ch@denx.de,
Rob Herring <robh+dt@kernel.org>, Sam Ravnborg <sam@ravnborg.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
Date: Sun, 16 May 2021 00:48:05 +0300 [thread overview]
Message-ID: <YKBBlWXXK8LUc8ac@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210515203932.366799-1-marex@denx.de>
Hi Marek,
Thank you for the patch.
On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> Add missing spaces to make the diagrams readable, no functional change.
Looks better indeed. The patch view looks bad though, because of the
tabs. Maybe you could replace them with spaces, while at it ?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/panel/lvds.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> index 31164608ba1d..06d7ca692d0d 100644
> --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> @@ -52,9 +52,9 @@ properties:
> [VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
> @@ -63,9 +63,9 @@ properties:
> specifications. Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
> DATA1 ><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
> @@ -75,9 +75,9 @@ properties:
> Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
ch@denx.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
Date: Sun, 16 May 2021 00:48:05 +0300 [thread overview]
Message-ID: <YKBBlWXXK8LUc8ac@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210515203932.366799-1-marex@denx.de>
Hi Marek,
Thank you for the patch.
On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> Add missing spaces to make the diagrams readable, no functional change.
Looks better indeed. The patch view looks bad though, because of the
tabs. Maybe you could replace them with spaces, while at it ?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> .../devicetree/bindings/display/panel/lvds.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lvds.yaml b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> index 31164608ba1d..06d7ca692d0d 100644
> --- a/Documentation/devicetree/bindings/display/panel/lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/lvds.yaml
> @@ -52,9 +52,9 @@ properties:
> [VESA] specifications. Data are transferred as follows on 3 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
> @@ -63,9 +63,9 @@ properties:
> specifications. Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G2__><__R7__><__R6__><__R5__><__R4__><__R3__><__R2__><
> DATA1 ><__B3__><__B2__><__G7__><__G6__><__G5__><__G4__><__G3__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B7__><__B6__><__B5__><__B4__><
> @@ -75,9 +75,9 @@ properties:
> Data are transferred as follows on 4 LVDS lanes.
>
> Slot 0 1 2 3 4 5 6
> - ________________ _________________
> + ________________ _________________
> Clock \_______________________/
> - ______ ______ ______ ______ ______ ______ ______
> + ______ ______ ______ ______ ______ ______ ______
> DATA0 ><__G0__><__R5__><__R4__><__R3__><__R2__><__R1__><__R0__><
> DATA1 ><__B1__><__B0__><__G5__><__G4__><__G3__><__G2__><__G1__><
> DATA2 ><_CTL2_><_CTL1_><_CTL0_><__B5__><__B4__><__B3__><__B2__><
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-05-15 21:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 20:39 [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing Marek Vasut
2021-05-15 20:39 ` Marek Vasut
2021-05-15 21:48 ` Laurent Pinchart [this message]
2021-05-15 21:48 ` Laurent Pinchart
2021-05-15 23:49 ` Marek Vasut
2021-05-15 23:49 ` Marek Vasut
2021-05-16 0:46 ` Laurent Pinchart
2021-05-16 0:46 ` Laurent Pinchart
2021-05-18 12:59 ` Rob Herring
2021-05-18 12:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKBBlWXXK8LUc8ac@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=ch@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.