From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update()
Date: Sun, 16 May 2021 17:30:57 +0900 [thread overview]
Message-ID: <YKDYQfDf7GiMfGCN@google.com> (raw)
In-Reply-To: <YJ5cHdv6MVmAKD3b@google.com>
On (21/05/14 20:16), Sergey Senozhatsky wrote:
> > --- a/sound/pci/intel8x0.c
> > +++ b/sound/pci/intel8x0.c
> > @@ -691,6 +691,9 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich
> > int status, civ, i, step;
> > int ack = 0;
> >
> > + if (!ichdev->substream || ichdev->suspended)
> > + return;
> > +
> > spin_lock_irqsave(&chip->reg_lock, flags);
> > status = igetbyte(chip, port + ichdev->roff_sr);
> > civ = igetbyte(chip, port + ICH_REG_OFF_CIV);
This does the problem for me.
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Leon Romanovsky <leon@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update()
Date: Sun, 16 May 2021 17:30:57 +0900 [thread overview]
Message-ID: <YKDYQfDf7GiMfGCN@google.com> (raw)
In-Reply-To: <YJ5cHdv6MVmAKD3b@google.com>
On (21/05/14 20:16), Sergey Senozhatsky wrote:
> > --- a/sound/pci/intel8x0.c
> > +++ b/sound/pci/intel8x0.c
> > @@ -691,6 +691,9 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich
> > int status, civ, i, step;
> > int ack = 0;
> >
> > + if (!ichdev->substream || ichdev->suspended)
> > + return;
> > +
> > spin_lock_irqsave(&chip->reg_lock, flags);
> > status = igetbyte(chip, port + ichdev->roff_sr);
> > civ = igetbyte(chip, port + ICH_REG_OFF_CIV);
This does the problem for me.
next prev parent reply other threads:[~2021-05-16 8:32 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:17 ALSA: intel8x0: div by zero in snd_intel8x0_update() Sergey Senozhatsky
2021-05-14 8:17 ` Sergey Senozhatsky
2021-05-14 11:05 ` Takashi Iwai
2021-05-14 11:05 ` Takashi Iwai
2021-05-14 11:16 ` Sergey Senozhatsky
2021-05-14 11:16 ` Sergey Senozhatsky
2021-05-16 8:30 ` Sergey Senozhatsky [this message]
2021-05-16 8:30 ` Sergey Senozhatsky
2021-05-16 8:31 ` Sergey Senozhatsky
2021-05-16 8:31 ` Sergey Senozhatsky
2021-05-16 9:49 ` Takashi Iwai
2021-05-16 9:49 ` Takashi Iwai
2021-05-16 10:59 ` Sergey Senozhatsky
2021-05-16 10:59 ` Sergey Senozhatsky
2021-05-16 11:23 ` Sergey Senozhatsky
2021-05-16 11:23 ` Sergey Senozhatsky
2021-05-16 12:07 ` Takashi Iwai
2021-05-16 12:07 ` Takashi Iwai
2021-05-16 12:55 ` Sergey Senozhatsky
2021-05-16 12:55 ` Sergey Senozhatsky
2021-07-06 17:50 ` Max Filippov
2021-07-06 17:50 ` Max Filippov
2021-07-07 7:02 ` Takashi Iwai
2021-07-07 7:02 ` Takashi Iwai
2021-07-07 17:50 ` Max Filippov
2021-07-07 17:50 ` Max Filippov
2021-07-07 18:14 ` Takashi Iwai
2021-07-07 18:14 ` Takashi Iwai
2021-07-07 20:33 ` Max Filippov
2021-07-07 20:33 ` Max Filippov
2021-07-08 7:13 ` Takashi Iwai
2021-07-08 7:13 ` Takashi Iwai
2021-07-08 8:41 ` Max Filippov
2021-07-08 8:41 ` Max Filippov
2021-07-08 9:00 ` Takashi Iwai
2021-07-08 9:00 ` Takashi Iwai
2021-07-08 10:12 ` Sergey Senozhatsky
2021-07-08 10:12 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKDYQfDf7GiMfGCN@google.com \
--to=senozhatsky@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=gustavoars@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.