From: asmadeus@codewreck.org
To: Xie Yongji <xieyongji@bytedance.com>
Cc: ohad@wizery.com, jean-philippe@linaro.org, amit@kernel.org,
airlied@linux.ie, mst@redhat.com, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, miklos@szeredi.hu,
stefanha@redhat.com, virtualization@lists.linux-foundation.org,
vgoyal@redhat.com
Subject: Re: [RFC PATCH 15/15] 9p/trans_virtio: Handle virtio_device_ready() failure
Date: Mon, 17 May 2021 18:53:39 +0900 [thread overview]
Message-ID: <YKI9I9qg2iISlz65@codewreck.org> (raw)
In-Reply-To: <20210517093428.670-16-xieyongji@bytedance.com>
Xie Yongji wrote on Mon, May 17, 2021 at 05:34:28PM +0800:
> Now virtio_device_ready() will return error if we get
> invalid status. Let's handle this case on probe.
The change itself looks good to me
It's going to be a pain to apply though because it depends on
https://lkml.kernel.org/r/20210517083557.172-1-xieyongji@bytedance.com
you just sent, so this won't apply to virtio maintainers on one hand,
and I can't take just this patch because it depends on the first patch
in the patchset (well if it weren't RFC)...
I guess sending the other patch to Linus fast-ish so it can go in virtio
tree would be the best way forward? other maintainers please advise, I'm
bad at this.
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Acked-by: Dominique Martinet <asmadeus@codewreck.org>
--
Dominique
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: asmadeus@codewreck.org
To: Xie Yongji <xieyongji@bytedance.com>
Cc: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
amit@kernel.org, arei.gonglei@huawei.com, airlied@linux.ie,
kraxel@redhat.com, jean-philippe@linaro.org, ohad@wizery.com,
bjorn.andersson@linaro.org, david@redhat.com, vgoyal@redhat.com,
miklos@szeredi.hu, lucho@ionkov.net,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 15/15] 9p/trans_virtio: Handle virtio_device_ready() failure
Date: Mon, 17 May 2021 18:53:39 +0900 [thread overview]
Message-ID: <YKI9I9qg2iISlz65@codewreck.org> (raw)
In-Reply-To: <20210517093428.670-16-xieyongji@bytedance.com>
Xie Yongji wrote on Mon, May 17, 2021 at 05:34:28PM +0800:
> Now virtio_device_ready() will return error if we get
> invalid status. Let's handle this case on probe.
The change itself looks good to me
It's going to be a pain to apply though because it depends on
https://lkml.kernel.org/r/20210517083557.172-1-xieyongji@bytedance.com
you just sent, so this won't apply to virtio maintainers on one hand,
and I can't take just this patch because it depends on the first patch
in the patchset (well if it weren't RFC)...
I guess sending the other patch to Linus fast-ish so it can go in virtio
tree would be the best way forward? other maintainers please advise, I'm
bad at this.
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Acked-by: Dominique Martinet <asmadeus@codewreck.org>
--
Dominique
next prev parent reply other threads:[~2021-05-17 10:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 9:34 [RFC PATCH 00/15] Handle virtio_device_ready() failure Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 01/15] virtio_config: Add return value to virtio_device_ready() Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 02/15] virtio-blk: Handle virtio_device_ready() failure Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 03/15] virtio_console: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 04/15] virtio_crypto: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 05/15] drm/virtio: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 06/15] virtio-iommu: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 07/15] virtio-net: " Xie Yongji
2021-05-17 9:34 ` Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 08/15] rpmsg: virtio: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 10/15] " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 11/15] virtio-balloon: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 12/15] virtio-input: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 13/15] virtio-mem: " Xie Yongji
2021-05-17 9:48 ` David Hildenbrand
2021-05-17 9:48 ` David Hildenbrand
2021-05-17 10:08 ` Yongji Xie
2021-05-17 9:34 ` [RFC PATCH 14/15] virtiofs: " Xie Yongji
2021-05-17 9:34 ` [RFC PATCH 15/15] 9p/trans_virtio: " Xie Yongji
2021-05-17 9:53 ` asmadeus [this message]
2021-05-17 9:53 ` asmadeus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKI9I9qg2iISlz65@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=airlied@linux.ie \
--cc=amit@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jean-philippe@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mst@redhat.com \
--cc=ohad@wizery.com \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.