All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dario Binacchi <dariobin@libero.it>
Cc: linux-kernel@vger.kernel.org,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: single: set pinmux from pins debug file
Date: Mon, 17 May 2021 08:57:30 +0300	[thread overview]
Message-ID: <YKIFygbbMxqXON8W@atomide.com> (raw)
In-Reply-To: <20210516135531.2203-3-dariobin@libero.it>

Hi,

* Dario Binacchi <dariobin@libero.it> [210516 13:55]:
> @@ -331,6 +348,9 @@ static const struct pinctrl_ops pcs_pinctrl_ops = {
>  	.get_group_name = pinctrl_generic_get_group_name,
>  	.get_group_pins = pinctrl_generic_get_group_pins,
>  	.pin_dbg_show = pcs_pin_dbg_show,
> +#if IS_ENABLED(CONFIG_DEVMEM) && IS_ENABLED(CONFIG_SOC_AM33XX)
> +	.pin_dbg_set = pcs_pin_dbg_set,
> +#endif
>  	.dt_node_to_map = pcs_dt_node_to_map,
>  	.dt_free_map = pcs_dt_free_map,
>  };

I don't think there should be any CONFIG_SOC_AM33XX dependency here?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Dario Binacchi <dariobin@libero.it>
Cc: linux-kernel@vger.kernel.org,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: single: set pinmux from pins debug file
Date: Mon, 17 May 2021 08:57:30 +0300	[thread overview]
Message-ID: <YKIFygbbMxqXON8W@atomide.com> (raw)
In-Reply-To: <20210516135531.2203-3-dariobin@libero.it>

Hi,

* Dario Binacchi <dariobin@libero.it> [210516 13:55]:
> @@ -331,6 +348,9 @@ static const struct pinctrl_ops pcs_pinctrl_ops = {
>  	.get_group_name = pinctrl_generic_get_group_name,
>  	.get_group_pins = pinctrl_generic_get_group_pins,
>  	.pin_dbg_show = pcs_pin_dbg_show,
> +#if IS_ENABLED(CONFIG_DEVMEM) && IS_ENABLED(CONFIG_SOC_AM33XX)
> +	.pin_dbg_set = pcs_pin_dbg_set,
> +#endif
>  	.dt_node_to_map = pcs_dt_node_to_map,
>  	.dt_free_map = pcs_dt_free_map,
>  };

I don't think there should be any CONFIG_SOC_AM33XX dependency here?

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-17  5:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-16 13:55 [PATCH 0/2] am335x: set pinmux registers from pins debug file Dario Binacchi
2021-05-16 13:55 ` Dario Binacchi
2021-05-16 13:55 ` [PATCH 1/2] pinctrl: core: configure pinmux " Dario Binacchi
2021-05-17 20:02   ` Andy Shevchenko
2021-05-17 22:57     ` Drew Fustini
2021-05-18  9:38       ` Dario Binacchi
2021-05-18 10:21         ` Drew Fustini
2021-05-18 10:41           ` Andy Shevchenko
2021-05-18 13:57     ` Dario Binacchi
2021-05-18 14:01       ` Andy Shevchenko
2021-05-19 10:02         ` Drew Fustini
2021-05-19 11:27           ` Andy Shevchenko
2021-05-20  4:17             ` Drew Fustini
2021-05-20  8:10               ` Andy Shevchenko
2021-05-16 13:55 ` [PATCH 2/2] pinctrl: single: set " Dario Binacchi
2021-05-16 13:55   ` Dario Binacchi
2021-05-17  5:57   ` Tony Lindgren [this message]
2021-05-17  5:57     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKIFygbbMxqXON8W@atomide.com \
    --to=tony@atomide.com \
    --cc=dariobin@libero.it \
    --cc=haojian.zhuang@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.