All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: JeffleXu <jefflexu@linux.alibaba.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	Mike Snitzer <snitzer@redhat.com>
Subject: Re: [dm-devel] [PATCH V6 00/12] block: support bio based io polling
Date: Mon, 17 May 2021 15:13:29 +0800	[thread overview]
Message-ID: <YKIXmRTmLlAgO3AK@T590> (raw)
In-Reply-To: <630a63ef-f9e0-6ad6-d6be-ec7a46e5ec45@linux.alibaba.com>

Hi JeffleXu,

On Mon, May 17, 2021 at 02:16:39PM +0800, JeffleXu wrote:
> Hi all,
> 
> What's the latest progress of this bio-based polling feature?
> 
> I've noticed that hch has also sent a patch set on this [1]. But as far
> as I know, hch's patch set only refactors the interface of polling in
> the block layer. It indeed helps bio-based polling for some kind of
> bio-based driver, but for DM/MD where one bio could be mapped to several
> split bios, more work is obviously needed, just like Lei Ming's
> io_context related code in this patch set.
> 
> hch may have better idea, after all [1] is just a preparation patch set.

Yeah, we have to rebase V6 against Christoph's patchset anyway.

Looks there is at least two approaches left for us:

1) keep the generic approach in V6, just rebase after Christoph's patch
is finalized

2) support io polling simply in bio driver, since bio->bi_cookie is
assigned for underlying bio, and it shouldn't be very difficult to
support that in DM/MD. I have been thinking of it a while, but not
coding it yet. BTW, all underlying bios can be linked to DM
bio->bi_next, and we can add one new callback of .io_poll for polling
DM/MD's bio.


Thanks,
Ming

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: JeffleXu <jefflexu@linux.alibaba.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH V6 00/12] block: support bio based io polling
Date: Mon, 17 May 2021 15:13:29 +0800	[thread overview]
Message-ID: <YKIXmRTmLlAgO3AK@T590> (raw)
In-Reply-To: <630a63ef-f9e0-6ad6-d6be-ec7a46e5ec45@linux.alibaba.com>

Hi JeffleXu,

On Mon, May 17, 2021 at 02:16:39PM +0800, JeffleXu wrote:
> Hi all,
> 
> What's the latest progress of this bio-based polling feature?
> 
> I've noticed that hch has also sent a patch set on this [1]. But as far
> as I know, hch's patch set only refactors the interface of polling in
> the block layer. It indeed helps bio-based polling for some kind of
> bio-based driver, but for DM/MD where one bio could be mapped to several
> split bios, more work is obviously needed, just like Lei Ming's
> io_context related code in this patch set.
> 
> hch may have better idea, after all [1] is just a preparation patch set.

Yeah, we have to rebase V6 against Christoph's patchset anyway.

Looks there is at least two approaches left for us:

1) keep the generic approach in V6, just rebase after Christoph's patch
is finalized

2) support io polling simply in bio driver, since bio->bi_cookie is
assigned for underlying bio, and it shouldn't be very difficult to
support that in DM/MD. I have been thinking of it a while, but not
coding it yet. BTW, all underlying bios can be linked to DM
bio->bi_next, and we can add one new callback of .io_poll for polling
DM/MD's bio.


Thanks,
Ming


  reply	other threads:[~2021-05-17  7:14 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 12:20 [dm-devel] [PATCH V6 00/12] block: support bio based io polling Ming Lei
2021-04-22 12:20 ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 01/12] block: add helper of blk_queue_poll Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 02/12] block: define 'struct bvec_iter' as packed Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 13:18   ` [dm-devel] " Hannes Reinecke
2021-04-22 13:18     ` Hannes Reinecke
2021-04-22 12:20 ` [dm-devel] [PATCH V6 03/12] block: add one helper to free io_context Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 04/12] block: move block polling code into one dedicated source file Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 13:19   ` [dm-devel] " Hannes Reinecke
2021-04-22 13:19     ` Hannes Reinecke
2021-04-26  7:12   ` [dm-devel] " Hannes Reinecke
2021-04-26  7:12     ` Hannes Reinecke
2021-04-22 12:20 ` [dm-devel] [PATCH V6 05/12] block: extract one helper function polling hw queue Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 06/12] block: prepare for supporting bio_list via other link Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 07/12] block: create io poll context for submission and poll task Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 08/12] block: add req flag of REQ_POLL_CTX Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-22 12:20 ` [dm-devel] [PATCH V6 09/12] block: use per-task poll context to implement bio based io polling Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-26  7:17   ` [dm-devel] " Hannes Reinecke
2021-04-26  7:17     ` Hannes Reinecke
2021-04-22 12:20 ` [dm-devel] [PATCH V6 10/12] block: limit hw queues to be polled in each blk_poll() Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-26  7:19   ` [dm-devel] " Hannes Reinecke
2021-04-26  7:19     ` Hannes Reinecke
2021-04-26  8:00     ` [dm-devel] " Ming Lei
2021-04-26  8:00       ` Ming Lei
2021-04-26  9:05       ` [dm-devel] " Hannes Reinecke
2021-04-26  9:05         ` Hannes Reinecke
2021-04-22 12:20 ` [dm-devel] [PATCH V6 11/12] block: allow to control FLAG_POLL via sysfs for bio poll capable queue Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-26  7:20   ` [dm-devel] " Hannes Reinecke
2021-04-26  7:20     ` Hannes Reinecke
2021-04-22 12:20 ` [dm-devel] [PATCH V6 12/12] dm: support IO polling for bio-based dm device Ming Lei
2021-04-22 12:20   ` Ming Lei
2021-04-23  1:32   ` [dm-devel] " JeffleXu
2021-04-23  1:32     ` JeffleXu
2021-04-23  2:39     ` [dm-devel] " Ming Lei
2021-04-23  2:39       ` Ming Lei
2021-04-23  2:38   ` [dm-devel] [PATCH V7 " Ming Lei
2021-04-23  2:38     ` Ming Lei
2021-05-17  6:16 ` [dm-devel] [PATCH V6 00/12] block: support bio based io polling JeffleXu
2021-05-17  6:16   ` JeffleXu
2021-05-17  7:13   ` Ming Lei [this message]
2021-05-17  7:13     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKIXmRTmLlAgO3AK@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.