From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: jaegeuk@kernel.org, marcosfrm <marcosfrm@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs
Date: Mon, 17 May 2021 10:27:45 -0700 [thread overview]
Message-ID: <YKKnkSag35cDXh0Z@gmail.com> (raw)
In-Reply-To: <20210517011557.21722-1-yuchao0@huawei.com>
On Mon, May 17, 2021 at 09:15:57AM +0800, Chao Yu wrote:
> As marcosfrm reported in bugzilla:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=213089
>
> Initramfs generators rely on "pre" softdeps (and "depends") to include
> additional required modules.
>
> F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
> mkinitcpio...) has to maintain a hardcoded list for this purpose.
>
> Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
>
> Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
> Reported-by: marcosfrm <marcosfrm@gmail.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 3f8a7a6c250c..fa0ce6301c16 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
> MODULE_AUTHOR("Samsung Electronics's Praesto Team");
> MODULE_DESCRIPTION("Flash Friendly File System");
> MODULE_LICENSE("GPL");
> +MODULE_SOFTDEP("pre: crc32c");
Shouldn't it be crc32, not crc32c?
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: jaegeuk@kernel.org, marcosfrm <marcosfrm@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs
Date: Mon, 17 May 2021 10:27:45 -0700 [thread overview]
Message-ID: <YKKnkSag35cDXh0Z@gmail.com> (raw)
In-Reply-To: <20210517011557.21722-1-yuchao0@huawei.com>
On Mon, May 17, 2021 at 09:15:57AM +0800, Chao Yu wrote:
> As marcosfrm reported in bugzilla:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=213089
>
> Initramfs generators rely on "pre" softdeps (and "depends") to include
> additional required modules.
>
> F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
> mkinitcpio...) has to maintain a hardcoded list for this purpose.
>
> Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
>
> Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
> Reported-by: marcosfrm <marcosfrm@gmail.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 3f8a7a6c250c..fa0ce6301c16 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
> MODULE_AUTHOR("Samsung Electronics's Praesto Team");
> MODULE_DESCRIPTION("Flash Friendly File System");
> MODULE_LICENSE("GPL");
> +MODULE_SOFTDEP("pre: crc32c");
Shouldn't it be crc32, not crc32c?
- Eric
next prev parent reply other threads:[~2021-05-17 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 1:15 [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs Chao Yu
2021-05-17 1:15 ` Chao Yu
2021-05-17 17:27 ` Eric Biggers [this message]
2021-05-17 17:27 ` [f2fs-dev] " Eric Biggers
2021-05-18 0:51 ` Chao Yu
2021-05-18 0:51 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKKnkSag35cDXh0Z@gmail.com \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcosfrm@gmail.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.