From: Zev Weiss <zweiss@equinix.com>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 07/16] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc
Date: Fri, 21 May 2021 07:18:43 +0000 [thread overview]
Message-ID: <YKde0k1UCZacJFc6@packtop> (raw)
In-Reply-To: <20210510054213.1610760-8-andrew@aj.id.au>
On Mon, May 10, 2021 at 12:42:04AM CDT, Andrew Jeffery wrote:
>Move all client-private data out of `struct kcs_bmc` into the KCS client
>implementation.
>
>With this change the KCS BMC core code now only concerns itself with
>abstract `struct kcs_bmc` and `struct kcs_bmc_client` types, achieving
>expected separation of concerns. Further, the change clears the path for
>implementation of alternative userspace interfaces.
>
>The chardev data-structures are rearranged in the same manner applied to
>the KCS device driver data-structures in an earlier patch - `struct
>kcs_bmc_client` is embedded in the client's private data and we exploit
>container_of() to translate as required.
>
>Finally, now that it is free of client data, `struct kcs_bmc` is renamed
>to `struct kcs_bmc_device` to contrast `struct kcs_bmc_client`.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Zev Weiss <zweiss@equinix.com>
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"minyard@acm.org" <minyard@acm.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"avifishman70@gmail.com" <avifishman70@gmail.com>,
"venture@google.com" <venture@google.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tali.perry1@gmail.com" <tali.perry1@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"benjaminfair@google.com" <benjaminfair@google.com>,
"openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"chiawei_wang@aspeedtech.com" <chiawei_wang@aspeedtech.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"tmaimon77@gmail.com" <tmaimon77@gmail.com>
Subject: Re: [PATCH v3 07/16] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc
Date: Fri, 21 May 2021 07:18:43 +0000 [thread overview]
Message-ID: <YKde0k1UCZacJFc6@packtop> (raw)
In-Reply-To: <20210510054213.1610760-8-andrew@aj.id.au>
On Mon, May 10, 2021 at 12:42:04AM CDT, Andrew Jeffery wrote:
>Move all client-private data out of `struct kcs_bmc` into the KCS client
>implementation.
>
>With this change the KCS BMC core code now only concerns itself with
>abstract `struct kcs_bmc` and `struct kcs_bmc_client` types, achieving
>expected separation of concerns. Further, the change clears the path for
>implementation of alternative userspace interfaces.
>
>The chardev data-structures are rearranged in the same manner applied to
>the KCS device driver data-structures in an earlier patch - `struct
>kcs_bmc_client` is embedded in the client's private data and we exploit
>container_of() to translate as required.
>
>Finally, now that it is free of client data, `struct kcs_bmc` is renamed
>to `struct kcs_bmc_device` to contrast `struct kcs_bmc_client`.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Zev Weiss <zweiss@equinix.com>
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: "openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"minyard@acm.org" <minyard@acm.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tmaimon77@gmail.com" <tmaimon77@gmail.com>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"avifishman70@gmail.com" <avifishman70@gmail.com>,
"venture@google.com" <venture@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tali.perry1@gmail.com" <tali.perry1@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"chiawei_wang@aspeedtech.com" <chiawei_wang@aspeedtech.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"benjaminfair@google.com" <benjaminfair@google.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH v3 07/16] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc
Date: Fri, 21 May 2021 07:18:43 +0000 [thread overview]
Message-ID: <YKde0k1UCZacJFc6@packtop> (raw)
In-Reply-To: <20210510054213.1610760-8-andrew@aj.id.au>
On Mon, May 10, 2021 at 12:42:04AM CDT, Andrew Jeffery wrote:
>Move all client-private data out of `struct kcs_bmc` into the KCS client
>implementation.
>
>With this change the KCS BMC core code now only concerns itself with
>abstract `struct kcs_bmc` and `struct kcs_bmc_client` types, achieving
>expected separation of concerns. Further, the change clears the path for
>implementation of alternative userspace interfaces.
>
>The chardev data-structures are rearranged in the same manner applied to
>the KCS device driver data-structures in an earlier patch - `struct
>kcs_bmc_client` is embedded in the client's private data and we exploit
>container_of() to translate as required.
>
>Finally, now that it is free of client data, `struct kcs_bmc` is renamed
>to `struct kcs_bmc_device` to contrast `struct kcs_bmc_client`.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Zev Weiss <zweiss@equinix.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Zev Weiss <zweiss@equinix.com>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: "openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"minyard@acm.org" <minyard@acm.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tmaimon77@gmail.com" <tmaimon77@gmail.com>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"avifishman70@gmail.com" <avifishman70@gmail.com>,
"venture@google.com" <venture@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tali.perry1@gmail.com" <tali.perry1@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"chiawei_wang@aspeedtech.com" <chiawei_wang@aspeedtech.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"benjaminfair@google.com" <benjaminfair@google.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH v3 07/16] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc
Date: Fri, 21 May 2021 07:18:43 +0000 [thread overview]
Message-ID: <YKde0k1UCZacJFc6@packtop> (raw)
In-Reply-To: <20210510054213.1610760-8-andrew@aj.id.au>
On Mon, May 10, 2021 at 12:42:04AM CDT, Andrew Jeffery wrote:
>Move all client-private data out of `struct kcs_bmc` into the KCS client
>implementation.
>
>With this change the KCS BMC core code now only concerns itself with
>abstract `struct kcs_bmc` and `struct kcs_bmc_client` types, achieving
>expected separation of concerns. Further, the change clears the path for
>implementation of alternative userspace interfaces.
>
>The chardev data-structures are rearranged in the same manner applied to
>the KCS device driver data-structures in an earlier patch - `struct
>kcs_bmc_client` is embedded in the client's private data and we exploit
>container_of() to translate as required.
>
>Finally, now that it is free of client data, `struct kcs_bmc` is renamed
>to `struct kcs_bmc_device` to contrast `struct kcs_bmc_client`.
>
>Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Zev Weiss <zweiss@equinix.com>
next prev parent reply other threads:[~2021-05-21 7:18 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 5:41 [PATCH v3 00/16] ipmi: Allow raw access to KCS devices Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` [PATCH v3 01/16] ipmi: kcs_bmc_aspeed: Use of match data to extract KCS properties Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-21 7:17 ` Zev Weiss
2021-05-21 7:17 ` Zev Weiss
2021-05-21 7:17 ` Zev Weiss
2021-05-21 7:17 ` Zev Weiss
2021-05-10 5:41 ` [PATCH v3 02/16] ipmi: kcs_bmc: Make status update atomic Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:41 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 03/16] ipmi: kcs_bmc: Rename {read, write}_{status, data}() functions Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 03/16] ipmi: kcs_bmc: Rename {read,write}_{status,data}() functions Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 03/16] ipmi: kcs_bmc: Rename {read, write}_{status, data}() functions Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 04/16] ipmi: kcs_bmc: Split out kcs_bmc_cdev_ipmi Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 05/16] ipmi: kcs_bmc: Turn the driver data-structures inside-out Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 17:14 ` Corey Minyard
2021-05-21 17:14 ` Corey Minyard
2021-05-21 17:14 ` Corey Minyard
2021-05-21 17:14 ` Corey Minyard
2021-05-24 0:53 ` Andrew Jeffery
2021-05-24 0:53 ` Andrew Jeffery
2021-05-24 0:53 ` Andrew Jeffery
2021-05-24 0:53 ` Andrew Jeffery
2021-05-24 15:41 ` [Openipmi-developer] " Corey Minyard
2021-05-24 15:41 ` Corey Minyard
2021-05-24 15:41 ` Corey Minyard
2021-05-24 15:41 ` Corey Minyard
2021-05-25 0:12 ` Andrew Jeffery
2021-05-25 0:12 ` Andrew Jeffery
2021-05-25 0:12 ` Andrew Jeffery
2021-05-25 0:12 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 06/16] ipmi: kcs_bmc: Split headers into device and client Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 7:18 ` Zev Weiss
2021-05-21 7:18 ` Zev Weiss
2021-05-21 7:18 ` Zev Weiss
2021-05-21 7:18 ` Zev Weiss
2021-05-10 5:42 ` [PATCH v3 07/16] ipmi: kcs_bmc: Strip private client data from struct kcs_bmc Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 7:18 ` Zev Weiss [this message]
2021-05-21 7:18 ` Zev Weiss
2021-05-21 7:18 ` Zev Weiss
2021-05-21 7:18 ` Zev Weiss
2021-05-10 5:42 ` [PATCH v3 08/16] ipmi: kcs_bmc: Decouple the IPMI chardev from the core Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 7:19 ` Zev Weiss
2021-05-21 7:19 ` Zev Weiss
2021-05-21 7:19 ` Zev Weiss
2021-05-21 7:19 ` Zev Weiss
2021-05-10 5:42 ` [PATCH v3 09/16] ipmi: kcs_bmc: Allow clients to control KCS IRQ state Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 7:19 ` Zev Weiss
2021-05-21 7:19 ` Zev Weiss
2021-05-21 7:19 ` Zev Weiss
2021-05-21 7:19 ` Zev Weiss
2021-05-10 5:42 ` [PATCH v3 10/16] ipmi: kcs_bmc: Don't enforce single-open policy in the kernel Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 17:30 ` Corey Minyard
2021-05-21 17:30 ` Corey Minyard
2021-05-21 17:30 ` Corey Minyard
2021-05-21 17:30 ` Corey Minyard
2021-05-24 0:39 ` Andrew Jeffery
2021-05-24 0:39 ` Andrew Jeffery
2021-05-24 0:39 ` Andrew Jeffery
2021-05-24 0:39 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 11/16] ipmi: kcs_bmc: Add serio adaptor Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 7:20 ` Zev Weiss
2021-05-21 7:20 ` Zev Weiss
2021-05-21 7:20 ` Zev Weiss
2021-05-21 7:20 ` Zev Weiss
2021-06-08 0:37 ` Andrew Jeffery
2021-06-08 0:37 ` Andrew Jeffery
2021-06-08 0:37 ` Andrew Jeffery
2021-06-08 0:37 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 12/16] dt-bindings: ipmi: Convert ASPEED KCS binding to schema Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 13/16] dt-bindings: ipmi: Add optional SerIRQ property to ASPEED KCS devices Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 14/16] ipmi: kcs_bmc_aspeed: Implement KCS SerIRQ configuration Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-21 7:21 ` Zev Weiss
2021-05-21 7:21 ` Zev Weiss
2021-05-21 7:21 ` Zev Weiss
2021-05-21 7:21 ` Zev Weiss
2021-06-08 0:41 ` Andrew Jeffery
2021-06-08 0:41 ` Andrew Jeffery
2021-06-08 0:41 ` Andrew Jeffery
2021-06-08 0:41 ` Andrew Jeffery
2021-06-08 0:55 ` Andrew Jeffery
2021-06-08 0:55 ` Andrew Jeffery
2021-06-08 0:55 ` Andrew Jeffery
2021-06-08 0:55 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 15/16] ipmi: kcs_bmc_aspeed: Fix IBFIE typo from datasheet Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` [PATCH v3 16/16] ipmi: kcs_bmc_aspeed: Optionally apply status address Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-10 5:42 ` Andrew Jeffery
2021-05-20 6:51 ` [PATCH v3 00/16] ipmi: Allow raw access to KCS devices Andrew Jeffery
2021-05-20 6:51 ` Andrew Jeffery
2021-05-20 6:51 ` Andrew Jeffery
2021-05-20 6:51 ` Andrew Jeffery
2021-05-20 13:33 ` Corey Minyard
2021-05-20 13:33 ` Corey Minyard
2021-05-20 13:33 ` Corey Minyard
2021-05-20 13:33 ` Corey Minyard
2021-05-21 17:36 ` Corey Minyard
2021-05-21 17:36 ` Corey Minyard
2021-05-21 17:36 ` Corey Minyard
2021-05-21 17:36 ` Corey Minyard
2021-05-24 0:36 ` Andrew Jeffery
2021-05-24 0:36 ` Andrew Jeffery
2021-05-24 0:36 ` Andrew Jeffery
2021-05-24 0:36 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKde0k1UCZacJFc6@packtop \
--to=zweiss@equinix.com \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.