All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Y. Ts'o <tytso@mit.edu>
To: lkp@lists.01.org
Subject: Re: [ext4] 05c2c00f37: aim7.jobs-per-min -11.8% regression
Date: Fri, 21 May 2021 12:42:16 -0400	[thread overview]
Message-ID: <YKfi6Pv+qwduKxuT@mit.edu> (raw)
In-Reply-To: <20210521092730.GE18952@quack2.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

On Fri, May 21, 2021 at 11:27:30AM +0200, Jan Kara wrote:
> 
> OK, thanks for testing. So the orphan code is indeed the likely cause of
> this regression but I probably did not guess correctly what is the
> contention point there. Then I guess I need to reproduce and do more
> digging why the contention happens...

Hmm... what if we only recalculate the superblock checksum when we do
a commit, via the callback function from the jbd2 layer to file
system?

					- Ted

WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>,
	kernel test robot <oliver.sang@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org, lkp@intel.com
Subject: Re: [LKP] [ext4] 05c2c00f37: aim7.jobs-per-min -11.8% regression
Date: Fri, 21 May 2021 12:42:16 -0400	[thread overview]
Message-ID: <YKfi6Pv+qwduKxuT@mit.edu> (raw)
In-Reply-To: <20210521092730.GE18952@quack2.suse.cz>

On Fri, May 21, 2021 at 11:27:30AM +0200, Jan Kara wrote:
> 
> OK, thanks for testing. So the orphan code is indeed the likely cause of
> this regression but I probably did not guess correctly what is the
> contention point there. Then I guess I need to reproduce and do more
> digging why the contention happens...

Hmm... what if we only recalculate the superblock checksum when we do
a commit, via the callback function from the jbd2 layer to file
system?

					- Ted

  reply	other threads:[~2021-05-21 16:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27 12:08 [ext4] 05c2c00f37: aim7.jobs-per-min -11.8% regression kernel test robot
2021-02-27 12:08 ` kernel test robot
2021-05-20  7:13 ` Xing Zhengjun
2021-05-20  9:51   ` Jan Kara
2021-05-20  9:51     ` [LKP] " Jan Kara
2021-05-21  1:16     ` Xing Zhengjun
2021-05-21  1:16       ` [LKP] " Xing Zhengjun
2021-05-21  9:27       ` Jan Kara
2021-05-21  9:27         ` [LKP] " Jan Kara
2021-05-21 16:42         ` Theodore Y. Ts'o [this message]
2021-05-21 16:42           ` Theodore Y. Ts'o
2021-05-25  9:22           ` Jan Kara
2021-05-25  9:22             ` [LKP] " Jan Kara
2021-05-25 17:15             ` Theodore Ts'o
2021-05-25 17:15               ` [LKP] " Theodore Ts'o
2021-05-31 16:57             ` Jan Kara
2021-05-31 16:57               ` [LKP] " Jan Kara
2021-06-03 16:10               ` Jan Kara
2021-06-03 16:10                 ` [LKP] " Jan Kara
2021-09-03  5:28                 ` Xing Zhengjun
2021-09-03  5:28                   ` [LKP] " Xing Zhengjun
2021-09-03 12:32                   ` Theodore Ts'o
2021-09-03 12:32                     ` [LKP] " Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKfi6Pv+qwduKxuT@mit.edu \
    --to=tytso@mit.edu \
    --cc=lkp@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.