From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-iio <linux-iio@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Denis Ciocca <denis.ciocca@st.com>,
Daniel Drake <drake@endlessm.com>,
Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH 1/5 v3] iio: st_sensors: Create extended attr macro
Date: Mon, 24 May 2021 13:39:04 +0300 [thread overview]
Message-ID: <YKuCSC93G/lI55T/@smile.fi.intel.com> (raw)
In-Reply-To: <YKuCACQYtsuDcyqv@smile.fi.intel.com>
On Mon, May 24, 2021 at 01:37:52PM +0300, Andy Shevchenko wrote:
> On Mon, May 24, 2021 at 10:50:42AM +0100, Jonathan Cameron wrote:
> > On Mon, 24 May 2021 11:43:11 +0200
> > Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > > On Sat, May 22, 2021 at 8:14 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > >
> > > > @Linus, for IIO stuff, please put a cover letter on series as it makes it
> > > > easier for people to reply with things like this
> > >
> > > OK sorry about that, I'll try to keep it in mind.
> > >
> > > > and still let me use b4
> > > > without manual tweaking.
> > >
> > > b4 only need the patches to be sent in a thread which I
> > > actually did, at least this works fine for me from here:
> > >
> > > tmp]$ b4 am -t 20210518230722.522446-1-linus.walleij@linaro.org
> > > Looking up https://lore.kernel.org/r/20210518230722.522446-1-linus.walleij%40linaro.org
> > > Grabbing thread from lore.kernel.org/linux-iio
> > > Analyzing 7 messages in the thread
> > > ---
> > > Writing ./v3_20210519_linus_walleij_iio_st_sensors_create_extended_attr_macro.mbx
> > > ✓ [PATCH 1/5 v3] iio: st_sensors: Create extended attr macro
> > > + Reviewed-by: Hans de Goede <hdegoede@redhat.com> (✓ DKIM/redhat.com)
> > > ✓ [PATCH 2/5 v3] iio: accel: st_sensors: Support generic mounting matrix
> > > ✓ [PATCH 3/5 v3] iio: accel: st_sensors: Stop copying channels
> > > ✓ [PATCH 4/5 v3] iio: magnetometer: st_magn: Support mount matrix
> > > ✓ [PATCH 5/5 v3] iio: gyro: st_gyro: Support mount matrix
> >
> > That only adds the Reviewed-by for patch 1 which was not Hans'
> > intention. If the reply was to a cover letter it would apply to all of the patches.
>
> It's easy to fix with `git filter-branch --msg-filter ...`.
But OTOH, tools may not recognize a human intention well from the natural
language, it's also recommended to the reviewers to be explicit that bots can
handle it (here: add a tag per each patch that is considered to be tagged).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-24 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 23:07 [PATCH 1/5 v3] iio: st_sensors: Create extended attr macro Linus Walleij
2021-05-18 23:07 ` [PATCH 2/5 v3] iio: accel: st_sensors: Support generic mounting matrix Linus Walleij
2021-05-18 23:07 ` [PATCH 3/5 v3] iio: accel: st_sensors: Stop copying channels Linus Walleij
2021-05-18 23:07 ` [PATCH 4/5 v3] iio: magnetometer: st_magn: Support mount matrix Linus Walleij
2021-05-18 23:07 ` [PATCH 5/5 v3] iio: gyro: st_gyro: " Linus Walleij
2021-05-19 13:17 ` [PATCH 1/5 v3] iio: st_sensors: Create extended attr macro Hans de Goede
2021-05-22 18:15 ` Jonathan Cameron
2021-05-24 9:43 ` Linus Walleij
2021-05-24 9:50 ` Jonathan Cameron
2021-05-24 10:37 ` Andy Shevchenko
2021-05-24 10:39 ` Andy Shevchenko [this message]
2021-05-24 12:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKuCSC93G/lI55T/@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=denis.ciocca@st.com \
--cc=drake@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.