From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] docs/tools/virtiofsd: Fix bad rst syntax
Date: Mon, 7 Jun 2021 19:58:47 +0100 [thread overview]
Message-ID: <YL5sZ8xprsuG/S0D@work-vm> (raw)
In-Reply-To: <20210607180015.924571-1-thuth@redhat.com>
* Thomas Huth (thuth@redhat.com) wrote:
> For literal blocks, there has to be an empty line after the two colons,
> and the block itself should be indented.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> docs/tools/virtiofsd.rst | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 265a39b0cf..4911e797cb 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -239,7 +239,7 @@ xattr-mapping Examples
>
> ::
>
> --o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
> + -o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
>
>
> This uses two rules, using : as the field separator;
> @@ -250,7 +250,8 @@ the host set.
> This is equivalent to the 'map' rule:
>
> ::
> --o xattrmap=":map::user.virtiofs.:"
> +
> + -o xattrmap=":map::user.virtiofs.:"
>
> 2) Prefix 'trusted.' attributes, allow others through
>
> @@ -277,7 +278,8 @@ through.
> This is equivalent to the 'map' rule:
>
> ::
> --o xattrmap="/map/trusted./user.virtiofs./"
> +
> + -o xattrmap="/map/trusted./user.virtiofs./"
>
> 3) Hide 'security.' attributes, and allow everything else
>
> --
> 2.27.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] docs/tools/virtiofsd: Fix bad rst syntax
Date: Mon, 7 Jun 2021 19:58:47 +0100 [thread overview]
Message-ID: <YL5sZ8xprsuG/S0D@work-vm> (raw)
In-Reply-To: <20210607180015.924571-1-thuth@redhat.com>
* Thomas Huth (thuth@redhat.com) wrote:
> For literal blocks, there has to be an empty line after the two colons,
> and the block itself should be indented.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> docs/tools/virtiofsd.rst | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 265a39b0cf..4911e797cb 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -239,7 +239,7 @@ xattr-mapping Examples
>
> ::
>
> --o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
> + -o xattrmap=":prefix:all::user.virtiofs.::bad:all:::"
>
>
> This uses two rules, using : as the field separator;
> @@ -250,7 +250,8 @@ the host set.
> This is equivalent to the 'map' rule:
>
> ::
> --o xattrmap=":map::user.virtiofs.:"
> +
> + -o xattrmap=":map::user.virtiofs.:"
>
> 2) Prefix 'trusted.' attributes, allow others through
>
> @@ -277,7 +278,8 @@ through.
> This is equivalent to the 'map' rule:
>
> ::
> --o xattrmap="/map/trusted./user.virtiofs./"
> +
> + -o xattrmap="/map/trusted./user.virtiofs./"
>
> 3) Hide 'security.' attributes, and allow everything else
>
> --
> 2.27.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-06-07 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 18:00 [PATCH] docs/tools/virtiofsd: Fix bad rst syntax Thomas Huth
2021-06-07 18:58 ` Dr. David Alan Gilbert [this message]
2021-06-07 18:58 ` Dr. David Alan Gilbert
2021-06-08 8:29 ` Stefan Hajnoczi
2021-06-08 8:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL5sZ8xprsuG/S0D@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.