From: Mike Rapoport <rppt@linux.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Qian Cai <quic_qiancai@quicinc.com>,
David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Arm64 crash while reading memory sysfs
Date: Fri, 28 May 2021 08:13:38 +0300 [thread overview]
Message-ID: <YLB8AvgC2Ov6N6Pt@linux.ibm.com> (raw)
In-Reply-To: <20210527155644.7792b4eaa16ec56645e1080c@linux-foundation.org>
On Thu, May 27, 2021 at 03:56:44PM -0700, Andrew Morton wrote:
> On Thu, 27 May 2021 18:50:48 +0100 Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> > > Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID":
> > >
> > > https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com
> > >
> > > It seems to me that the check for memblock_is_memory() in
> > > arm64::pfn_valid() is what makes init_unavailable_range() to bail out for
> > > section parts that are not actually populated and then we have
> > > VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages.
> >
> > I acked Anshuman's patch, I think they all need to go in together.
>
> That's neat. Specifically which patches are we referring to here?
arm64: drop pfn_valid_within() and simplify pfn_valid():
https://lore.kernel.org/lkml/20210511100550.28178-5-rppt@kernel.org
arm64/mm: Drop HAVE_ARCH_PFN_VALID:
https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@linux.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Qian Cai <quic_qiancai@quicinc.com>,
David Hildenbrand <david@redhat.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: Arm64 crash while reading memory sysfs
Date: Fri, 28 May 2021 08:13:38 +0300 [thread overview]
Message-ID: <YLB8AvgC2Ov6N6Pt@linux.ibm.com> (raw)
In-Reply-To: <20210527155644.7792b4eaa16ec56645e1080c@linux-foundation.org>
On Thu, May 27, 2021 at 03:56:44PM -0700, Andrew Morton wrote:
> On Thu, 27 May 2021 18:50:48 +0100 Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> > > Can you please try Anshuman's patch "arm64/mm: Drop HAVE_ARCH_PFN_VALID":
> > >
> > > https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com
> > >
> > > It seems to me that the check for memblock_is_memory() in
> > > arm64::pfn_valid() is what makes init_unavailable_range() to bail out for
> > > section parts that are not actually populated and then we have
> > > VM_BUG_ON_PAGE(PagePoisoned(p)) for these pages.
> >
> > I acked Anshuman's patch, I think they all need to go in together.
>
> That's neat. Specifically which patches are we referring to here?
arm64: drop pfn_valid_within() and simplify pfn_valid():
https://lore.kernel.org/lkml/20210511100550.28178-5-rppt@kernel.org
arm64/mm: Drop HAVE_ARCH_PFN_VALID:
https://lore.kernel.org/lkml/1621947349-25421-1-git-send-email-anshuman.khandual@arm.com
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-05-28 5:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 15:25 Arm64 crash while reading memory sysfs Qian Cai (QUIC)
2021-05-25 15:25 ` Qian Cai (QUIC)
2021-05-25 15:37 ` David Hildenbrand
2021-05-25 15:37 ` David Hildenbrand
2021-05-26 6:40 ` Mike Rapoport
2021-05-26 6:40 ` Mike Rapoport
2021-05-26 12:09 ` Qian Cai (QUIC)
2021-05-26 12:09 ` Qian Cai (QUIC)
2021-05-26 13:04 ` Catalin Marinas
2021-05-26 13:04 ` Catalin Marinas
2021-05-26 17:25 ` Mike Rapoport
2021-05-26 17:25 ` Mike Rapoport
2021-05-26 17:24 ` Mike Rapoport
2021-05-26 17:24 ` Mike Rapoport
2021-05-27 0:16 ` Qian Cai
2021-05-27 0:16 ` Qian Cai
2021-05-27 0:31 ` Andrew Morton
2021-05-27 0:31 ` Andrew Morton
2021-05-27 7:25 ` Stephen Rothwell
2021-05-27 7:25 ` Stephen Rothwell
2021-05-27 8:56 ` Mike Rapoport
2021-05-27 8:56 ` Mike Rapoport
2021-05-27 14:33 ` Qian Cai
2021-05-27 14:33 ` Qian Cai
2021-05-27 16:22 ` Mike Rapoport
2021-05-27 16:22 ` Mike Rapoport
2021-05-27 17:00 ` Qian Cai
2021-05-27 17:00 ` Qian Cai
2021-05-27 17:12 ` David Hildenbrand
2021-05-27 17:12 ` David Hildenbrand
2021-05-27 17:50 ` Catalin Marinas
2021-05-27 17:50 ` Catalin Marinas
2021-05-27 22:56 ` Andrew Morton
2021-05-27 22:56 ` Andrew Morton
2021-05-28 5:13 ` Mike Rapoport [this message]
2021-05-28 5:13 ` Mike Rapoport
2021-06-08 7:06 ` Anshuman Khandual
2021-06-08 7:06 ` Anshuman Khandual
2021-06-14 8:25 ` Mike Rapoport
2021-06-14 8:25 ` Mike Rapoport
2021-06-15 0:13 ` Andrew Morton
2021-06-15 0:13 ` Andrew Morton
2021-06-15 6:05 ` Mike Rapoport
2021-06-15 6:05 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLB8AvgC2Ov6N6Pt@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=quic_qiancai@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.