From: Andrew Lunn <andrew@lunn.ch>
To: kbuild-all@lists.01.org
Subject: Re: ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
Date: Mon, 31 May 2021 16:46:20 +0200 [thread overview]
Message-ID: <YLT2vB0GwC1sJesL@lunn.ch> (raw)
In-Reply-To: <0717b3a5-d838-e1ed-a4ac-80cf14f3a6aa@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
> > No, we should just fix the driver instead.
> >
> > + /* Wait 1000 clocks so we don't saturate the RSL bus
> > + * doing reads.
> > + */
> > + __delay(1000);
> >
> > As this is used only on Cavium Octeon and Thunder SoCs, running
> > at 400-600 MHz resp. 1800-2000 Mhz, what about replacing the __delay()
> > call by a call to udelay(1) or udelay(2)?
>
> Yeah, I was planning to look into that change this week,
> but it would probably be better for David to do it.
If you look at the bigger picture, using linux/iopoll.h would be a
better solution.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rich Felker <dalias@libc.org>,
David Daney <david.daney@cavium.com>
Subject: Re: ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
Date: Mon, 31 May 2021 16:46:20 +0200 [thread overview]
Message-ID: <YLT2vB0GwC1sJesL@lunn.ch> (raw)
In-Reply-To: <0717b3a5-d838-e1ed-a4ac-80cf14f3a6aa@infradead.org>
> > No, we should just fix the driver instead.
> >
> > + /* Wait 1000 clocks so we don't saturate the RSL bus
> > + * doing reads.
> > + */
> > + __delay(1000);
> >
> > As this is used only on Cavium Octeon and Thunder SoCs, running
> > at 400-600 MHz resp. 1800-2000 Mhz, what about replacing the __delay()
> > call by a call to udelay(1) or udelay(2)?
>
> Yeah, I was planning to look into that change this week,
> but it would probably be better for David to do it.
If you look at the bigger picture, using linux/iopoll.h would be a
better solution.
Andrew
next prev parent reply other threads:[~2021-05-31 14:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 23:25 ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined! kernel test robot
2021-05-29 23:25 ` kernel test robot
2021-05-31 0:05 ` Randy Dunlap
2021-05-31 0:05 ` Randy Dunlap
2021-05-31 1:13 ` Randy Dunlap
2021-05-31 1:13 ` Randy Dunlap
2021-05-31 7:36 ` Geert Uytterhoeven
2021-05-31 7:36 ` Geert Uytterhoeven
2021-05-31 14:34 ` Randy Dunlap
2021-05-31 14:34 ` Randy Dunlap
2021-05-31 14:46 ` Andrew Lunn [this message]
2021-05-31 14:46 ` Andrew Lunn
2021-05-31 15:09 ` Geert Uytterhoeven
2021-05-31 15:09 ` Geert Uytterhoeven
2021-05-31 7:29 ` Geert Uytterhoeven
2021-05-31 7:29 ` Geert Uytterhoeven
2021-05-31 7:32 ` Geert Uytterhoeven
2021-05-31 7:32 ` Geert Uytterhoeven
2021-05-31 15:12 ` Randy Dunlap
2021-05-31 15:12 ` Randy Dunlap
2021-05-31 15:45 ` Geert Uytterhoeven
2021-05-31 15:45 ` Geert Uytterhoeven
2021-06-02 3:52 ` Randy Dunlap
2021-06-02 3:52 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2024-12-28 13:35 kernel test robot
2024-12-28 13:50 ` Geert Uytterhoeven
2024-12-28 13:55 ` Geert Uytterhoeven
2024-12-29 2:23 ` Philip Li
2024-07-26 0:38 kernel test robot
2024-07-26 7:26 ` Geert Uytterhoeven
2024-07-11 17:34 kernel test robot
2024-03-23 20:39 kernel test robot
2022-07-16 6:59 kernel test robot
2021-07-24 23:11 kernel test robot
2021-07-24 23:11 ` kernel test robot
2021-07-11 0:49 kernel test robot
2021-07-11 0:49 ` kernel test robot
2021-05-19 23:52 kernel test robot
2021-05-19 23:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLT2vB0GwC1sJesL@lunn.ch \
--to=andrew@lunn.ch \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.