All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Clark <robdclark@gmail.com>,
	Sean Paul <sean@poorly.run>, Rob Herring <robh+dt@kernel.org>,
	Jonathan Marek <jonathan@marek.ca>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: sm8250: move bus clock to mdp node for sm8250 target
Date: Mon, 31 May 2021 09:58:08 -0500	[thread overview]
Message-ID: <YLT5gGKP3lUkpmG8@builder.lan> (raw)
In-Reply-To: <20210407150157.801210-5-dmitry.baryshkov@linaro.org>

On Wed 07 Apr 10:01 CDT 2021, Dmitry Baryshkov wrote:

> Move the bus clock to mdp device node,in order to facilitate bus band
> width scaling on sm8250 target.
> 
> The parent device MDSS will not vote for bus bw, instead the vote will
> be triggered by mdp device node. Since a minimum vote is required to
> turn on bus clock, move the clock node to mdp device from where the
> votes are requested.
> 

This commit message makes sense for the other commit, where you move the
"bus" into the mdp. Do you mind me changing this to:

The bus clock is voted by the DPU, so remove it from the MDSS node.

Regards,
Bjorn

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 394973e778f7..60fe2eaf06c5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2294,10 +2294,9 @@ mdss: mdss@ae00000 {
>  			power-domains = <&dispcc MDSS_GDSC>;
>  
>  			clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> -				 <&gcc GCC_DISP_HF_AXI_CLK>,
>  				 <&gcc GCC_DISP_SF_AXI_CLK>,
>  				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
> -			clock-names = "iface", "bus", "nrt_bus", "core";
> +			clock-names = "iface", "nrt_bus", "core";
>  
>  			assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
>  			assigned-clock-rates = <460000000>;
> -- 
> 2.30.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: freedreno@lists.freedesktop.org,
	Jonathan Marek <jonathan@marek.ca>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Andy Gross <agross@kernel.org>,
	dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 4/4] arm64: dts: sm8250: move bus clock to mdp node for sm8250 target
Date: Mon, 31 May 2021 09:58:08 -0500	[thread overview]
Message-ID: <YLT5gGKP3lUkpmG8@builder.lan> (raw)
In-Reply-To: <20210407150157.801210-5-dmitry.baryshkov@linaro.org>

On Wed 07 Apr 10:01 CDT 2021, Dmitry Baryshkov wrote:

> Move the bus clock to mdp device node,in order to facilitate bus band
> width scaling on sm8250 target.
> 
> The parent device MDSS will not vote for bus bw, instead the vote will
> be triggered by mdp device node. Since a minimum vote is required to
> turn on bus clock, move the clock node to mdp device from where the
> votes are requested.
> 

This commit message makes sense for the other commit, where you move the
"bus" into the mdp. Do you mind me changing this to:

The bus clock is voted by the DPU, so remove it from the MDSS node.

Regards,
Bjorn

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 394973e778f7..60fe2eaf06c5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2294,10 +2294,9 @@ mdss: mdss@ae00000 {
>  			power-domains = <&dispcc MDSS_GDSC>;
>  
>  			clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> -				 <&gcc GCC_DISP_HF_AXI_CLK>,
>  				 <&gcc GCC_DISP_SF_AXI_CLK>,
>  				 <&dispcc DISP_CC_MDSS_MDP_CLK>;
> -			clock-names = "iface", "bus", "nrt_bus", "core";
> +			clock-names = "iface", "nrt_bus", "core";
>  
>  			assigned-clocks = <&dispcc DISP_CC_MDSS_MDP_CLK>;
>  			assigned-clock-rates = <460000000>;
> -- 
> 2.30.2
> 

  reply	other threads:[~2021-05-31 16:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 15:01 [PATCH v2 0/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
2021-04-07 15:01 ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 1/4] drm/msm/dpu: fill missing details in hw catalog for sdm845 and sm8[12]50 Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 2/4] drm/msm/dpu: always use mdp device to scale bandwidth Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 3/4] arm64: dts: sdm845: move bus clock to mdp node for sdm845 target Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-05-28 15:33   ` Dmitry Baryshkov
2021-05-28 15:33     ` Dmitry Baryshkov
2021-05-31 14:42     ` Bjorn Andersson
2021-05-31 14:42       ` Bjorn Andersson
2021-05-31 18:03       ` Dmitry Baryshkov
2021-05-31 18:03         ` Dmitry Baryshkov
2021-04-07 15:01 ` [PATCH v2 4/4] arm64: dts: sm8250: move bus clock to mdp node for sm8250 target Dmitry Baryshkov
2021-04-07 15:01   ` Dmitry Baryshkov
2021-05-31 14:58   ` Bjorn Andersson [this message]
2021-05-31 14:58     ` Bjorn Andersson
2021-05-31 17:28     ` Dmitry Baryshkov
2021-05-31 17:28       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLT5gGKP3lUkpmG8@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jonathan@marek.ca \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.