From: Borislav Petkov <bp@alien8.de>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Pu Wen <puwen@hygon.cn>, Tom Lendacky <thomas.lendacky@amd.com>,
Yazen Ghannam <Yazen.Ghannam@amd.com>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH] perf/x86/rapl: Use CPUID bit on AMD and Hygon parts
Date: Mon, 31 May 2021 19:18:16 +0200 [thread overview]
Message-ID: <YLUaWKSjwDbUDHFO@zn.tnic> (raw)
In-Reply-To: <20210514135920.16093-1-andrew.cooper3@citrix.com>
On Fri, May 14, 2021 at 02:59:20PM +0100, Andrew Cooper wrote:
> diff --git a/arch/x86/kernel/cpu/powerflags.c b/arch/x86/kernel/cpu/powerflags.c
> index fd6ec2aa0303..e2055f51342e 100644
> --- a/arch/x86/kernel/cpu/powerflags.c
> +++ b/arch/x86/kernel/cpu/powerflags.c
> @@ -21,4 +21,6 @@ const char *const x86_power_flags[32] = {
> "eff_freq_ro", /* Readonly aperf/mperf */
> "proc_feedback", /* processor feedback interface */
> "acc_power", /* accumulated power mechanism */
> + "conn_standby", /* Connected Standby */
> + "rapl", /* Runtime Average Power Limit */
Yeah, so this repeats the "rapl" bit and that "conn_standby" is probably
not gonna be used. Unless you have a really good reason to add that
hunk, I'll whack it before applying and let this "power management"
thing in /proc/cpuinfo die unchanged.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-05-31 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 13:59 [PATCH] perf/x86/rapl: Use CPUID bit on AMD and Hygon parts Andrew Cooper
2021-05-31 17:18 ` Borislav Petkov [this message]
2021-06-01 19:23 ` [tip: x86/cpu] " tip-bot2 for Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLUaWKSjwDbUDHFO@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=puwen@hygon.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.