From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Marc Zyngier <maz@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Suleiman Souhlal <suleiman@google.com>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org,
Sean Christopherson <seanjc@google.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier
Date: Fri, 04 Jun 2021 09:22:02 +0000 [thread overview]
Message-ID: <YLnwum6AtcURNlRL@google.com> (raw)
In-Reply-To: <e4b4e872-4b22-82b7-57fc-65a7d10482c0@redhat.com>
On (21/06/04 09:24), Paolo Bonzini wrote:
> On 04/06/21 09:21, Vitaly Kuznetsov wrote:
> > > preempt_notifier_inc();
> > > + kvm_init_pm_notifier(kvm);
> > You've probably thought it through and I didn't but wouldn't it be
> > easier to have one global pm_notifier call for KVM which would go
> > through the list of VMs instead of registering/deregistering a
> > pm_notifier call for every created/destroyed VM?
>
> That raises questions on the locking, i.e. if we can we take the kvm_lock
> safely from the notifier.
Right, I wanted to take the VM lock, rather than subsystem lock
(kvm_lock).
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-s390@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Marc Zyngier <maz@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Sean Christopherson <seanjc@google.com>,
Suleiman Souhlal <suleiman@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
Jim Mattson <jmattson@google.com>
Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier
Date: Fri, 4 Jun 2021 18:22:02 +0900 [thread overview]
Message-ID: <YLnwum6AtcURNlRL@google.com> (raw)
In-Reply-To: <e4b4e872-4b22-82b7-57fc-65a7d10482c0@redhat.com>
On (21/06/04 09:24), Paolo Bonzini wrote:
> On 04/06/21 09:21, Vitaly Kuznetsov wrote:
> > > preempt_notifier_inc();
> > > + kvm_init_pm_notifier(kvm);
> > You've probably thought it through and I didn't but wouldn't it be
> > easier to have one global pm_notifier call for KVM which would go
> > through the list of VMs instead of registering/deregistering a
> > pm_notifier call for every created/destroyed VM?
>
> That raises questions on the locking, i.e. if we can we take the kvm_lock
> safely from the notifier.
Right, I wanted to take the VM lock, rather than subsystem lock
(kvm_lock).
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Marc Zyngier <maz@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Suleiman Souhlal <suleiman@google.com>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org,
Sean Christopherson <seanjc@google.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier
Date: Fri, 4 Jun 2021 18:22:02 +0900 [thread overview]
Message-ID: <YLnwum6AtcURNlRL@google.com> (raw)
In-Reply-To: <e4b4e872-4b22-82b7-57fc-65a7d10482c0@redhat.com>
On (21/06/04 09:24), Paolo Bonzini wrote:
> On 04/06/21 09:21, Vitaly Kuznetsov wrote:
> > > preempt_notifier_inc();
> > > + kvm_init_pm_notifier(kvm);
> > You've probably thought it through and I didn't but wouldn't it be
> > easier to have one global pm_notifier call for KVM which would go
> > through the list of VMs instead of registering/deregistering a
> > pm_notifier call for every created/destroyed VM?
>
> That raises questions on the locking, i.e. if we can we take the kvm_lock
> safely from the notifier.
Right, I wanted to take the VM lock, rather than subsystem lock
(kvm_lock).
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Marc Zyngier <maz@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Suleiman Souhlal <suleiman@google.com>,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org,
Sean Christopherson <seanjc@google.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier
Date: Fri, 4 Jun 2021 18:22:02 +0900 [thread overview]
Message-ID: <YLnwum6AtcURNlRL@google.com> (raw)
In-Reply-To: <e4b4e872-4b22-82b7-57fc-65a7d10482c0@redhat.com>
On (21/06/04 09:24), Paolo Bonzini wrote:
> On 04/06/21 09:21, Vitaly Kuznetsov wrote:
> > > preempt_notifier_inc();
> > > + kvm_init_pm_notifier(kvm);
> > You've probably thought it through and I didn't but wouldn't it be
> > easier to have one global pm_notifier call for KVM which would go
> > through the list of VMs instead of registering/deregistering a
> > pm_notifier call for every created/destroyed VM?
>
> That raises questions on the locking, i.e. if we can we take the kvm_lock
> safely from the notifier.
Right, I wanted to take the VM lock, rather than subsystem lock
(kvm_lock).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-04 9:22 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 16:43 [RFC][PATCH] kvm: add suspend pm-notifier Sergey Senozhatsky
2021-06-03 16:43 ` Sergey Senozhatsky
2021-06-03 16:43 ` Sergey Senozhatsky
2021-06-03 16:43 ` Sergey Senozhatsky
2021-06-03 17:27 ` Peter Zijlstra
2021-06-03 17:27 ` Peter Zijlstra
2021-06-03 17:27 ` Peter Zijlstra
2021-06-03 17:27 ` Peter Zijlstra
2021-06-04 0:39 ` Sergey Senozhatsky
2021-06-04 0:39 ` Sergey Senozhatsky
2021-06-04 0:39 ` Sergey Senozhatsky
2021-06-04 0:39 ` Sergey Senozhatsky
2021-06-04 7:17 ` Paolo Bonzini
2021-06-04 7:17 ` Paolo Bonzini
2021-06-04 7:17 ` Paolo Bonzini
2021-06-04 7:17 ` Paolo Bonzini
2021-06-04 7:21 ` Vitaly Kuznetsov
2021-06-04 7:21 ` Vitaly Kuznetsov
2021-06-04 7:21 ` Vitaly Kuznetsov
2021-06-04 7:21 ` Vitaly Kuznetsov
2021-06-04 7:24 ` Paolo Bonzini
2021-06-04 7:24 ` Paolo Bonzini
2021-06-04 7:24 ` Paolo Bonzini
2021-06-04 7:24 ` Paolo Bonzini
2021-06-04 9:22 ` Sergey Senozhatsky [this message]
2021-06-04 9:22 ` Sergey Senozhatsky
2021-06-04 9:22 ` Sergey Senozhatsky
2021-06-04 9:22 ` Sergey Senozhatsky
2021-06-04 8:46 ` Marc Zyngier
2021-06-04 8:46 ` Marc Zyngier
2021-06-04 8:46 ` Marc Zyngier
2021-06-04 8:46 ` Marc Zyngier
2021-06-04 9:20 ` Sergey Senozhatsky
2021-06-04 9:20 ` Sergey Senozhatsky
2021-06-04 9:20 ` Sergey Senozhatsky
2021-06-04 9:20 ` Sergey Senozhatsky
2021-06-04 10:03 ` Marc Zyngier
2021-06-04 10:03 ` Marc Zyngier
2021-06-04 10:03 ` Marc Zyngier
2021-06-04 10:03 ` Marc Zyngier
2021-06-05 0:58 ` Sergey Senozhatsky
2021-06-05 0:58 ` Sergey Senozhatsky
2021-06-05 0:58 ` Sergey Senozhatsky
2021-06-05 0:58 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLnwum6AtcURNlRL@google.com \
--to=senozhatsky@chromium.org \
--cc=borntraeger@de.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=jmattson@google.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=suleiman@google.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.