* [PATCH] rtw88: Fix some memory leaks
@ 2021-06-20 19:24 Larry Finger
2021-06-20 19:32 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2021-06-20 19:24 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, Larry Finger, Stable
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
---
drivers/net/wireless/realtek/rtw88/coex.c | 4 +++-
drivers/net/wireless/realtek/rtw88/fw.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index cedbf3825848..e81bf5070183 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -591,8 +591,10 @@ void rtw_coex_info_response(struct rtw_dev *rtwdev, struct sk_buff *skb)
struct rtw_coex *coex = &rtwdev->coex;
u8 *payload = get_payload_from_coex_resp(skb);
- if (payload[0] != COEX_RESP_ACK_BY_WL_FW)
+ if (payload[0] != COEX_RESP_ACK_BY_WL_FW) {
+ dev_kfree_skb_any(skb);
return;
+ }
skb_queue_tail(&coex->queue, skb);
wake_up(&coex->wait);
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 797b08b2a494..43525ad8543f 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -231,9 +231,11 @@ void rtw_fw_c2h_cmd_rx_irqsafe(struct rtw_dev *rtwdev, u32 pkt_offset,
switch (c2h->id) {
case C2H_BT_MP_INFO:
rtw_coex_info_response(rtwdev, skb);
+ dev_kfree_skb_any(skb);
break;
case C2H_WLAN_RFON:
complete(&rtwdev->lps_leave_check);
+ dev_kfree_skb_any(skb);
break;
default:
/* pass offset for further operation */
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw88: Fix some memory leaks
2021-06-20 19:24 [PATCH] rtw88: Fix some memory leaks Larry Finger
@ 2021-06-20 19:32 ` Greg KH
2021-06-20 19:40 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2021-06-20 19:32 UTC (permalink / raw)
To: Larry Finger; +Cc: kvalo, linux-wireless, Stable
On Sun, Jun 20, 2021 at 02:24:07PM -0500, Larry Finger wrote:
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org>
No changelog at all? I know I would not take this if it were my
subsystem :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtw88: Fix some memory leaks
2021-06-20 19:32 ` Greg KH
@ 2021-06-20 19:40 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2021-06-20 19:40 UTC (permalink / raw)
To: Greg KH; +Cc: kvalo, linux-wireless, Stable
On 6/20/21 2:32 PM, Greg KH wrote:
> On Sun, Jun 20, 2021 at 02:24:07PM -0500, Larry Finger wrote:
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Cc: Stable <stable@vger.kernel.org>
>
> No changelog at all? I know I would not take this if it were my
> subsystem :)
Greg,
I would not accept it, now will Kalle. V2 on its way.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-20 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-20 19:24 [PATCH] rtw88: Fix some memory leaks Larry Finger
2021-06-20 19:32 ` Greg KH
2021-06-20 19:40 ` Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.