Re: [PATCH] usb: ehci: do not initialise static variables

Re: [PATCH] usb: ehci: do not initialise static variables

[Greg KH]

On Tue, Jun 08, 2021 at 08:09:30PM +0800, Jason Wang wrote:
> Global static variables dont need to be initialised manully.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/usb/host/ehci-hcd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This never showed up on lore.kernel.org for some reason.

Can you resend so it properly shows up?

thanks,

greg k-h

[PATCH] usb: ehci: do not initialise static variables

[Jason Wang]

Global static variables dont need to be initialised manully.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/usb/host/ehci-hcd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 35eec0c0edcd..36f5bf6a0752 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -76,12 +76,12 @@ static const char	hcd_name [] = "ehci_hcd";
 #define	EHCI_TUNE_FLS		1	/* (medium) 512-frame schedule */
 
 /* Initial IRQ latency:  faster than hw default */
-static int log2_irq_thresh = 0;		// 0 to 6
+static int log2_irq_thresh;		// 0 to 6
 module_param (log2_irq_thresh, int, S_IRUGO);
 MODULE_PARM_DESC (log2_irq_thresh, "log2 IRQ latency, 1-64 microframes");
 
 /* initial park setting:  slower than hw default */
-static unsigned park = 0;
+static unsigned park;
 module_param (park, uint, S_IRUGO);
 MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets");
 
-- 
2.31.1