From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit
Date: Wed, 9 Jun 2021 11:43:31 -0700 [thread overview]
Message-ID: <YMEL06gZC5n3J2bX@google.com> (raw)
In-Reply-To: <3f2c2543-c8a4-3477-76af-5c7614b643e8@kernel.org>
On 06/08, Chao Yu wrote:
> On 2021/6/8 0:56, Jaegeuk Kim wrote:
> > On 06/06, Chao Yu wrote:
> > > On 2021/5/26 4:49, Jaegeuk Kim wrote:
> > > > Once we release compressed blocks, we used to set IMMUTABLE bit. But it turned
> > > > out it disallows every fs operations which we don't need for compression.
> > > >
> > > > Let's just prevent writing data only.
> > > >
> > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > >
> > > Reviewed-by: Chao Yu <yuchao0@huawei.com>
> > >
> > > BTW, we need to expose .i_inline field to userspace since there is no
> > > way to check status of inode whether it has released blocks?
> >
> > Need to add some in F2FS_IOC_GET_COMPRESS_OPTION?
>
> We should not change this interface, in order to keep its compatibility for
> userspace usage. How about adding it in F2FS_IOC_GET_COMPRESS_OPTION_EX?
Hmm, or need to add it in getflags?
>
> Thanks,
>
> >
> > >
> > > Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit
Date: Wed, 9 Jun 2021 11:43:31 -0700 [thread overview]
Message-ID: <YMEL06gZC5n3J2bX@google.com> (raw)
In-Reply-To: <3f2c2543-c8a4-3477-76af-5c7614b643e8@kernel.org>
On 06/08, Chao Yu wrote:
> On 2021/6/8 0:56, Jaegeuk Kim wrote:
> > On 06/06, Chao Yu wrote:
> > > On 2021/5/26 4:49, Jaegeuk Kim wrote:
> > > > Once we release compressed blocks, we used to set IMMUTABLE bit. But it turned
> > > > out it disallows every fs operations which we don't need for compression.
> > > >
> > > > Let's just prevent writing data only.
> > > >
> > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > >
> > > Reviewed-by: Chao Yu <yuchao0@huawei.com>
> > >
> > > BTW, we need to expose .i_inline field to userspace since there is no
> > > way to check status of inode whether it has released blocks?
> >
> > Need to add some in F2FS_IOC_GET_COMPRESS_OPTION?
>
> We should not change this interface, in order to keep its compatibility for
> userspace usage. How about adding it in F2FS_IOC_GET_COMPRESS_OPTION_EX?
Hmm, or need to add it in getflags?
>
> Thanks,
>
> >
> > >
> > > Thanks,
next prev parent reply other threads:[~2021-06-09 18:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 20:49 [f2fs-dev] [PATCH 1/2] f2fs: let's allow compression for mmap files Jaegeuk Kim
2021-05-25 20:49 ` Jaegeuk Kim
2021-05-25 20:49 ` [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit Jaegeuk Kim
2021-05-25 20:49 ` Jaegeuk Kim
2021-06-06 13:53 ` [f2fs-dev] " Chao Yu
2021-06-06 13:53 ` Chao Yu
2021-06-07 16:56 ` Jaegeuk Kim
2021-06-07 16:56 ` Jaegeuk Kim
2021-06-07 23:17 ` Chao Yu
2021-06-07 23:17 ` Chao Yu
2021-06-09 18:43 ` Jaegeuk Kim [this message]
2021-06-09 18:43 ` Jaegeuk Kim
2021-06-10 15:24 ` Chao Yu
2021-06-10 15:24 ` Chao Yu
2021-05-26 9:09 ` [f2fs-dev] [PATCH 1/2] f2fs: let's allow compression for mmap files Chao Yu
2021-05-26 9:09 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMEL06gZC5n3J2bX@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.