All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Rix <trix@redhat.com>
Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com,
	nava.manne@xilinx.com, dinguyen@kernel.org,
	krzysztof.kozlowski@canonical.com, yilun.xu@intel.com,
	arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com,
	luca@lucaceresoli.net, linux-kernel@vger.kernel.org,
	linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs
Date: Wed, 9 Jun 2021 21:16:02 +0200	[thread overview]
Message-ID: <YMETcualK2uPMLMc@kroah.com> (raw)
In-Reply-To: <aba774cb-1135-26aa-6e20-3c00b4e269ac@redhat.com>

On Wed, Jun 09, 2021 at 11:52:44AM -0700, Tom Rix wrote:
> > My main complaints here are:
> > 	- these patches were not tested
> > 	- you renamed kernel modules "accidentally"
> > 	- you forgot SPDX lines
> > 	- lack of description of why these files being moved was
> > 	  necessary in the changelog where you moved the files
> > 
> > Remember, patch 0/X never shows up in changelogs...
> 
> I will respin and collapse the patches to a single patch with a better
> commit log.

They should not be a single patch, I never said that at all :(

Please read what I wrote above, did I ever mention there was too many
patches in the series here?

{sigh}

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Rix <trix@redhat.com>
Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com,
	nava.manne@xilinx.com, dinguyen@kernel.org,
	krzysztof.kozlowski@canonical.com, yilun.xu@intel.com,
	arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com,
	luca@lucaceresoli.net, linux-kernel@vger.kernel.org,
	linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs
Date: Wed, 9 Jun 2021 21:16:02 +0200	[thread overview]
Message-ID: <YMETcualK2uPMLMc@kroah.com> (raw)
In-Reply-To: <aba774cb-1135-26aa-6e20-3c00b4e269ac@redhat.com>

On Wed, Jun 09, 2021 at 11:52:44AM -0700, Tom Rix wrote:
> > My main complaints here are:
> > 	- these patches were not tested
> > 	- you renamed kernel modules "accidentally"
> > 	- you forgot SPDX lines
> > 	- lack of description of why these files being moved was
> > 	  necessary in the changelog where you moved the files
> > 
> > Remember, patch 0/X never shows up in changelogs...
> 
> I will respin and collapse the patches to a single patch with a better
> commit log.

They should not be a single patch, I never said that at all :(

Please read what I wrote above, did I ever mention there was too many
patches in the series here?

{sigh}

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-09 19:16 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 14:22 [PATCH v2 0/4] fpga: reorganize to subdirs trix
2021-06-09 14:22 ` trix
2021-06-09 14:22 ` trix
2021-06-09 14:22   ` trix
2021-06-09 14:22 ` [PATCH v2 1/4] fpga: dfl: reorganize to subdir layout trix
2021-06-09 14:22   ` trix
2021-06-09 14:22 ` [PATCH v2 2/4] fpga: xilinx: " trix
2021-06-09 14:22   ` trix
2021-06-09 14:55   ` Greg KH
2021-06-09 14:55     ` Greg KH
2021-06-18 11:07   ` kernel test robot
2021-06-21 20:57   ` kernel test robot
2021-06-09 14:22 ` [PATCH v2 3/4] fpga: altera: " trix
2021-06-09 14:22   ` trix
2021-06-09 14:56   ` Greg KH
2021-06-09 14:56     ` Greg KH
2021-06-09 14:22 ` [PATCH v2 4/4] fpga: lattice: " trix
2021-06-09 14:22   ` trix
2021-06-09 14:56   ` Greg KH
2021-06-09 14:56     ` Greg KH
2021-06-18 12:24   ` kernel test robot
2021-06-18 12:27     ` Arnd Bergmann
2021-06-18 22:12       ` Moritz Fischer
2021-06-18 22:16         ` Moritz Fischer
2021-06-09 14:51 ` [PATCH v2 0/4] fpga: reorganize to subdirs Greg KH
2021-06-09 14:51   ` Greg KH
2021-06-09 14:53 ` Greg KH
2021-06-09 14:53   ` Greg KH
2021-06-09 15:08   ` Tom Rix
2021-06-09 15:08     ` Tom Rix
2021-06-09 16:38     ` Greg KH
2021-06-09 16:38       ` Greg KH
2021-06-09 16:50       ` Tom Rix
2021-06-09 16:50         ` Tom Rix
2021-06-09 17:13         ` Greg KH
2021-06-09 17:13           ` Greg KH
2021-06-09 18:52           ` Tom Rix
2021-06-09 18:52             ` Tom Rix
2021-06-09 19:16             ` Greg KH [this message]
2021-06-09 19:16               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMETcualK2uPMLMc@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=dinguyen@kernel.org \
    --cc=fpacheco@redhat.com \
    --cc=hao.wu@intel.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=mdf@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=nava.manne@xilinx.com \
    --cc=richard.gong@intel.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.