From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: clean up /sys/fs/f2fs/<disk>/features
Date: Thu, 10 Jun 2021 16:09:17 -0700 [thread overview]
Message-ID: <YMKbncoLgqemjzmu@gmail.com> (raw)
In-Reply-To: <YLxeynwR0v23c3sV@google.com>
On Sat, Jun 05, 2021 at 10:36:10PM -0700, Jaegeuk Kim wrote:
> Let's create /sys/fs/f2fs/<disk>/feature_list/ to meet sysfs rule.
>
> Note that there are three feature list entries:
> 1) /sys/fs/f2fs/features
> : shows runtime features supported by in-kernel f2fs along with Kconfig.
> - ref. F2FS_FEATURE_RO_ATTR()
>
> 2) /sys/fs/f2fs/$s_id/features <deprecated>
> : shows on-disk features enabled by mkfs.f2fs, used for old kernels. This
> won't add new feature anymore, and thus, users should check entries in 3)
> instead of this 2).
>
> 3) /sys/fs/f2fs/$s_id/feature_list
> : shows on-disk features enabled by mkfs.f2fs per instance, which follows
> sysfs entry rule where each entry should expose single value.
> This list covers old feature list provided by 2) and beyond. Therefore,
> please add new on-disk feature in this list only.
> - ref. F2FS_SB_FEATURE_RO_ATTR()
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>
> change log from v1:
> - adjust Eric's comment
>
> Documentation/ABI/testing/sysfs-fs-f2fs | 29 +++-
> fs/f2fs/f2fs.h | 3 +
> fs/f2fs/sysfs.c | 196 ++++++++++++++++--------
> 3 files changed, 163 insertions(+), 65 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/3 v2] f2fs: clean up /sys/fs/f2fs/<disk>/features
Date: Thu, 10 Jun 2021 16:09:17 -0700 [thread overview]
Message-ID: <YMKbncoLgqemjzmu@gmail.com> (raw)
In-Reply-To: <YLxeynwR0v23c3sV@google.com>
On Sat, Jun 05, 2021 at 10:36:10PM -0700, Jaegeuk Kim wrote:
> Let's create /sys/fs/f2fs/<disk>/feature_list/ to meet sysfs rule.
>
> Note that there are three feature list entries:
> 1) /sys/fs/f2fs/features
> : shows runtime features supported by in-kernel f2fs along with Kconfig.
> - ref. F2FS_FEATURE_RO_ATTR()
>
> 2) /sys/fs/f2fs/$s_id/features <deprecated>
> : shows on-disk features enabled by mkfs.f2fs, used for old kernels. This
> won't add new feature anymore, and thus, users should check entries in 3)
> instead of this 2).
>
> 3) /sys/fs/f2fs/$s_id/feature_list
> : shows on-disk features enabled by mkfs.f2fs per instance, which follows
> sysfs entry rule where each entry should expose single value.
> This list covers old feature list provided by 2) and beyond. Therefore,
> please add new on-disk feature in this list only.
> - ref. F2FS_SB_FEATURE_RO_ATTR()
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>
> change log from v1:
> - adjust Eric's comment
>
> Documentation/ABI/testing/sysfs-fs-f2fs | 29 +++-
> fs/f2fs/f2fs.h | 3 +
> fs/f2fs/sysfs.c | 196 ++++++++++++++++--------
> 3 files changed, 163 insertions(+), 65 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2021-06-10 23:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:32 [f2fs-dev] [PATCH 1/3] f2fs: Advertise encrypted casefolding in sysfs Jaegeuk Kim
2021-06-05 0:32 ` Jaegeuk Kim
2021-06-05 0:32 ` [f2fs-dev] [PATCH 2/3] f2fs: add pin_file in feature list Jaegeuk Kim
2021-06-05 0:32 ` Jaegeuk Kim
2021-06-07 13:57 ` [f2fs-dev] " Chao Yu
2021-06-07 13:57 ` Chao Yu
2021-06-05 0:32 ` [f2fs-dev] [PATCH 3/3] f2fs: clean up /sys/fs/f2fs/<disk>/features Jaegeuk Kim
2021-06-05 0:32 ` Jaegeuk Kim
2021-06-05 2:02 ` [f2fs-dev] " Eric Biggers
2021-06-05 2:02 ` Eric Biggers
2021-06-06 5:36 ` [f2fs-dev] [PATCH 3/3 v2] " Jaegeuk Kim
2021-06-06 5:36 ` Jaegeuk Kim
2021-06-07 14:00 ` [f2fs-dev] " Chao Yu
2021-06-07 14:00 ` Chao Yu
2021-06-07 16:58 ` Jaegeuk Kim
2021-06-07 16:58 ` Jaegeuk Kim
2021-06-10 23:09 ` Eric Biggers [this message]
2021-06-10 23:09 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMKbncoLgqemjzmu@gmail.com \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.