All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Siddharth Gupta <sidgup@codeaurora.org>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v4 2/4] remoteproc: core: Move validate before device add
Date: Tue, 15 Jun 2021 21:06:16 +0200	[thread overview]
Message-ID: <YMj6KOb2uNdA9Tpj@kroah.com> (raw)
In-Reply-To: <1623783824-13395-3-git-send-email-sidgup@codeaurora.org>

On Tue, Jun 15, 2021 at 12:03:42PM -0700, Siddharth Gupta wrote:
> We can validate whether the remoteproc is correctly setup before
> making the cdev_add and device_add calls. This saves us the
> trouble of cleaning up later on.
> 
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: stable@vger.kernel.org
> ---
>  drivers/remoteproc/remoteproc_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Why is this relevant for stable?  What commit does this fix?  Please put
a Fixes: tag for that.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Siddharth Gupta <sidgup@codeaurora.org>
Cc: bjorn.andersson@linaro.org, ohad@wizery.com,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v4 2/4] remoteproc: core: Move validate before device add
Date: Tue, 15 Jun 2021 21:06:16 +0200	[thread overview]
Message-ID: <YMj6KOb2uNdA9Tpj@kroah.com> (raw)
In-Reply-To: <1623783824-13395-3-git-send-email-sidgup@codeaurora.org>

On Tue, Jun 15, 2021 at 12:03:42PM -0700, Siddharth Gupta wrote:
> We can validate whether the remoteproc is correctly setup before
> making the cdev_add and device_add calls. This saves us the
> trouble of cleaning up later on.
> 
> Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: stable@vger.kernel.org
> ---
>  drivers/remoteproc/remoteproc_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Why is this relevant for stable?  What commit does this fix?  Please put
a Fixes: tag for that.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-15 19:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 19:03 [PATCH v4 0/4] remoteproc: core: Fixes for rproc cdev and add Siddharth Gupta
2021-06-15 19:03 ` [PATCH v4 1/4] remoteproc: core: Move cdev add before device add Siddharth Gupta
2021-06-15 19:03 ` [PATCH v4 2/4] remoteproc: core: Move validate " Siddharth Gupta
2021-06-15 19:06   ` Greg KH [this message]
2021-06-15 19:06     ` Greg KH
2021-06-15 19:03 ` [PATCH v4 3/4] remoteproc: core: Fix cdev remove and rproc del Siddharth Gupta
2021-06-15 19:06   ` Greg KH
2021-06-15 19:06     ` Greg KH
2021-06-15 19:03 ` [PATCH v4 4/4] remoteproc: core: Cleanup device in case of failure Siddharth Gupta
2021-06-15 19:06   ` Greg KH
2021-06-15 19:06     ` Greg KH
2021-06-15 20:21     ` Siddharth Gupta
2021-06-16  5:56       ` Greg KH
2021-06-16  5:56         ` Greg KH
2021-06-23 21:50 ` [PATCH v4 0/4] remoteproc: core: Fixes for rproc cdev and add patchwork-bot+linux-remoteproc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMj6KOb2uNdA9Tpj@kroah.com \
    --to=greg@kroah.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=psodagud@codeaurora.org \
    --cc=sidgup@codeaurora.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.