All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 9529/10007] mm/hugetlb.c:1591:9: warning: no previous prototype for function 'hugetlb_basepage_index'
Date: Tue, 15 Jun 2021 11:32:10 -0700	[thread overview]
Message-ID: <YMjyKtBiQJHN8JXL@archlinux-ax161> (raw)
In-Reply-To: <YMjPXKrHfqZKDisp@casper.infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

On Tue, Jun 15, 2021 at 05:03:40PM +0100, Matthew Wilcox wrote:
> On Tue, Jun 15, 2021 at 11:58:36PM +0800, kernel test robot wrote:
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> mm/hugetlb.c:1591:9: warning: no previous prototype for function 'hugetlb_basepage_index' [-Wmissing-prototypes]
> >    pgoff_t hugetlb_basepage_index(struct page *page)
> 
> So clang requires the prototype to still be in scope, while gcc doesn't.
> Does one of our clangers want to file a bug about that?

I see the exact same warning with GCC 11.1.0:

$ curl -LSs https://lore.kernel.org/linux-mm/202106152328.Mh5S48hE-lkp(a)intel.com/2-a.bin | gzip -d > .config

$ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- W=1 olddefconfig mm/hugetlb.c
mm/hugetlb.c:1591:9: warning: no previous prototype for 'hugetlb_basepage_index' [-Wmissing-prototypes]
 1591 | pgoff_t hugetlb_basepage_index(struct page *page)
      |         ^~~~~~~~~~~~~~~~~~~~~~

Cheers,
Nathan

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
	Hugh Dickins <hughd@google.com>,
	kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [linux-next:master 9529/10007] mm/hugetlb.c:1591:9: warning: no previous prototype for function 'hugetlb_basepage_index'
Date: Tue, 15 Jun 2021 11:32:10 -0700	[thread overview]
Message-ID: <YMjyKtBiQJHN8JXL@archlinux-ax161> (raw)
In-Reply-To: <YMjPXKrHfqZKDisp@casper.infradead.org>

On Tue, Jun 15, 2021 at 05:03:40PM +0100, Matthew Wilcox wrote:
> On Tue, Jun 15, 2021 at 11:58:36PM +0800, kernel test robot wrote:
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> mm/hugetlb.c:1591:9: warning: no previous prototype for function 'hugetlb_basepage_index' [-Wmissing-prototypes]
> >    pgoff_t hugetlb_basepage_index(struct page *page)
> 
> So clang requires the prototype to still be in scope, while gcc doesn't.
> Does one of our clangers want to file a bug about that?

I see the exact same warning with GCC 11.1.0:

$ curl -LSs https://lore.kernel.org/linux-mm/202106152328.Mh5S48hE-lkp@intel.com/2-a.bin | gzip -d > .config

$ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- W=1 olddefconfig mm/hugetlb.c
mm/hugetlb.c:1591:9: warning: no previous prototype for 'hugetlb_basepage_index' [-Wmissing-prototypes]
 1591 | pgoff_t hugetlb_basepage_index(struct page *page)
      |         ^~~~~~~~~~~~~~~~~~~~~~

Cheers,
Nathan


  reply	other threads:[~2021-06-15 18:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 15:58 [linux-next:master 9529/10007] mm/hugetlb.c:1591:9: warning: no previous prototype for function 'hugetlb_basepage_index' kernel test robot
2021-06-15 15:58 ` kernel test robot
2021-06-15 16:03 ` Matthew Wilcox
2021-06-15 16:03   ` Matthew Wilcox
2021-06-15 18:32   ` Nathan Chancellor [this message]
2021-06-15 18:32     ` Nathan Chancellor
2021-06-15 18:50     ` Nick Desaulniers
2021-06-15 18:50       ` Nick Desaulniers
2021-06-15 19:01       ` Matthew Wilcox
2021-06-15 19:01         ` Matthew Wilcox
2021-06-15 23:37         ` Hugh Dickins
2021-06-15 23:37           ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMjyKtBiQJHN8JXL@archlinux-ax161 \
    --to=nathan@kernel.org \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.