From: Peter Xu <peterx@redhat.com>
To: huangy81@chinatelecom.cn
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Chuan Zheng <zhengchuan@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v8 0/6] support dirtyrate at the granualrity of vcpu
Date: Fri, 18 Jun 2021 12:00:02 -0400 [thread overview]
Message-ID: <YMzDAjeyK3at9DUu@t490s> (raw)
In-Reply-To: <cover.1624028590.git.huangy81@chinatelecom.cn>
On Fri, Jun 18, 2021 at 11:32:01PM +0800, huangy81@chinatelecom.cn wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
>
> v8
I have one last comment in patch 2, the rest looks good to me, thanks.
I think the next step can be that we add another command to configure dirty
rate limit for each of the vcpu. It can be the 3rd bit in the
global_dirty_tracking and it should require dirty ring too to be there, but I
haven't thought deeper.. Then after that, we may teach migration code some
algorithm to auto-setup these per-vcpu throttling, it'll grow into some kind of
per-vcpu auto-converge.
Do you think above would be something worth trying out? And.. Dave/Paolo/Juan?
Btw, this series cannot apply cleanly to master here. Maybe you need to pull
and rebase?
--
Peter Xu
next prev parent reply other threads:[~2021-06-18 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 15:32 [PATCH v8 0/6] support dirtyrate at the granualrity of vcpu huangy81
2021-06-18 15:32 ` [PATCH v8 1/6] KVM: introduce dirty_pages and kvm_dirty_ring_enabled huangy81
2021-06-18 15:32 ` [PATCH v8 2/6] memory: make global_dirty_tracking a bitmask huangy81
2021-06-18 15:46 ` Peter Xu
2021-06-18 16:02 ` Hyman
2021-06-18 16:16 ` Hyman
2021-06-18 16:42 ` Peter Xu
2021-06-18 15:32 ` [PATCH v8 3/6] migration/dirtyrate: introduce struct and adjust DirtyRateStat huangy81
2021-06-18 15:32 ` [PATCH v8 4/6] migration/dirtyrate: adjust order of registering thread huangy81
2021-06-18 15:32 ` [PATCH v8 5/6] migration/dirtyrate: move init step of calculation to main thread huangy81
2021-06-18 15:32 ` [PATCH v8 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation huangy81
2021-06-18 16:00 ` Peter Xu [this message]
2021-06-18 16:36 ` [PATCH v8 0/6] support dirtyrate at the granualrity of vcpu Hyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMzDAjeyK3at9DUu@t490s \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.