From: "Jonathan Neuschäfer" <j.ne@posteo.net>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Ash Logan" <ash@heyquark.com>,
"Paul Mackerras" <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
"Jonathan Neuschäfer" <j.ne@posteo.net>
Subject: Re: [PATCH v2 3/4] powerpc: wii.dts: Expose the OTP on this platform
Date: Fri, 2 Jul 2021 08:56:31 +0000 [thread overview]
Message-ID: <YN7Uv/43TwL4+9ic@latitude> (raw)
In-Reply-To: <20210701195655.knbcikdga57a7epx@luna>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Thu, Jul 01, 2021 at 09:56:55PM +0200, Emmanuel Gil Peyrot wrote:
> On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neuschäfer wrote:
> > On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote:
[...]
> > > + otp@d8001ec {
> > > + compatible = "nintendo,hollywood-otp";
> > > + reg = <0x0d8001ec 0x8>;
> >
> > The OTP registers overlap with the previous node, control@d800100.
> > Not sure what's the best way to structure the devicetree in this case,
> > maybe something roughly like the following (untested, unverified):
> [snip]
>
> I couldn’t get this to work, but additionally it looks like it should
> start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given
> https://wiibrew.org/wiki/Hardware/Hollywood_Registers
>
> Would it make sense, for the time being, to reduce the size of this
> control@d800100 device to the single register currently being used by
> arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the
> system) and leave the refactor of restart + OTP + PIC + GPIO for a
> future series?
Makes sense to me!
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.ne@posteo.net>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Cc: "Jonathan Neuschäfer" <j.ne@posteo.net>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
"Ash Logan" <ash@heyquark.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] powerpc: wii.dts: Expose the OTP on this platform
Date: Fri, 2 Jul 2021 08:56:31 +0000 [thread overview]
Message-ID: <YN7Uv/43TwL4+9ic@latitude> (raw)
In-Reply-To: <20210701195655.knbcikdga57a7epx@luna>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Thu, Jul 01, 2021 at 09:56:55PM +0200, Emmanuel Gil Peyrot wrote:
> On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neuschäfer wrote:
> > On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote:
[...]
> > > + otp@d8001ec {
> > > + compatible = "nintendo,hollywood-otp";
> > > + reg = <0x0d8001ec 0x8>;
> >
> > The OTP registers overlap with the previous node, control@d800100.
> > Not sure what's the best way to structure the devicetree in this case,
> > maybe something roughly like the following (untested, unverified):
> [snip]
>
> I couldn’t get this to work, but additionally it looks like it should
> start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given
> https://wiibrew.org/wiki/Hardware/Hollywood_Registers
>
> Would it make sense, for the time being, to reduce the size of this
> control@d800100 device to the single register currently being used by
> arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the
> system) and leave the refactor of restart + OTP + PIC + GPIO for a
> future series?
Makes sense to me!
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-02 8:57 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 9:50 [PATCH v2 0/4] nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP Emmanuel Gil Peyrot
2021-05-19 9:50 ` Emmanuel Gil Peyrot
2021-05-19 9:50 ` [PATCH v2 1/4] " Emmanuel Gil Peyrot
2021-05-19 9:50 ` Emmanuel Gil Peyrot
2021-06-26 23:24 ` Jonathan Neuschäfer
2021-06-26 23:24 ` Jonathan Neuschäfer
2021-05-19 9:50 ` [PATCH v2 2/4] dt-bindings: nintendo-otp: Document the Wii and Wii U OTP support Emmanuel Gil Peyrot
2021-05-19 9:50 ` Emmanuel Gil Peyrot
2021-05-21 1:37 ` Rob Herring
2021-05-21 1:37 ` Rob Herring
2021-06-26 21:27 ` Jonathan Neuschäfer
2021-06-26 21:27 ` Jonathan Neuschäfer
2021-05-19 9:50 ` [PATCH v2 3/4] powerpc: wii.dts: Expose the OTP on this platform Emmanuel Gil Peyrot
2021-05-19 9:50 ` Emmanuel Gil Peyrot
2021-06-26 23:34 ` Jonathan Neuschäfer
2021-06-26 23:34 ` Jonathan Neuschäfer
2021-07-01 19:56 ` Emmanuel Gil Peyrot
2021-07-01 19:56 ` Emmanuel Gil Peyrot
2021-07-02 8:56 ` Jonathan Neuschäfer [this message]
2021-07-02 8:56 ` Jonathan Neuschäfer
2021-07-03 15:53 ` Segher Boessenkool
2021-07-03 15:53 ` Segher Boessenkool
2021-05-19 9:50 ` [PATCH v2 4/4] powerpc: wii_defconfig: Enable OTP by default Emmanuel Gil Peyrot
2021-05-19 9:50 ` Emmanuel Gil Peyrot
2021-06-26 23:38 ` Jonathan Neuschäfer
2021-06-26 23:38 ` Jonathan Neuschäfer
2021-07-01 22:57 ` [PATCH v3 0/5] nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP Emmanuel Gil Peyrot
2021-07-01 22:57 ` Emmanuel Gil Peyrot
2021-07-01 22:57 ` [PATCH v3 1/5] " Emmanuel Gil Peyrot
2021-07-01 22:57 ` Emmanuel Gil Peyrot
2021-07-01 22:57 ` [PATCH v3 2/5] dt-bindings: nintendo-otp: Document the Wii and Wii U OTP support Emmanuel Gil Peyrot
2021-07-01 22:57 ` Emmanuel Gil Peyrot
2021-07-14 22:51 ` Rob Herring
2021-07-14 22:51 ` Rob Herring
2021-07-01 22:57 ` [PATCH v3 3/5] powerpc: wii.dts: Reduce the size of the control area Emmanuel Gil Peyrot
2021-07-01 22:57 ` Emmanuel Gil Peyrot
2021-07-01 22:57 ` [PATCH v3 4/5] powerpc: wii.dts: Expose the OTP on this platform Emmanuel Gil Peyrot
2021-07-01 22:57 ` Emmanuel Gil Peyrot
2021-07-01 22:57 ` [PATCH v3 5/5] powerpc: wii_defconfig: Enable OTP by default Emmanuel Gil Peyrot
2021-07-01 22:57 ` Emmanuel Gil Peyrot
2021-08-01 7:38 ` [PATCH v4 0/5] nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP Emmanuel Gil Peyrot
2021-08-01 7:38 ` Emmanuel Gil Peyrot
2021-08-01 7:38 ` [PATCH v4 1/5] " Emmanuel Gil Peyrot
2021-08-01 7:38 ` Emmanuel Gil Peyrot
2021-08-01 7:38 ` [PATCH v4 2/5] dt-bindings: nintendo-otp: Document the Wii and Wii U OTP support Emmanuel Gil Peyrot
2021-08-01 7:38 ` Emmanuel Gil Peyrot
2021-08-06 21:07 ` Rob Herring
2021-08-06 21:07 ` Rob Herring
2021-08-01 7:38 ` [PATCH v4 3/5] powerpc: wii.dts: Reduce the size of the control area Emmanuel Gil Peyrot
2021-08-01 7:38 ` Emmanuel Gil Peyrot
2021-08-01 7:38 ` [PATCH v4 4/5] powerpc: wii.dts: Expose the OTP on this platform Emmanuel Gil Peyrot
2021-08-01 7:38 ` Emmanuel Gil Peyrot
2021-08-01 7:38 ` [PATCH v4 5/5] powerpc: wii_defconfig: Enable OTP by default Emmanuel Gil Peyrot
2021-08-01 7:38 ` Emmanuel Gil Peyrot
2021-08-10 10:57 ` [PATCH v4 0/5] nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP Srinivas Kandagatla
2021-08-10 10:57 ` Srinivas Kandagatla
2021-08-18 13:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN7Uv/43TwL4+9ic@latitude \
--to=j.ne@posteo.net \
--cc=ash@heyquark.com \
--cc=devicetree@vger.kernel.org \
--cc=linkmauve@linkmauve.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.