All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sergey Larin <cerg2010cerg2010@mail.ru>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-input@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: stmpe-keypad - add STMPE1801 support
Date: Sun, 20 Jun 2021 22:30:07 -0700	[thread overview]
Message-ID: <YNAj30vl2yGxRX4e@google.com> (raw)
In-Reply-To: <20210618145149.10136-1-cerg2010cerg2010@mail.ru>

Hi Sergey,

On Fri, Jun 18, 2021 at 05:51:49PM +0300, Sergey Larin wrote:
> @@ -176,7 +232,9 @@ static irqreturn_t stmpe_keypad_irq(int irq, void *dev)
>  		u8 data = fifo[i];
>  		int row = (data & STMPE_KPC_DATA_ROW) >> 3;
>  		int col = data & STMPE_KPC_DATA_COL;
> -		int code = MATRIX_SCAN_CODE(row, col, STMPE_KEYPAD_ROW_SHIFT);
> +		int code = variant->read_inverted ?
> +			  MATRIX_SCAN_CODE(col, row, STMPE_KEYPAD_ROW_SHIFT)
> +			: MATRIX_SCAN_CODE(row, col, STMPE_KEYPAD_ROW_SHIFT);

Do we really need to do this swap vs. simply arranging the keymap
differently for 1801?

Thanks.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sergey Larin <cerg2010cerg2010@mail.ru>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-input@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: stmpe-keypad - add STMPE1801 support
Date: Sun, 20 Jun 2021 22:30:07 -0700	[thread overview]
Message-ID: <YNAj30vl2yGxRX4e@google.com> (raw)
In-Reply-To: <20210618145149.10136-1-cerg2010cerg2010@mail.ru>

Hi Sergey,

On Fri, Jun 18, 2021 at 05:51:49PM +0300, Sergey Larin wrote:
> @@ -176,7 +232,9 @@ static irqreturn_t stmpe_keypad_irq(int irq, void *dev)
>  		u8 data = fifo[i];
>  		int row = (data & STMPE_KPC_DATA_ROW) >> 3;
>  		int col = data & STMPE_KPC_DATA_COL;
> -		int code = MATRIX_SCAN_CODE(row, col, STMPE_KEYPAD_ROW_SHIFT);
> +		int code = variant->read_inverted ?
> +			  MATRIX_SCAN_CODE(col, row, STMPE_KEYPAD_ROW_SHIFT)
> +			: MATRIX_SCAN_CODE(row, col, STMPE_KEYPAD_ROW_SHIFT);

Do we really need to do this swap vs. simply arranging the keymap
differently for 1801?

Thanks.

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-21  5:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 14:51 [PATCH] Input: stmpe-keypad - add STMPE1801 support Sergey Larin
2021-06-18 14:51 ` Sergey Larin
2021-06-21  5:30 ` Dmitry Torokhov [this message]
2021-06-21  5:30   ` Dmitry Torokhov
2021-06-23  0:05   ` Sergey Larin
2021-06-23  0:05     ` Sergey Larin
2025-08-01 21:21 ` Paul Sajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNAj30vl2yGxRX4e@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=cerg2010cerg2010@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.