From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 1/2] backlight: lm3630a: fix return code of .update_status() callback
Date: Tue, 22 Jun 2021 14:11:01 +0100 [thread overview]
Message-ID: <YNHhZRkKFoucAyQJ@dell> (raw)
In-Reply-To: <20210621122148.116863-2-u.kleine-koenig@pengutronix.de>
On Mon, 21 Jun 2021, Uwe Kleine-König wrote:
> According to <linux/backlight.h> .update_status() is supposed to
> return 0 on success and a negative error code otherwise. Adapt
> lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status() to
> actually do it.
>
> While touching that also add the error code to the failure message.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/backlight/lm3630a_bl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Fixed the subject line for you and applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH v3 1/2] backlight: lm3630a: fix return code of .update_status() callback
Date: Tue, 22 Jun 2021 14:11:01 +0100 [thread overview]
Message-ID: <YNHhZRkKFoucAyQJ@dell> (raw)
In-Reply-To: <20210621122148.116863-2-u.kleine-koenig@pengutronix.de>
On Mon, 21 Jun 2021, Uwe Kleine-König wrote:
> According to <linux/backlight.h> .update_status() is supposed to
> return 0 on success and a negative error code otherwise. Adapt
> lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status() to
> actually do it.
>
> While touching that also add the error code to the failure message.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/backlight/lm3630a_bl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Fixed the subject line for you and applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-06-22 13:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 12:21 [PATCH v3 0/2] backlight: lm3630a: convert to atomic PWM API Uwe Kleine-König
2021-06-21 12:21 ` Uwe Kleine-König
2021-06-21 12:21 ` [PATCH v3 1/2] backlight: lm3630a: fix return code of .update_status() callback Uwe Kleine-König
2021-06-21 12:21 ` Uwe Kleine-König
2021-06-21 13:06 ` Daniel Thompson
2021-06-21 13:06 ` Daniel Thompson
2021-06-22 13:11 ` Lee Jones [this message]
2021-06-22 13:11 ` Lee Jones
2021-06-21 12:21 ` [PATCH v3 2/2] backlight: lm3630a: convert to atomic PWM API and check for errors Uwe Kleine-König
2021-06-21 12:21 ` Uwe Kleine-König
2021-06-21 13:14 ` Daniel Thompson
2021-06-21 13:14 ` Daniel Thompson
2021-06-22 13:12 ` Lee Jones
2021-06-22 13:12 ` Lee Jones
2021-06-24 20:10 ` Uwe Kleine-König
2021-06-25 8:44 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNHhZRkKFoucAyQJ@dell \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.