From: Petr Vorel <pvorel@suse.cz>
To: "James Dong (董世江)" <dongshijiang@inspur.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>,
Alexey Kodanev <aleksei.kodanev@bell-sw.com>,
Steve Dickson <SteveD@redhat.com>,
"libtirpc-devel@lists.sourceforge.net"
<libtirpc-devel@lists.sourceforge.net>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [LTP] [PATCH] fix rpc_suite/rpc:add check returned value
Date: Wed, 23 Jun 2021 18:06:44 +0200 [thread overview]
Message-ID: <YNNcFHTRmBtviT+Y@pevik> (raw)
In-Reply-To: <52e4b3cba7d74f17b64816acaf50be01@inspur.com>
Hi Dong,
> Hi Petr
> I think this is just a simple test of some APIs, but some test cases are not standardized and cause errors like "Segmentation fault" during testing. I think it is necessary to fix these errors or delete these tests.
Sure this fix can get in. I saw issues with some tests on openSUSE, but that's a
separate problem (I was not able to find the problem thus report it.
> Kind regards,
> Dong
> > +++ b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/rpc/rpc_createdestroy_svc_destroy/rpc_svc_destroy.c
> > @@ -46,6 +46,11 @@ int main(void)
> > //First of all, create a server
> > svcr = svcfd_create(fd, 0, 0);
> > +
> > + //check returned value
> > + if ((SVCXPRT *) svcr == NULL) {
IMHO casting is not required, right? Just
if (svcr == NULL) {
Kind regards,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fix rpc_suite/rpc:add check returned value
Date: Wed, 23 Jun 2021 18:06:44 +0200 [thread overview]
Message-ID: <YNNcFHTRmBtviT+Y@pevik> (raw)
In-Reply-To: <52e4b3cba7d74f17b64816acaf50be01@inspur.com>
Hi Dong,
> Hi Petr
> I think this is just a simple test of some APIs, but some test cases are not standardized and cause errors like "Segmentation fault" during testing. I think it is necessary to fix these errors or delete these tests.
Sure this fix can get in. I saw issues with some tests on openSUSE, but that's a
separate problem (I was not able to find the problem thus report it.
> Kind regards,
> Dong
> > +++ b/testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/rpc/rpc_createdestroy_svc_destroy/rpc_svc_destroy.c
> > @@ -46,6 +46,11 @@ int main(void)
> > //First of all, create a server
> > svcr = svcfd_create(fd, 0, 0);
> > +
> > + //check returned value
> > + if ((SVCXPRT *) svcr == NULL) {
IMHO casting is not required, right? Just
if (svcr == NULL) {
Kind regards,
Petr
next prev parent reply other threads:[~2021-06-23 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 9:11 [LTP] [PATCH] fix rpc_suite/rpc:add check returned value James Dong (董世江)
2021-06-21 9:11 ` James Dong =?unknown-8bit?b?6JGj5LiW5rGf?=
2021-06-23 16:06 ` Petr Vorel [this message]
2021-06-23 16:06 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 1:02 James Dong (董世江)
2021-06-24 1:02 ` James Dong =?unknown-8bit?b?6JGj5LiW5rGf?=
2021-06-17 7:08 dongshijiang
2021-06-21 7:59 ` Petr Vorel
2021-06-21 7:59 ` Petr Vorel
2021-06-24 18:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNNcFHTRmBtviT+Y@pevik \
--to=pvorel@suse.cz \
--cc=SteveD@redhat.com \
--cc=aleksei.kodanev@bell-sw.com \
--cc=dongshijiang@inspur.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.